fix assert in intrinsics::mem::replace_element #230

Author: greenhat

codegen/masm/intrinsics/mem.masm

@@ -364,8 +364,8 @@ proc.store_felt_unchecked # [waddr, index, value]
     mem_loadw  # [w0, w1, w2, w3, waddr, index, value]
 
     # rewrite the desired element
-    movup.6
-    movup.5
+    movup.6 # [value, w0, w1, w2, w3, waddr, index]
+    movup.6 # [index, value, w0, w1, w2, w3, waddr]
     exec.replace_element
 
     # store the updated word

codegen/masm/src/tests.rs

@@ -458,7 +458,7 @@ fn i32_checked_neg() {
 }
 
 #[test]
-fn codegen_mem_store_sw() {
+fn codegen_mem_store_sw_load_sw() {
     const MEMORY_SIZE_BYTES: u32 = 1048576 * 10;
     const MEMORY_SIZE_VM_WORDS: u32 = MEMORY_SIZE_BYTES / 16;
     let mut harness = TestByEmulationHarness::with_emulator_config(
@@ -516,12 +516,21 @@ fn codegen_mem_store_sw() {
         harness.reset();
     };
 
-    // TODO: on ptr % 4 == 0 load_sw always returns 0
+    // TODO: seems like on ptr % 4 == 0 load_sw always returns 0
     // test(0, 999);
     // test(8, 999);
     test(1, 42);
+    test(2, 42);
+    test(3, 42);
     test(25, u32::MAX);
-    // assert in replace_element fails
+    // TODO: out of bounds memory access
+    // test(28, 42);
+    // ...
+    // test(31, 42);
+    //
+    test(32, 42);
+    test(33, 42);
+    test(63, 42);
     test(64, 42);
     test(MEMORY_SIZE_BYTES - 4, u32::MAX);
 }