Skip to content

make enable_distsql defaults on #3544

@aceforeverd

Description

@aceforeverd

tablet server uses this flag enable_distsql to enable cluster optimization

if (IsClusterMode()) {
options.SetClusterOptimized(FLAGS_enable_distsql);
} else {
options.SetClusterOptimized(false);
}
. It is on with release configurations: release/conf/tablet.flags.template, but no in src/flags.cc. Which as a results, won't enabled in mini_cluster tests, e.g sql_sdk_test.

There is a PR previously #3295, but turns out breaks existing tests. It means there exists cases that is OK with request mode, but not request(cluster) mode.

#3531 is a example, deployment tests not fail for those tests, simply because enable_distsql not turned on.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions