Don't create Slice if Workload doesn't have Topology Assignment.

Author: mbobrovskyi

slice/internal/controller/workload_controller.go

@@ -110,18 +110,20 @@ func (r *WorkloadReconciler) newSlice(wl *kueue.Workload) (*v1alpha1.Slice, erro
 
 	if wl.Status.Admission != nil && wl.Status.Admission.PodSetAssignments != nil {
 		for _, psa := range wl.Status.Admission.PodSetAssignments {
-			for _, domain := range psa.TopologyAssignment.Domains {
-				if slice.Spec.NodeSelector == nil {
-					slice.Spec.NodeSelector = make(map[string][]string)
-				}
-				if slice.Spec.NodeSelector[TPUReservationSubblockLabel] == nil {
-					slice.Spec.NodeSelector[TPUReservationSubblockLabel] = []string{}
-				}
-				// make sure there are no duplicates in the nodeSelector
-				for _, v := range domain.Values {
-					exists := slices.Contains(slice.Spec.NodeSelector[TPUReservationSubblockLabel], v)
-					if !exists {
-						slice.Spec.NodeSelector[TPUReservationSubblockLabel] = append(slice.Spec.NodeSelector[TPUReservationSubblockLabel], v)
+			if psa.TopologyAssignment != nil {
+				for _, domain := range psa.TopologyAssignment.Domains {
+					if slice.Spec.NodeSelector == nil {
+						slice.Spec.NodeSelector = make(map[string][]string)
+					}
+					if slice.Spec.NodeSelector[TPUReservationSubblockLabel] == nil {
+						slice.Spec.NodeSelector[TPUReservationSubblockLabel] = []string{}
+					}
+					// make sure there are no duplicates in the nodeSelector
+					for _, v := range domain.Values {
+						exists := slices.Contains(slice.Spec.NodeSelector[TPUReservationSubblockLabel], v)
+						if !exists {
+							slice.Spec.NodeSelector[TPUReservationSubblockLabel] = append(slice.Spec.NodeSelector[TPUReservationSubblockLabel], v)
+						}
 					}
 				}
 			}
@@ -147,6 +149,13 @@ func (r *WorkloadReconciler) createSliceIfNotExist(ctx context.Context, wl *kueu
 		return err
 	}
 
+	// We should wait for TopologyAssignments.
+	if len(slice.Spec.NodeSelector) == 0 {
+		log := ctrl.LoggerFrom(ctx)
+		log.V(2).Info("Workload does not have TopologyAssignments. Skipping Slice creation for now.")
+		return nil
+	}
+
 	return r.client.Create(ctx, slice)
 }
 

slice/internal/controller/workload_controller_test.go

@@ -90,20 +90,15 @@ func TestWorkloadReconciler(t *testing.T) {
 			slice:         baseSliceWrapper.DeepCopy(),
 			wantWorkloads: []kueue.Workload{*baseWorkloadWrapper.Clone().Active(false).Obj()},
 		},
-		"should add finalizer and create slice": {
+		"should add a finalizer but shouldn't create a Slice because there's no TopologyAssignment yet": {
 			request:  baseRequest,
-			workload: baseWorkloadWrapper.UID(types.UID(baseWorkloadName)).DeepCopy(),
+			workload: baseWorkloadWrapper.Clone().UID(types.UID(baseWorkloadName)).Obj(),
 			wantWorkloads: []kueue.Workload{
 				*baseWorkloadWrapper.Clone().
 					UID(types.UID(baseWorkloadName)).
 					Finalizers(CleanupSliceFinalizerName).
 					Obj(),
 			},
-			wantSlices: []v1alpha1.Slice{
-				*baseSliceWrapper.Clone().
-					ControllerReference(kueue.GroupVersion.WithKind("Workload"), baseWorkloadName, baseWorkloadName).
-					Obj(),
-			},
 		},
 		"parse TAS Assignment to populate NodeSelector in Slice": {
 			request: baseRequest,