Create Slice for each PodSet in Workload.

Author: mbobrovskyi

slice/api/v1alpha1/slice_types.go

@@ -26,10 +26,12 @@ import (
 type SliceSpec struct {
 	// AcceleratorType specifies the type of accelerator used in this slice.
 	// +kubebuilder:validation:Immutable
+	// +kubebuilder:validation:Required
 	AcceleratorType string `json:"acceleratorType"`
 
 	// Topology represents the network topology of the slice.
 	// +kubebuilder:validation:Immutable
+	// +kubebuilder:validation:Required
 	AcceleratorTopology string `json:"acceleratorTopology"`
 
 	// Required, set of nodes to use to form a slice.

slice/cmd/main.go

@@ -232,12 +232,18 @@ func main() {
 		}
 	}
 
+	ctx := ctrl.SetupSignalHandler()
+	if err := controller.SetupIndexer(ctx, mgr.GetFieldIndexer()); err != nil {
+		setupLog.Error(err, "unable to setup indexes")
+		os.Exit(1)
+	}
+
 	go setupControllers(mgr, certsReady)
 
 	setupProbeEndpoints(mgr, certsReady)
 
 	setupLog.Info("starting manager")
-	if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
+	if err := mgr.Start(ctx); err != nil {
 		setupLog.Error(err, "problem running manager")
 		os.Exit(1)
 	}

slice/hack/kind-cluster.yaml

@@ -24,10 +24,15 @@ nodes:
   - role: worker
     labels:
       instance-type: on-demand
+      cloud.google.com/gke-tpu-topology: 2x2x2
+      cloud.google.com/gke-tpu-accelerator: tpu-v4-podslice
+      cloud.google.com/gke-tpu-reservation-subblock: tpu-subblock-1
   - role: worker
     labels:
-      instance-type: spot
-
+      instance-type: on-demand
+      cloud.google.com/gke-tpu-topology: 2x2x2
+      cloud.google.com/gke-tpu-accelerator: tpu-v4-podslice
+      cloud.google.com/gke-nodepool: tpu-v4-pool
 kubeadmConfigPatches:
   - |
     kind: JoinConfiguration

slice/internal/controller/indexer.go

@@ -0,0 +1,44 @@
+/*
+Copyright The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controller
+
+import (
+	"context"
+	"fmt"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"tpu-slice-controller/api/v1alpha1"
+	"tpu-slice-controller/internal/util/slices"
+)
+
+const (
+	OwnerReferenceUID = "metadata.ownerReferences.uid"
+)
+
+func IndexOwnerReferenceUID(obj client.Object) []string {
+	return slices.Map(obj.GetOwnerReferences(), func(o *metav1.OwnerReference) string { return string(o.UID) })
+}
+
+// SetupIndexer sets the index with the given fields for core apis.
+func SetupIndexer(ctx context.Context, indexer client.FieldIndexer) error {
+	if err := indexer.IndexField(ctx, &v1alpha1.Slice{}, OwnerReferenceUID, IndexOwnerReferenceUID); err != nil {
+		return fmt.Errorf("setting index on ownerReferences.uid for Slice: %w", err)
+	}
+	return nil
+}