Remove Slice finalizer, once all Pods in the Workload have gracefully terminated.

Author: mbobrovskyi

slice/cmd/main.go

@@ -232,12 +232,18 @@ func main() {
 		}
 	}
 
+	ctx := ctrl.SetupSignalHandler()
+	if err := controller.SetupWorkloadIndexer(ctx, mgr.GetFieldIndexer()); err != nil {
+		setupLog.Error(err, "unable to setup indexes")
+		os.Exit(1)
+	}
+
 	go setupControllers(mgr, certsReady)
 
 	setupProbeEndpoints(mgr, certsReady)
 
 	setupLog.Info("starting manager")
-	if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
+	if err := mgr.Start(ctx); err != nil {
 		setupLog.Error(err, "problem running manager")
 		os.Exit(1)
 	}

slice/config/rbac/role.yaml

@@ -13,6 +13,14 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - ""
+  resources:
+  - pods
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -31,6 +39,14 @@ rules:
   - list
   - update
   - watch
+- apiGroups:
+  - jobset.x-k8s.io
+  resources:
+  - jobsets
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - kueue.x-k8s.io
   resources:

slice/internal/controller/indexer.go

@@ -0,0 +1,42 @@
+/*
+Copyright The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controller
+
+import (
+	"context"
+	"fmt"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	kueue "sigs.k8s.io/kueue/apis/kueue/v1beta1"
+
+	"tpu-slice-controller/internal/util/slices"
+)
+
+const (
+	OwnerReferenceUID = "metadata.ownerReferences.uid"
+)
+
+// SetupWorkloadIndexer configures the indexer to index specific fields for kueue.Workload resources.
+func SetupWorkloadIndexer(ctx context.Context, indexer client.FieldIndexer) error {
+	if err := indexer.IndexField(ctx, &kueue.Workload{}, OwnerReferenceUID, func(obj client.Object) []string {
+		return slices.Map(obj.GetOwnerReferences(), func(o *metav1.OwnerReference) string { return string(o.UID) })
+	}); err != nil {
+		return fmt.Errorf("setting index on ownerReferences.uid for Workload: %w", err)
+	}
+	return nil
+}