Skip to content

Commit db6f675

Browse files
cozdasdoug-walker
andauthored
Adsk Contrib - Adding the new cg and studio configs (issue #1999) (#2039)
* For issue #1999 adding the new cg and studio configs. - Added new configs cg-config-v2.2.0_aces-v1.3_ocio-v2.4.ocio and studio-config-v2.2.0_aces-v1.3_ocio-v2.4.ocio - Made default config cg-config-v2.2.0_aces-v1.3_ocio-v2.4 - Updated the tests accordingly. TODO: Some documents such as aces_cg.rst and aces_studio.srt need to be updated. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - minor white-space fixes. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * renaming P3 display scene referred aliases: -- lin_displayp3_scene --> lin_p3d65_scene -- srgb_displayp3_scene --> srgb_p3d65_scene Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * Make CIE-XYZ Scene-referred inactive Signed-off-by: Doug Walker <doug.walker@autodesk.com> --------- Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> Signed-off-by: Doug Walker <doug.walker@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com>
1 parent 79e7b7b commit db6f675

File tree

12 files changed

+2453
-40
lines changed

12 files changed

+2453
-40
lines changed

include/OpenColorIO/OpenColorIO.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ extern OCIOEXPORT void SetCurrentConfig(const ConstConfigRcPtr & config);
218218
* "ocio://studio-config-latest" will point to newer versions of those configs. Therefore, it is
219219
* recommended that application developers not save those strings and instead save the string that
220220
* refers to the current version of that config. That way, it's guaranteed that there will be no
221-
* change of behavior in the future. For example, as of OCIO 2.3, "ocio://default" should be saved
222-
* as "ocio://cg-config-v2.1.0_aces-v1.3_ocio-v2.3".
221+
* change of behavior in the future. For example, as of OCIO 2.4, "ocio://default" should be saved
222+
* as "ocio://cg-config-v2.2.0_aces-v1.3_ocio-v2.4".
223223
*
224224
* Note that there is no validation done on the path. That is left to the application since
225225
* typically the application will load the config before attempting to save its path
@@ -376,10 +376,12 @@ class OCIOEXPORT Config
376376
* ACES Studio config, contains a more complete collection of color spaces and displays:
377377
* "studio-config-v1.0.0_aces-v1.3_ocio-v2.1"
378378
* "studio-config-v2.1.0_aces-v1.3_ocio-v2.3"
379+
* "studio-config-v2.2.0_aces-v1.3_ocio-v2.4"
379380
*
380381
* ACES CG config, basic color spaces for computer graphics apps:
381382
* "cg-config-v1.0.0_aces-v1.3_ocio-v2.1"
382383
* "cg-config-v2.1.0_aces-v1.3_ocio-v2.3"
384+
* "cg-config-v2.2.0_aces-v1.3_ocio-v2.4"
383385
*
384386
* More information is available at:
385387
* %https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES

src/OpenColorIO/builtinconfigs/BuiltinConfigRegistry.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
static constexpr char OUT_OF_RANGE_EXCEPTION_TEXT[] = "Config index is out of range.";
2020

2121
// TODO: Remove once getDefaultBuiltinConfigName is removed.
22-
static constexpr char DEFAULT_BUILTIN_CONFIG[] = "cg-config-v2.1.0_aces-v1.3_ocio-v2.3";
22+
static constexpr char DEFAULT_BUILTIN_CONFIG[] = "cg-config-v2.2.0_aces-v1.3_ocio-v2.4";
2323

2424
// These are used for ResolveConfigPath function and we need to return a variable that still exists
2525
// once the function finishes since we are returning a const char *.
26-
static constexpr char DEFAULT_BUILTIN_CONFIG_URI[] = "ocio://cg-config-v2.1.0_aces-v1.3_ocio-v2.3";
27-
static constexpr char LATEST_CG_BUILTIN_CONFIG_URI[] = "ocio://cg-config-v2.1.0_aces-v1.3_ocio-v2.3";
28-
static constexpr char LATEST_STUDIO_BUILTIN_CONFIG_URI[] = "ocio://studio-config-v2.1.0_aces-v1.3_ocio-v2.3";
26+
static constexpr char DEFAULT_BUILTIN_CONFIG_URI[] = "ocio://cg-config-v2.2.0_aces-v1.3_ocio-v2.4";
27+
static constexpr char LATEST_CG_BUILTIN_CONFIG_URI[] = "ocio://cg-config-v2.2.0_aces-v1.3_ocio-v2.4";
28+
static constexpr char LATEST_STUDIO_BUILTIN_CONFIG_URI[] = "ocio://studio-config-v2.2.0_aces-v1.3_ocio-v2.4";
2929

3030
static constexpr char BUILTIN_DEFAULT_NAME[] = "default";
3131
static constexpr char BUILTIN_LATEST_CG_NAME[] = "cg-config-latest";

src/OpenColorIO/builtinconfigs/CG.cpp.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@
1010

1111
constexpr char CG_CONFIG_V100_ACES_V13_OCIO_V21[] = { @cg-config-v1.0.0_aces-v1.3_ocio-v2.1@ };
1212
constexpr char CG_CONFIG_V210_ACES_V13_OCIO_V23[] = { @cg-config-v2.1.0_aces-v1.3_ocio-v2.3@ };
13+
constexpr char CG_CONFIG_V220_ACES_V13_OCIO_V24[] = { @cg-config-v2.2.0_aces-v1.3_ocio-v2.4@ };

src/OpenColorIO/builtinconfigs/CGConfig.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,13 @@ void Register(BuiltinConfigRegistryImpl & registry) noexcept
3131
"cg-config-v2.1.0_aces-v1.3_ocio-v2.3",
3232
"Academy Color Encoding System - CG Config [COLORSPACES v2.0.0] [ACES v1.3] [OCIO v2.3]",
3333
CG_CONFIG_V210_ACES_V13_OCIO_V23,
34+
false
35+
);
36+
37+
registry.addBuiltin(
38+
"cg-config-v2.2.0_aces-v1.3_ocio-v2.4",
39+
"Academy Color Encoding System - CG Config [COLORSPACES v2.2.0] [ACES v1.3] [OCIO v2.4]",
40+
CG_CONFIG_V220_ACES_V13_OCIO_V24,
3441
true
3542
);
3643
}

src/OpenColorIO/builtinconfigs/Studio.cpp.in

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,6 @@ constexpr char STUDIO_CONFIG_V210_ACES_V13_OCIO_V23[] = {
1212
@studio-config-v2.1.0_aces-v1.3_ocio-v2.3@
1313
};
1414

15+
constexpr char STUDIO_CONFIG_V220_ACES_V13_OCIO_V24[] = {
16+
@studio-config-v2.2.0_aces-v1.3_ocio-v2.4@
17+
};

src/OpenColorIO/builtinconfigs/StudioConfig.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,13 @@ void Register(BuiltinConfigRegistryImpl & registry) noexcept
3131
"studio-config-v2.1.0_aces-v1.3_ocio-v2.3",
3232
"Academy Color Encoding System - Studio Config [COLORSPACES v2.0.0] [ACES v1.3] [OCIO v2.3]",
3333
STUDIO_CONFIG_V210_ACES_V13_OCIO_V23,
34+
false
35+
);
36+
37+
registry.addBuiltin(
38+
"studio-config-v2.2.0_aces-v1.3_ocio-v2.4",
39+
"Academy Color Encoding System - Studio Config [COLORSPACES v2.2.0] [ACES v1.3] [OCIO v2.4]",
40+
STUDIO_CONFIG_V220_ACES_V13_OCIO_V24,
3441
true
3542
);
3643
}

0 commit comments

Comments
 (0)