From a61191d8abcc290f6ef4ee0256709620b933f17d Mon Sep 17 00:00:00 2001 From: Eve Le Date: Mon, 30 Mar 2020 01:40:24 -0700 Subject: [PATCH 1/2] implemented newman_conway --- lib/newman_conway.rb | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..8e22eec 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,15 @@ - - -# Time complexity: ? -# Space Complexity: ? +# Time complexity: O(n) +# Space Complexity: O(n) def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" + raise ArgumentError if num < 1 + output = Array.new() + num.times do |i| + if i < 2 + output << 1 + else + previous = output[i - 1] + output << output[previous - 1] + output[i - previous] + end + end + return output.join(" ") end \ No newline at end of file From ba207e2e067f596337faa284108c1fb4bece6b4d Mon Sep 17 00:00:00 2001 From: Eve Le Date: Mon, 30 Mar 2020 01:58:01 -0700 Subject: [PATCH 2/2] Implemented max_sub_array --- lib/max_subarray.rb | 25 +++++++++++++++++++------ test/max_sub_array_test.rb | 2 +- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..ab36051 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,8 +1,21 @@ - -# Time Complexity: ? -# Space Complexity: ? +# Time Complexity: O(n) +# Space Complexity: O(1) def max_sub_array(nums) - return 0 if nums == nil - - raise NotImplementedError, "Method not implemented yet!" + result = nil + if nums == nil + result = 0 + elsif nums.length > 0 + max_so_far = 0 + max_ending_here = 0 + largest_element = nums[0] + nums.each do |element| + max_ending_here = max_ending_here + element + + max_ending_here = 0 if max_ending_here < 0 + max_so_far = max_ending_here if max_so_far < max_ending_here + largest_element = element if element > largest_element + end + result = (largest_element < 0) ? largest_element : max_so_far + end + return result end diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..e27e1ca 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4]