diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..11095ae 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,8 +1,18 @@ +# frozen_string_literal: true + +# Time Complexity: O(n) +# Space Complexity: O(1) -# Time Complexity: ? -# Space Complexity: ? def max_sub_array(nums) - return 0 if nums == nil - - raise NotImplementedError, "Method not implemented yet!" + return nil if nums.nil? || nums.empty? + + max_so_far = nums[0] + curr_max = nums[0] + + nums[1..].each do |curr_num| + curr_max = [curr_num, curr_num + curr_max].max + max_so_far = [curr_max, max_so_far].max + end + + max_so_far end diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..8959d75 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,20 @@ +# frozen_string_literal: true - -# Time complexity: ? -# Space Complexity: ? +# Time complexity: O(n) +# Space Complexity: O(n) def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" -end \ No newline at end of file + raise ArgumentError if num <= 0 + return '1' if num == 1 + return '1 1' if num == 2 + + new_array = [0, 1, 1] + i = 3 + # P(P(n - 1)) + P(n - P(n - 1)) + while i <= num + new_array[i] = new_array[new_array[i - 1]] + new_array[i - new_array[i - 1]] + + i += 1 + end + + new_array[1..].join(' ') +end diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..e27e1ca 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4]