diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..e175779 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,8 +1,24 @@ -# Time Complexity: ? -# Space Complexity: ? +# Time Complexity: O(n) +# Space Complexity: O(1) def max_sub_array(nums) - return 0 if nums == nil - - raise NotImplementedError, "Method not implemented yet!" + return nil if nums.empty? + return nums[0] if nums.length == 1 + + max_so_far = nums[0] + max_ending_here = nums[0] + + for num in nums[1..-1] do + if((max_ending_here + num) > num) + max_ending_here = max_ending_here + num + else + max_ending_here = num + end + + if(max_so_far < max_ending_here) + max_so_far = max_ending_here + end + end + + return max_so_far end diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..98ca271 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,22 @@ -# Time complexity: ? -# Space Complexity: ? +# Time complexity: O(n) +# Space Complexity: O(1) def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" + raise ArgumentError if num <= 0 + return "1" if num == 1 + return "1 1" if num == 2 + + array = [0, 1, 1] + + i = 3 + + until i == num + 1 + current = array[array[i - 1]] + array[i - array[i - 1]] + + array << current + + i += 1 + end + return array[1..-1].join(' ') end \ No newline at end of file diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..ac403f9 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4] @@ -46,14 +46,14 @@ end it "will return nil for an empty array" do - # Arrange - input = [] + # Arrange + input = [] - # Act - answer = max_sub_array(input) + # Act + answer = max_sub_array(input) - # Assert - expect(answer).must_be_nil + # Assert + expect(answer).must_be_nil end it "will work for [50, -50, 50]" do