Build failure with GNU gnat 13.3.0 and gnatcoll-cor 25.0.0: gpr2-build-signature.adb:78:24: error: no selector "Finalize" for private type "JSON_Value"

[sternenseemann]

I'm running into the following compilation failure of gpr2 25.0.0 (using the tarball with pregenerated kb db) with GNU GNAT 13.3.0. gnatcoll-json.ads is supplied from gnatcoll-core 25.0.0.

Running phase: unpackPhase
unpacking source archive /nix/store/rlr1p5yp3c3py2jq6w9aim9p3h0nhq72-gpr2-with-gprconfig_kb-25.0.tgz
source root is gpr
setting SOURCE_DATE_EPOCH to timestamp 1730300154 of file gpr/gpr2.gpr
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
Running phase: buildPhase
build flags: SHELL=/nix/store/717iy55ncqs0wmhdkwc5fg2vci5wbmq8-bash-5.2p32/bin/bash prefix=\$\(out\) PROCESSORS=\$\(NIX_BUILD_CORES\) ENABLE_SHARED=yes GPR2_BUILD=release
gprbuild -p -j64 -XGPR2_BUILD=release -XBUILD_ROOT="/build/gpr/.build"  -XPROFILER=no  -XLIBRARY_TYPE=static -XXMLADA_BUILD=static \
        ./gpr2.gpr
Setup
   [mkdir]        object directory for project GPR2
   [mkdir]        library directory for project GPR2
Compile
   [C]            gpr_parser-gdb.c
   [Ada]          gpr_parser_support-internal-descriptor.ads
   [Ada]          gpr_parser-rewriting.adb
   [Ada]          gpr_parser-generic_impl.adb
   [Ada]          gpr_parser_adasat-formulas.adb
   [Ada]          gpr_parser-rewriting_implementation.adb
   [Ada]          gpr_parser-implementation-c.adb
   [Ada]          gpr_parser_adasat-vectors.adb
   [Ada]          gpr_parser-debug.adb
   [Ada]          gpr_parser_support.ads
   [Ada]          gpr_parser_adasat-decisions.adb
   [Ada]          gpr_parser_support-internal-conversions.ads
   [Ada]          gpr_parser_support-file_readers.adb
   [Ada]          gpr_parser_support-internal-introspection.adb
   [Ada]          gpr_parser-lexer.adb
   [Ada]          gpr_parser_support-iterators.adb
   [Ada]          gpr_parser_support-vectors.adb
   [Ada]          gpr_parser_support-adalog-debug.adb
   [Ada]          gpr_parser_support-text.adb
   [Ada]          gpr_parser_support-bump_ptr.ads
   [Ada]          gpr_parser_support-slocs.adb
   [Ada]          gpr_parser_support-relative_get.adb
   [Ada]          gpr_parser_support-errors.ads
   [Ada]          gpr_parser_support-generic_api-introspection.adb
   [Ada]          gpr_parser_support-packrat.adb
   [Ada]          gpr_parser.ads
   [Ada]          gpr_parser-c.adb
   [Ada]          gpr_parser_support-symbols.adb
   [Ada]          gpr_parser_support-adalog-generic_main_support.adb
   [Ada]          gpr_parser_support-types.ads
   [Ada]          gpr_parser-common.adb
   [Ada]          gpr_parser_support-generic_api.adb
   [Ada]          gpr_parser_support-bump_ptr_vectors.adb
   [Ada]          gpr_parser_support-lexical_envs.ads
   [Ada]          gpr_parser_adasat-internals.ads
   [Ada]          gpr_parser_adasat-builders.adb
   [Ada]          gpr_parser_support-adalog-main_support.ads
   [Ada]          gpr_parser_adasat-helpers.adb
   [Ada]          gpr_parser_support-images.adb
   [Ada]          gpr_parser_support-token_data_handlers.adb
   [Ada]          gpr_parser-public_converters.adb
   [Ada]          gpr_parser-unparsing_implementation.adb
   [Ada]          gpr_parser-private_converters.adb
   [Ada]          gpr_parser_support-adalog.ads
   [Ada]          gpr_parser_support-tree_traversal_iterator.adb
   [Ada]          gpr_parser_support-symbols-precomputed.adb
   [Ada]          gpr_parser_support-adalog-solver_interface.adb
   [Ada]          gpr_parser-iterators.adb
   [Ada]          gpr_parser_support-boxes.adb
   [Ada]          gpr_parser-lexer_state_machine.adb
   [Ada]          gpr_parser_support-names-maps.adb
   [Ada]          gpr_parser_support-internal.ads
   [Ada]          gpr_parser_adasat-dpll.adb
   [Ada]          gpr_parser_support-lexical_envs_impl.adb
   [Ada]          gpr_parser-parsers.adb
   [Ada]          gpr_parser_support-cheap_sets.adb
   [Ada]          gpr_parser-generic_api.adb
   [Ada]          gpr_parser_support-diagnostics-output.adb
   [Ada]          gpr_parser-generic_introspection.adb
   [Ada]          gpr_parser_support-adalog-logic_var.adb
   [Ada]          gpr_parser_adasat-theory.ads
   [Ada]          gpr_parser_support-names.adb
   [Ada]          gpr_parser-unparsing.adb
   [Ada]          gpr_parser_adasat.adb
   [Ada]          gpr_parser-generic_api-introspection.ads
   [Ada]          gpr_parser_support-diagnostics.adb
   [Ada]          gpr_parser-analysis.adb
   [Ada]          gpr_parser-lexer_implementation.adb
   [Ada]          gpr_parser_support-hashes.adb
   [Ada]          gpr_parser-implementation.adb
   [Ada]          gpr_parser_support-array_utils.adb
   [Ada]          gpr_parser_support-generic_bump_ptr.adb
   [Ada]          gpr_parser_support-adalog-solver.adb
   [Ada]          gpr_parser_support-generic_api-analysis.adb
   [Ada]          gpr_parser_support-internal-analysis.adb
   [Ada]          gpr2-kb-embedded.adb
   [Ada]          gpr2-tree_internal-view_builder.adb
   [Ada]          gpr2-project_parser-create.adb
   [Ada]          gpr2-tree_internal.adb
   [Ada]          gpr2-view_base_internal.ads
   [Ada]          gpr2-build-view_tables.adb
   [Ada]          gpr2-project_parser-set.ads
   [Ada]          gpr2-pack_internal.ads
   [Ada]          gpr2-view_internal.adb
   [Ada]          gpr2-project_parser.adb
   [Ada]          gpr2-project_parser-registry.adb
   [Ada]          gpr2-build-tree_db.adb
   [Ada]          gpr2-build-unit_info-list.adb
   [Ada]          gpr2-build-source.ads
   [Ada]          gpr2-build-actions-ada_bind.adb
   [Ada]          gpr2-build-artifacts-files.adb
   [Ada]          gpr2-build-unit_info.adb
   [Ada]          gpr2-build-artifacts-library.ads
   [Ada]          gpr2-build-signature.adb
   [Ada]          gpr2-build-source_base-ada_parser.adb
   [Ada]          gpr2-build-source_base.adb
   [Ada]          gpr2-build-view_db.adb
   [Ada]          gpr2-build-actions-compile.adb
   [Ada]          gpr2-build-compilation_unit.adb
   [Ada]          gpr2-build-actions.adb
   [Ada]          gpr2-build-actions-compile-ada.adb
   [Ada]          gpr2-build-ali_parser.adb
   [Ada]          gpr2-build-actions-post_bind.adb
   [Ada]          gpr2-build-compilation_unit-maps.ads
   [Ada]          gpr2-build.ads
   [Ada]          gpr2-build-process_manager.adb
   [Ada]          gpr2-build-source-sets.adb
   [Ada]          gpr2-build-actions-link.adb
   [Ada]          gpr2-build-artifacts-file_part.adb
   [Ada]          gpr2-build-process_manager-json.adb
gpr2-build-signature.adb:78:24: error: no selector "Finalize" for private type "JSON_Value" defined at gnatcoll-json.ads:167

   compilation of gpr2-build-signature.adb failed

gprbuild: *** compilation phase failed
make: *** [Makefile:177: build-lib-static] Error 4
builder for '/nix/store/kh53jph843rgz7vv1fwzxk60ngh6niwq-gpr2-25.0.0.drv' failed with exit code 2

[sternenseemann]

The issue isn't present with GNU GNAT 14. Unable to test GNAT 12 due to AdaCore/gnatcoll-core#88.

[Fabien-Chouteau]

Hi @sternenseemann , the more I look at this the more it looks like there's a bug in GNAT FSF 14 and this should not compile at all.

The Finalize procedure for the JSON_Value type is in the private part of GNATCOLL.JSON and the type JSON_Value derives from Ada.Finalization.Controlled is also in the private part.

I don't think we will be able to provide a correction. libGPR2 25.0.0 is not compatible with GNAT FSF 13.

[sternenseemann]

Okay, I'll just keep it marked as broken. It's not important since the GNAT 13 + gpr2 combination has no reverse dependencies in nixpkgs anyways.