Make functions idempotent

Author: anttiai

src/settings.js

@@ -63,7 +63,9 @@ var settings = function() {
 
   this.addCustomFieldFilter = function(fieldName, value) {
     var filter = encodeURIComponent(fieldName + '=' + value);
-    this.settings.customFieldFilters.push(filter);
+    if (this.settings.customFieldFilters.indexOf(filter) === -1) {
+      this.settings.customFieldFilters.push(filter);
+    }
   }
 
   this.removeCustomFieldFilter = function(fieldName, value) {
@@ -114,7 +116,9 @@ var settings = function() {
   }
 
   this.addFacetField = function(field) {
-    this.settings.facetFields.push(field);
+    if (this.settings.facetFields.indexOf(field) === -1) {
+      this.settings.facetFields.push(field);
+    }
   }
 
   this.setNumberOfFacets = function(numFacets) {

test/settings.js

@@ -57,6 +57,13 @@ describe('settings', function() {
       assert.equal(JSON.stringify(s.getSettings().customFieldFilters), expect);
     });
 
+    it('adding custom fields filter should be idempotent', function() {
+      s.addCustomFieldFilter('city', 'helsinki');
+      s.addCustomFieldFilter('city', 'helsinki');
+      var expect = '["city%3Dhelsinki"]';
+      assert.equal(JSON.stringify(s.getSettings().customFieldFilters), expect);
+    });
+
 
   });
 });