[ACS-10165] remove flag

Author: g-jaskowski

projects/aca-content/src/lib/components/library-list/library-list.component.spec.ts

@@ -24,7 +24,7 @@
 
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { Router } from '@angular/router';
-import { AppConfigService, UnitTestingUtils, UserPreferencesService } from '@alfresco/adf-core';
+import { UnitTestingUtils, UserPreferencesService } from '@alfresco/adf-core';
 import { DocumentListComponent, SitesService } from '@alfresco/adf-content-services';
 import { LibraryListComponent } from './library-list.component';
 import { AppTestingModule } from '../../testing/app-testing.module';
@@ -46,8 +46,6 @@ describe('LibraryListComponent', () => {
   let appHookService: AppHookService;
   let getSitesSpy: jasmine.Spy<(options?: any) => Observable<SitePaging>>;
   let unitTestingUtils: UnitTestingUtils;
-  let appConfig: AppConfigService;
-  let getLegalHoldsEnabledSpy: jasmine.Spy<(key: string, defaultValue?: string | boolean) => string | boolean>;
 
   const paging: SitePaging = {
     list: {
@@ -59,8 +57,6 @@ describe('LibraryListComponent', () => {
     }
   };
 
-  const whereOpt = `(preset='site-dashboard')`;
-
   beforeEach(() => {
     TestBed.configureTestingModule({
       imports: [AppTestingModule, LibraryListComponent, MatSnackBarModule],
@@ -74,13 +70,10 @@ describe('LibraryListComponent', () => {
     sitesService = TestBed.inject(SitesService);
     userPreference = TestBed.inject(UserPreferencesService);
     appHookService = TestBed.inject(AppHookService);
-    appConfig = TestBed.inject(AppConfigService);
     router = TestBed.inject(Router);
 
     getSitesSpy = spyOn(sitesService, 'getSites');
     getSitesSpy.and.returnValue(of(paging));
-    getLegalHoldsEnabledSpy = spyOn(appConfig, 'get');
-    getLegalHoldsEnabledSpy.and.returnValue(false);
     fixture.detectChanges();
   });
 
@@ -93,7 +86,7 @@ describe('LibraryListComponent', () => {
     it('should get data with user preference pagination size', () => {
       userPreference.paginationSize = 1;
       component.ngOnInit();
-      expect(sitesService.getSites).toHaveBeenCalledWith({ maxItems: 1, where: whereOpt });
+      expect(sitesService.getSites).toHaveBeenCalledWith({ maxItems: 1 });
     });
 
     it('should set data on error', () => {
@@ -121,19 +114,6 @@ describe('LibraryListComponent', () => {
     });
   });
 
-  describe('Legal Holds flag', () => {
-    it('should call getSites with where option when legal holds disabled', () => {
-      component.ngOnInit();
-      expect(sitesService.getSites).toHaveBeenCalledWith(jasmine.objectContaining({ where: whereOpt }));
-    });
-
-    it('should not call getSites with where option when legal holds enabled', () => {
-      getLegalHoldsEnabledSpy.and.returnValue(true);
-      component.ngOnInit();
-      expect(sitesService.getSites).toHaveBeenCalledWith(jasmine.objectContaining({ where: undefined }));
-    });
-  });
-
   describe('Node navigation', () => {
     it('should not navigate when node is null or missing guid', () => {
       spyOn(router, 'navigate').and.stub();
@@ -198,12 +178,12 @@ describe('LibraryListComponent', () => {
 
     it('should get list with pagination data onChange event', () => {
       component.getList(pagination);
-      expect(sitesService.getSites).toHaveBeenCalledWith({ ...pagination, where: whereOpt });
+      expect(sitesService.getSites).toHaveBeenCalledWith(pagination);
     });
 
     it('should get list with pagination data onChangePageSize event', () => {
       component.onChangePageSize(pagination);
-      expect(sitesService.getSites).toHaveBeenCalledWith({ ...pagination, where: whereOpt });
+      expect(sitesService.getSites).toHaveBeenCalledWith(pagination);
     });
 
     it('should set preference page size onChangePageSize event', () => {

projects/aca-content/src/lib/components/library-list/library-list.component.ts

@@ -34,7 +34,6 @@ import {
 } from '@alfresco/aca-shared';
 import { NavigateLibraryAction } from '@alfresco/aca-shared/store';
 import {
-  AppConfigService,
   CustomEmptyContentTemplateDirective,
   DataColumnComponent,
   DataColumnListComponent,
@@ -80,24 +79,18 @@ export class LibraryListComponent extends PageComponent implements OnInit {
   list: SitePaging;
   columns: DocumentListPresetRef[] = [];
 
-  private legalHoldsEnabled = false;
-
   constructor(
     private readonly appHookService: AppHookService,
     private readonly preferences: UserPreferencesService,
     private readonly changeDetectorRef: ChangeDetectorRef,
-    private readonly sitesService: SitesService,
-    private readonly appConfig: AppConfigService
+    private readonly sitesService: SitesService
   ) {
     super();
   }
 
   ngOnInit() {
     super.ngOnInit();
 
-    const legalHoldFlag = this.appConfig.get<boolean | string>('plugins.legalHoldEnabled', false);
-    this.legalHoldsEnabled = legalHoldFlag === true || legalHoldFlag === 'true';
-
     this.getList({ maxItems: this.preferences.paginationSize });
 
     merge(this.appHookService.libraryDeleted, this.appHookService.libraryUpdated, this.appHookService.libraryJoined, this.appHookService.libraryLeft)
@@ -123,11 +116,7 @@ export class LibraryListComponent extends PageComponent implements OnInit {
 
   getList(pagination: Pagination) {
     this.isLoading = true;
-    let where: string | undefined;
-    if (!this.legalHoldsEnabled) {
-      where = `(preset='site-dashboard')`;
-    }
-    this.sitesService.getSites({ ...pagination, where: where }).subscribe({
+    this.sitesService.getSites(pagination).subscribe({
       next: (libraryList: SitePaging) => {
         this.list = libraryList;
         this.pagination = libraryList.list.pagination;