AAE-37746 rename CrossAppAuthSyncService to CrossAppTokenManager and clear auth tokens when crossAppAuth=true to ensure correct user authentication

Author: alep85

lib/core/src/lib/auth/oidc/auth.module.ts

@@ -28,8 +28,7 @@ import { StorageService } from '../../common/services/storage.service';
 import { provideRouter } from '@angular/router';
 import { AUTH_ROUTES } from './auth.routes';
 import { Authentication, AuthenticationInterceptor } from '@alfresco/adf-core/auth';
-import { CrossAppAuthSyncService } from '../services/cross-app-auth-sync.service';
-import { CrossAppAuthIntegrationService } from '../services/cross-app-auth-integration.service';
+import { provideCrossAppAuth } from '../services/cross-app-auth.providers';
 
 export const JWT_STORAGE_SERVICE = new InjectionToken<OAuthStorage>('JWT_STORAGE_SERVICE', {
     providedIn: 'root',
@@ -88,15 +87,7 @@ export class AuthModule {
         const providers: (Provider | EnvironmentProviders)[] = [{ provide: AUTH_MODULE_CONFIG, useValue: config }];
 
         if (config.enableCrossAppSync) {
-            providers.push(
-                CrossAppAuthSyncService,
-                CrossAppAuthIntegrationService,
-                provideAppInitializer(() => {
-                    const crossAppIntegration = inject(CrossAppAuthIntegrationService);
-                    crossAppIntegration.initialize();
-                    return crossAppIntegration.attemptSilentLoginFromLinkedApps();
-                })
-            );
+            providers.push(...provideCrossAppAuth());
         }
         return {
             ngModule: AuthModule,

lib/core/src/lib/auth/public-api.ts

@@ -30,8 +30,10 @@ export * from './services/identity-group.service';
 export * from './services/jwt-helper.service';
 export * from './services/oauth2.service';
 export * from './services/user-access.service';
-export * from './services/cross-app-auth-sync.service';
+export * from './services/cross-app-token-manager.service';
 export * from './services/cross-app-auth-integration.service';
+export * from './services/cross-app-auth-initializer.service';
+export * from './services/cross-app-auth.providers';
 
 export * from './basic-auth/basic-alfresco-auth.service';
 export * from './basic-auth/process-auth';

lib/core/src/lib/auth/services/cross-app-auth-initializer.service.spec.ts

@@ -0,0 +1,109 @@
+/*!
+ * @license
+ * Copyright © 2005-2025 Hyland Software, Inc. and its affiliates. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { TestBed } from '@angular/core/testing';
+import { CrossAppAuthInitializerService } from './cross-app-auth-initializer.service';
+import { CrossAppAuthIntegrationService } from './cross-app-auth-integration.service';
+
+describe('CrossAppAuthInitializerService', () => {
+    let service: CrossAppAuthInitializerService;
+    let mockCrossAppIntegration: jasmine.SpyObj<CrossAppAuthIntegrationService>;
+
+    beforeEach(() => {
+        const spy = jasmine.createSpyObj('CrossAppAuthIntegrationService', ['initialize', 'processCrossAppAuthRequest']);
+
+        TestBed.configureTestingModule({
+            providers: [CrossAppAuthInitializerService, { provide: CrossAppAuthIntegrationService, useValue: spy }]
+        });
+
+        service = TestBed.inject(CrossAppAuthInitializerService);
+        mockCrossAppIntegration = TestBed.inject(CrossAppAuthIntegrationService) as jasmine.SpyObj<CrossAppAuthIntegrationService>;
+    });
+
+    it('should be created', () => {
+        expect(service).toBeTruthy();
+    });
+
+    describe('initializeWithSilentLogin', () => {
+        it('should successfully initialize and attempt silent login', async () => {
+            mockCrossAppIntegration.initialize.and.returnValue(Promise.resolve());
+            mockCrossAppIntegration.processCrossAppAuthRequest.and.returnValue(Promise.resolve(true));
+
+            const result = await service.initializeCrossAppLogin();
+
+            expect(result).toBe(true);
+            expect(mockCrossAppIntegration.initialize).toHaveBeenCalled();
+            expect(mockCrossAppIntegration.processCrossAppAuthRequest).toHaveBeenCalled();
+        });
+
+        it('should return false if silent login is not attempted', async () => {
+            mockCrossAppIntegration.initialize.and.returnValue(Promise.resolve());
+            mockCrossAppIntegration.processCrossAppAuthRequest.and.returnValue(Promise.resolve(false));
+
+            const result = await service.initializeCrossAppLogin();
+
+            expect(result).toBe(false);
+            expect(mockCrossAppIntegration.initialize).toHaveBeenCalled();
+            expect(mockCrossAppIntegration.processCrossAppAuthRequest).toHaveBeenCalled();
+        });
+
+        it('should handle initialization timeout', async () => {
+            mockCrossAppIntegration.initialize.and.returnValue(
+                new Promise(() => {}) // Never resolves - simulates hanging
+            );
+            spyOn(console, 'warn');
+
+            const result = await service.initializeCrossAppLogin();
+
+            expect(result).toBe(false);
+            expect(console.warn).toHaveBeenCalledWith('Cross-app auth initialization failed:', 'Cross-app auth initialization timed out');
+        });
+
+        it('should handle initialization errors', async () => {
+            const error = new Error('Network error');
+            mockCrossAppIntegration.initialize.and.returnValue(Promise.reject(error));
+            spyOn(console, 'warn');
+
+            const result = await service.initializeCrossAppLogin();
+
+            expect(result).toBe(false);
+            expect(console.warn).toHaveBeenCalledWith('Cross-app auth initialization failed:', 'Network error');
+        });
+
+        it('should handle various error types', async () => {
+            const customError = new Error('Custom initialization error');
+            mockCrossAppIntegration.initialize.and.returnValue(Promise.reject(customError));
+            spyOn(console, 'warn');
+
+            const result = await service.initializeCrossAppLogin();
+
+            expect(result).toBe(false);
+            expect(console.warn).toHaveBeenCalledWith('Cross-app auth initialization failed:', 'Custom initialization error');
+        });
+
+        it('should handle silent login errors', async () => {
+            mockCrossAppIntegration.initialize.and.returnValue(Promise.resolve());
+            mockCrossAppIntegration.processCrossAppAuthRequest.and.returnValue(Promise.reject(new Error('Silent login failed')));
+            spyOn(console, 'warn');
+
+            const result = await service.initializeCrossAppLogin();
+
+            expect(result).toBe(false);
+            expect(console.warn).toHaveBeenCalledWith('Cross-app auth initialization failed:', 'Silent login failed');
+        });
+    });
+});

lib/core/src/lib/auth/services/cross-app-auth-initializer.service.ts

@@ -0,0 +1,66 @@
+/*!
+ * @license
+ * Copyright © 2005-2025 Hyland Software, Inc. and its affiliates. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Injectable, inject } from '@angular/core';
+import { CrossAppAuthIntegrationService } from './cross-app-auth-integration.service';
+
+/**
+ * Service responsible for initializing cross-application authentication during app startup.
+ * Handles timeout management and error handling for the initialization process.
+ */
+@Injectable()
+export class CrossAppAuthInitializerService {
+    private readonly crossAppIntegration = inject(CrossAppAuthIntegrationService);
+    private readonly initializationTimeoutMs = 5000;
+
+    /**
+     * Initializes the cross-application login process.
+     *
+     * This method attempts to initialize the cross-app authentication flow with a timeout,
+     * and then performs a cross-app authentication request. If any error occurs during
+     * initialization or authentication, it handles the error and returns `false`.
+     *
+     * @returns A promise that resolves to `true` if cross-app login is successful, or `false` if an error occurs.
+     */
+    async initializeCrossAppLogin(): Promise<boolean> {
+        try {
+            await this.initializeWithTimeout();
+            return this.crossAppIntegration.processCrossAppAuthRequest();
+        } catch (error) {
+            this.handleInitializationError(error);
+            return false;
+        }
+    }
+
+    private async initializeWithTimeout(): Promise<void> {
+        const initPromise = this.crossAppIntegration.initialize();
+        const timeoutPromise = this.createTimeoutPromise();
+
+        await Promise.race([initPromise, timeoutPromise]);
+    }
+
+    private createTimeoutPromise(): Promise<never> {
+        return new Promise<never>((_, reject) =>
+            setTimeout(() => reject(new Error('Cross-app auth initialization timed out')), this.initializationTimeoutMs)
+        );
+    }
+
+    private handleInitializationError(error: unknown): void {
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        console.warn('Cross-app auth initialization failed:', errorMessage);
+    }
+}