Skip to content

[ACS-10324]: checkbox enter key handling #11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmnvch merged 3 commits into from
Oct 27, 2025
Merged

[ACS-10324]: checkbox enter key handling #11271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56d55f0
[ACS-10324]: prevents bubbling of enter key
rmnvch Oct 17, 2025
c96b87e
[ACS-10324]: adds test
rmnvch Oct 17, 2025
44eafce
[ACS-10324]: migrates to testUtils instead of direct query use
rmnvch Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/core/src/lib/datatable/components/datatable/datatable.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,9 @@
[aria-label]="'ADF-DATATABLE.ACCESSIBILITY.SELECT_FILE' | translate"
data-adf-datatable-row-checkbox
(change)="onCheckboxChange(row, $event)"
class="adf-checkbox-sr-only">
(keydown.enter)="$event.stopPropagation()"
class="adf-checkbox-sr-only"
>
{{ 'ADF-DATATABLE.ACCESSIBILITY.SELECT_FILE' | translate }}
</mat-checkbox>
</label>
Expand Down
27 changes: 27 additions & 0 deletions lib/core/src/lib/datatable/components/datatable/datatable.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,33 @@ describe('DataTable', () => {
expect(rows[1].isSelected).toBeTrue();
});

it('should call stopPropagation on checkbox keydown enter event', () => {
const petRows = [{ pet: 'dog' }, { pet: 'cat' }];
dataTable.multiselect = true;
dataTable.data = new ObjectDataTableAdapter(petRows, [new ObjectDataColumn({ key: 'pet' })]);
dataTable.ngOnChanges({ rows: new SimpleChange(null, petRows, false) });
fixture.detectChanges();

const checkboxElement = testingUtils.getByCSS('[data-adf-datatable-row-checkbox]').nativeElement as HTMLElement;

const enterEvent = new KeyboardEvent('keydown', {
key: 'Enter',
code: 'Enter',
bubbles: true,
cancelable: true
});

const stopPropagationSpy = jasmine.createSpy('stopPropagationSpy');

Object.assign(enterEvent, {
stopPropagation: stopPropagationSpy
});

checkboxElement.dispatchEvent(enterEvent);

expect(stopPropagationSpy).toHaveBeenCalled();
});

it('should be able to display column of type boolean', () => {
dataTable.data = new ObjectDataTableAdapter(mockCarsData, mockCarsSchemaDefinition);

Expand Down
Loading