Skip to content

Commit 81020d6

Browse files
committed
fixing some clang warnings
1 parent 6f9a434 commit 81020d6

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

common/droidboot_platform_common.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ void droidboot_fb_flush(lv_disp_drv_t * disp_drv, const lv_area_t * area, lv_col
55
droidboot_internal_fb_flush(disp_drv, area, color_p);
66
}
77

8-
int droidboot_get_display_height()
8+
lv_coord_t droidboot_get_display_height()
99
{
1010
return droidboot_internal_get_display_height();
1111
}
1212

13-
int droidboot_get_display_width()
13+
lv_coord_t droidboot_get_display_width()
1414
{
1515
return droidboot_internal_get_display_width();
1616
}
@@ -98,12 +98,12 @@ void droidboot_delay(unsigned int time)
9898
droidboot_internal_delay(time);
9999
}
100100

101-
void droidboot_platform_boot_linux_from_ram(void *kernel_raw, off_t kernel_raw_size, void *ramdisk_raw, off_t ramdisk_size, void *dtb_raw, off_t dtb_raw_size, void *dtbo_raw, off_t dtbo_raw_size, char *options)
101+
void droidboot_platform_boot_linux_from_ram(void *kernel_raw, uint64_t kernel_raw_size, void *ramdisk_raw, uint64_t ramdisk_size, void *dtb_raw, uint64_t dtb_raw_size, void *dtbo_raw, uint64_t dtbo_raw_size, char *options)
102102
{
103103
droidboot_internal_boot_linux_from_ram(kernel_raw, kernel_raw_size, ramdisk_raw, ramdisk_size, dtb_raw, dtb_raw_size, dtbo_raw, dtbo_raw_size, options);
104104
}
105105

106-
void droidboot_pre_ramdisk_load(void *kernel_raw, off_t kernel_raw_size)
106+
void droidboot_pre_ramdisk_load(void *kernel_raw, uint64_t kernel_raw_size)
107107
{
108108
droidboot_internal_pre_ramdisk_load(kernel_raw, kernel_raw_size);
109109
}

common/droidboot_platform_common.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
#endif
4646

4747
void droidboot_fb_flush(lv_disp_drv_t * disp_drv, const lv_area_t * area, lv_color_t * color_p);
48-
int droidboot_get_display_height();
49-
int droidboot_get_display_width();
48+
lv_coord_t droidboot_get_display_height();
49+
lv_coord_t droidboot_get_display_width();
5050
void droidboot_key_read(lv_indev_drv_t * drv, lv_indev_data_t*data);
5151

5252
int droidboot_platform_settings_dev_open(struct ext4_blockdev *bdev);
@@ -69,8 +69,8 @@ void droidboot_platform_system_log(const char *buf);
6969

7070
void droidboot_delay(unsigned int time);
7171

72-
void droidboot_platform_boot_linux_from_ram(void *kernel_raw, off_t kernel_raw_size, void *ramdisk_raw, off_t ramdisk_size, void *dtb_raw, off_t dtb_raw_size, void *dtbo_raw, off_t dtbo_raw_size, char *options);
73-
void droidboot_pre_ramdisk_load(void *kernel_raw, off_t kernel_raw_size);
72+
void droidboot_platform_boot_linux_from_ram(void *kernel_raw, uint64_t kernel_raw_size, void *ramdisk_raw, uint64_t ramdisk_size, void *dtb_raw, uint64_t dtb_raw_size, void *dtbo_raw, uint64_t dtbo_raw_size, char *options);
73+
void droidboot_pre_ramdisk_load(void *kernel_raw, uint64_t kernel_raw_size);
7474
void *droidboot_get_kernel_load_addr(void);
7575
void *droidboot_get_ramdisk_load_addr(void);
7676
bool droidboot_append_ramdisk_to_kernel(void);

simulator/simulator.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ static bool s_simulator_running;
1313
uint8_t s_simulator_keymask;
1414
static JavaVM* s_simulator_jvm;
1515
static jobject s_simulator_bitmap, s_simulator_thiz;
16-
static jint s_simulator_h, s_simulator_w;
16+
static lv_coord_t s_simulator_h, s_simulator_w;
1717
extern int droidboot_exit;
1818

19-
int droidboot_internal_get_display_height()
19+
lv_coord_t droidboot_internal_get_display_height()
2020
{
2121
return s_simulator_h;
2222
}
2323

24-
int droidboot_internal_get_display_width()
24+
lv_coord_t droidboot_internal_get_display_width()
2525
{
2626
return s_simulator_w;
2727
}
@@ -33,13 +33,13 @@ JNIEXPORT void simulator_stop(JNIEnv* env)
3333
droidboot_exit = 0;
3434
}
3535

36-
JNIEXPORT void simulator_start(JNIEnv* env, jobject thiz, jobject bitmap, jint w, jint h)
36+
__attribute__((unused)) JNIEXPORT void simulator_start(JNIEnv* env, jobject thiz, jobject bitmap, jint w, jint h)
3737
{
3838
(*env)->GetJavaVM(env, &s_simulator_jvm);
3939
s_simulator_bitmap = (*env)->NewGlobalRef(env, bitmap);
4040
s_simulator_thiz = (*env)->NewGlobalRef(env, thiz);
41-
s_simulator_h = h;
42-
s_simulator_w = w;
41+
s_simulator_h = (lv_coord_t)h;
42+
s_simulator_w = (lv_coord_t)w;
4343
droidboot_init();
4444
droidboot_show_dualboot_menu();
4545
simulator_stop(env);
@@ -78,7 +78,7 @@ void droidboot_internal_fb_flush(lv_disp_drv_t * disp_drv, const lv_area_t * are
7878
//__android_log_print(ANDROID_LOG_VERBOSE, "droidboot", "locked fb %p", addr);
7979
for (uint32_t y = area->y1; y <= area->y2; y++) {
8080
for (uint32_t x = area->x1; x <= area->x2; x++) {
81-
addr[(y*s_simulator_w)+x] = 0xff << 24 | color_p->ch.blue << 16 | color_p->ch.green << 8 | color_p->ch.red;
81+
addr[(y*s_simulator_w)+x] = 0xffU << 24 | color_p->ch.blue << 16 | color_p->ch.green << 8 | color_p->ch.red;
8282
color_p++;
8383
}
8484
}
@@ -261,12 +261,12 @@ void droidboot_internal_delay(unsigned int time)
261261
usleep(time*1000);
262262
}
263263

264-
void droidboot_internal_boot_linux_from_ram(void *kernel_raw, off_t kernel_raw_size, void *ramdisk_raw, off_t ramdisk_size, void *dtb_raw, off_t dtb_raw_size, void *dtbo_raw, off_t dtbo_raw_size, char *options)
264+
void droidboot_internal_boot_linux_from_ram(void *kernel_raw, uint64_t kernel_raw_size, void *ramdisk_raw, uint64_t ramdisk_size, void *dtb_raw, uint64_t dtb_raw_size, void *dtbo_raw, uint64_t dtbo_raw_size, char *options)
265265
{
266266
// nothing happens
267267
}
268268

269-
void droidboot_internal_pre_ramdisk_load(void *kernel_raw, off_t kernel_raw_size)
269+
void droidboot_internal_pre_ramdisk_load(void *kernel_raw, uint64_t kernel_raw_size)
270270
{
271271
// nothing happens
272272
}

simulator/simulator.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
#include "droidboot_error.h"
1010

1111
void droidboot_internal_fb_flush(lv_disp_drv_t * disp_drv, const lv_area_t * area, lv_color_t * color_p);
12-
int droidboot_internal_get_display_height();
13-
int droidboot_internal_get_display_width();
12+
lv_coord_t droidboot_internal_get_display_height();
13+
lv_coord_t droidboot_internal_get_display_width();
1414
void droidboot_internal_key_read(lv_indev_drv_t * drv, lv_indev_data_t*data);
1515
droidboot_error droidboot_internal_platform_init();
1616
ssize_t dridboot_internal_sd_read_block(void *buf, uint32_t block, uint count);
@@ -24,8 +24,8 @@ void droidboot_internal_lvgl_threads_init();
2424
void droidboot_internal_platform_on_screen_log(const char *buf);
2525
void droidboot_internal_platform_system_log(const char *buf);
2626
void droidboot_internal_delay(unsigned int time);
27-
void droidboot_internal_boot_linux_from_ram(void *kernel_raw, off_t kernel_raw_size, void *ramdisk_raw, off_t ramdisk_size, void *dtb_raw, off_t dtb_raw_size, void *dtbo_raw, off_t dtbo_raw_size, char *options);
28-
void droidboot_internal_pre_ramdisk_load(void *kernel_raw, off_t kernel_raw_size);
27+
void droidboot_internal_boot_linux_from_ram(void *kernel_raw, uint64_t kernel_raw_size, void *ramdisk_raw, uint64_t ramdisk_size, void *dtb_raw, uint64_t dtb_raw_size, void *dtbo_raw, uint64_t dtbo_raw_size, char *options);
28+
void droidboot_internal_pre_ramdisk_load(void *kernel_raw, uint64_t kernel_raw_size);
2929
void *droidboot_internal_get_kernel_load_addr();
3030
void *droidboot_internal_get_ramdisk_load_addr();
3131
void *droidboot_internal_get_dtb_load_addr();

0 commit comments

Comments
 (0)