Show spinner, then stream, add ctrl+c support #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/shell_sage/pull/63 |
Streaming allows users to start reading the response as soon as the first fragment is generated by the API, significantly improving perceived speed. litellm is now imported lazily so that a spinner can be shown while it loads and sends the first response. This makes the ssage command feel faster and more responsive. Added support for Ctrl+C, letting users interrupt ssage mid-sentence — perfect for recalling an exact command and skipping the rest of the explanation. Example: ```py ssage gh mk pr I can see you're trying to create a pull request with GitHub CLI, but the command syntax isn't quite right. The correct command is: ``` gh pr create ``` This will interactively prompt you Interrupted. ```
ncoop57
reviewed
Nov 24, 2025
| for o in sage(q, max_steps=10, stream=True, api_base=opts.api_base, api_key=opts.api_key): ... | ||
| return o.choices[0].message.content | ||
| gen = sage(q, max_steps=10, stream=True, api_base=opts.api_base, api_key=opts.api_key) | ||
| yield from accumulate(o.choices[0].delta.content or "" for o in gen if isinstance(o, ModelResponseStream)) |
ncoop57
approved these changes
Nov 24, 2025
Contributor
ncoop57
left a comment
ncoop57
left a comment
There was a problem hiding this comment.
This looks amazing, ty so much!! I especially like how you fixed the stream printing in Jupyter!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming allows users to start reading the response as soon as the first fragment is generated by the API, significantly improving perceived speed.
litellm is now imported lazily so that a spinner can be shown while it loads and sends the first response. This makes the ssage command feel faster and more responsive.
Added support for Ctrl+C, letting users interrupt ssage mid-sentence — perfect for recalling an exact command and skipping the rest of the explanation.
Example:
gh pr create
Here is how this pr looks like in action:
output.mp4
PS. how do you clean the diffs of Jupyter notebooks (apart of nbdev_clean)? The vscode gets very confused with the diffs so I end up working on raw json file. :(