more discriminated unions

Author: mikeldking

js/packages/openinference-instrumentation-openai/src/instrumentation.ts

@@ -755,7 +755,7 @@ function getChatCompletionInputMessageAttributes(
             ] = toolCall.function.arguments;
           } else {
             // TODO: add exhaustive checks
-            diag.debug(`Unsupported tool type: ${toolCall.type}`);
+            diag.warn(`Unsupported tool type: ${toolCall.type}`);
           }
         });
       }
@@ -886,7 +886,7 @@ function getChatCompletionOutputMessageAttributes(
         ] = toolCall.function.arguments;
       } else {
         // TODO: switch to exhaustive checks
-        diag.debug(`Unsupported tool type: ${toolCall.type}`);
+        diag.warn(`Unsupported tool type: ${toolCall.type}`);
       }
     });
   }

js/packages/openinference-instrumentation-openai/src/responsesAttributes.ts

@@ -1,5 +1,5 @@
 import { SemanticConventions } from "@arizeai/openinference-semantic-conventions";
-import { Attributes } from "@opentelemetry/api";
+import { Attributes, diag } from "@opentelemetry/api";
 import {
   ResponseCreateParamsBase,
   ResponseInputItem,
@@ -42,8 +42,12 @@ function getResponseItemAttributes(
       attributes[`${prefix}${SemanticConventions.MESSAGE_ROLE}`] = "tool";
       attributes[`${prefix}${SemanticConventions.MESSAGE_TOOL_CALL_ID}`] =
         item.call_id;
-      attributes[`${prefix}${SemanticConventions.MESSAGE_CONTENT}`] =
-        item.output;
+      if (typeof item.output === "string") {
+        attributes[`${prefix}${SemanticConventions.MESSAGE_CONTENT}`] =
+          item.output;
+      } else {
+        diag.warn("Failed to serialize non-string typed tool output");
+      }
       break;
     }
     case "reasoning": {