fix test cases

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

Author: Assem-Uber

src/views/workflow-history/__tests__/workflow-history.test.tsx

@@ -28,7 +28,7 @@ jest.mock('@/hooks/use-page-query-params/use-page-query-params', () =>
   jest.fn(() => [{ historySelectedEventId: '1' }, jest.fn()])
 );
 
-// Mock the hook to use minimal throttle delay for faster tests
+// Mock the hooks to use minimal throttle delay for faster tests
 jest.mock('../hooks/use-workflow-history-fetcher', () => {
   const actual = jest.requireActual('../hooks/use-workflow-history-fetcher');
   return {
@@ -39,6 +39,14 @@ jest.mock('../hooks/use-workflow-history-fetcher', () => {
   };
 });
 
+jest.mock('../hooks/use-workflow-history-grouper', () => {
+  const actual = jest.requireActual('../hooks/use-workflow-history-grouper');
+  return {
+    __esModule: true,
+    default: jest.fn(() => actual.default(0)), // 0ms throttle for tests
+  };
+});
+
 jest.mock(
   '../workflow-history-compact-event-card/workflow-history-compact-event-card',
   () => jest.fn(() => <div>Compact group Card</div>)

src/views/workflow-history/helpers/__tests__/workflow-history-grouper.test.tsx

@@ -625,11 +625,18 @@ describe(WorkflowHistoryGrouper.name, () => {
       status: 'idle',
     });
 
-    // Add events but don't wait - status should be processing
+    // Add events - with batchSize=1, first batch will be processed synchronously but subsequent batches will be async
     grouper.updateEvents(completedActivityTaskEvents);
+
+    // Check state after first batch (might be synchronous)
     state = grouper.getState();
-    expect(state.status).toBe('processing');
-    expect(state.remainingEventsCount).toBeGreaterThan(0);
+    // First batch is processed immediately, so processedEventsCount should be at least 1
+    expect(state.processedEventsCount).toBeGreaterThan(0);
+
+    // If there are remaining events, status could be 'processing'
+    if (state.remainingEventsCount > 0) {
+      expect(state.status).toBe('processing');
+    }
 
     // Wait for processing to complete
     await waitForProcessing();
@@ -677,6 +684,11 @@ function setup(options: Partial<Props> = {}) {
 
   // Helper function to wait for next processing cycle
   const waitForProcessing = async (timeout = 1000): Promise<void> => {
+    // Check if already idle (processing completed synchronously)
+    if (grouper.getState().status === 'idle') {
+      return Promise.resolve();
+    }
+
     await new Promise<void>((resolve, reject) => {
       const timeoutId = setTimeout(() => {
         // Remove this resolver from queue if it times out

src/views/workflow-history/helpers/workflow-history-fetcher.ts

@@ -44,13 +44,17 @@ export default class WorkflowHistoryFetcher {
     if (shouldContinue) {
       this.shouldContinue = shouldContinue;
     }
-    // If already started, return
-    if (this.isStarted) return;
+
+    // remove current listener (if exists) to have fresh emits only
+    this.unsubscribe?.();
+    this.unsubscribe = null;
+
     this.isStarted = true;
     let emitCount = 0;
     const currentState = this.observer.getCurrentResult();
     const fetchedFirstPage = currentState.status !== 'pending';
-    const shouldEnableQuery = !fetchedFirstPage && shouldContinue(currentState);
+    const shouldEnableQuery =
+      !fetchedFirstPage && this.shouldContinue(currentState);
 
     if (shouldEnableQuery) {
       this.observer.setOptions({
@@ -81,8 +85,6 @@ export default class WorkflowHistoryFetcher {
       emit(currentState);
     }
 
-    // remove current listener (if exists) and add new one
-    this.unsubscribe?.();
     this.unsubscribe = this.observer.subscribe((res) => emit(res));
   }
 

src/views/workflow-history/hooks/use-workflow-history-fetcher.ts

@@ -28,6 +28,7 @@ export default function useWorkflowHistoryFetcher(
 
   if (!fetcherRef.current) {
     fetcherRef.current = new WorkflowHistoryFetcher(queryClient, params);
+
     // Fetch first page
     fetcherRef.current.start((state) => !state?.data?.pages?.length);
   }