Constants/ConstantString: safeguard and document handling of various new php syntaxes

Author: jrfnl

WordPressVIPMinimum/Tests/Constants/ConstantStringUnitTest.inc

@@ -54,3 +54,15 @@ if ( ! \defined( WPCOM_VIP, ) ) { // Error.
 if ( ! DEFINED( WPCOM_VIP ) ) { // Error.
 	Define( WPCOM_VIP, true ); // Error.
 }
+
+// Safeguard correct handling of function calls using PHP 8.0+ named parameters.
+\defined( constant_nam: WPCOM_VIP ); // Okay, well not really, typo in param name, but that's not the concern of the sniff.
+define(value: true, constant_name: 'WPCOM_VIP', ); // Okay.
+define(case_insensitive: true, constant_name: WPCOM_VIP ); // Error.
+
+// Looks like a function call, but is a PHP 8.0+ class instantiation via an attribute.
+#[Define('name', 'value')]
+function foo() {}
+
+define(...$params); // PHP 5.6 argument unpacking will be ignored.
+add_action('my_action', define(...)); // PHP 8.1 first class callable will be ignored.

WordPressVIPMinimum/Tests/Constants/ConstantStringUnitTest.php

@@ -29,6 +29,7 @@ public function getErrorList() {
 			50 => 1,
 			54 => 1,
 			55 => 1,
+			61 => 1,
 		];
 	}