Merge pull request #848 from Automattic/feature/security-phpfilterfunctions-change-condition

GaryJones · web-flow · commit ecdc10ce3933 · 2025-07-18T19:59:40.000+01:00
diff --git a/WordPressVIPMinimum/Sniffs/Security/PHPFilterFunctionsSniff.php b/WordPressVIPMinimum/Sniffs/Security/PHPFilterFunctionsSniff.php
@@ -110,7 +110,7 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 
 			// Error codes should probably be made more descriptive, but that would be a BC-break.
 			$error_code = 'MissingSecondParameter';
-			if ( $matched_content === 'filter_input' ) {
+			if ( $param_position === 3 ) {
 				$error_code = 'MissingThirdParameter';
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p`
`110`	`110`
`111`	`111`	`// Error codes should probably be made more descriptive, but that would be a BC-break.`
`112`	`112`	`$error_code = 'MissingSecondParameter';`
`113`		`- if ( $matched_content === 'filter_input' ) {`
	`113`	`+ if ( $param_position === 3 ) {`
`114`	`114`	`$error_code = 'MissingThirdParameter';`
`115`	`115`	`}`
`116`	`116`