-
Notifications
You must be signed in to change notification settings - Fork 841
Forms: Fix button width on mobile devices #46154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
|
@CGastrell Nice, I didn't know we could leave the button's width setting empty! What do you think about adding an "auto" option, like the email field, that behaves the same as when it's set to unspecified/empty? If it's difficult to add, never mind, but I thought it might help the UX. |
Indeed, let me look into it. For now my prio is check what's going on with the border-radius, but those both fall into the same category: the initial default values for some settings/styles don't seem to take. Border-radius does the same thing, says 5 but shows none, you touch the slider and suddenly all works as expected. |
|
Yes, that discrepancy in the border radius value is confusing. Thanks for looking into it. I appreciate it. |
c138887 to
b835756
Compare
Part of https://github.com/Automattic/big-sky-plugin/issues/4708
Proposed changes:
Before: Buttons did not take full width on mobile
Screen.Recording.2025-12-01.at.16.53.56.mov
After: Buttons take full width on mobile, consistent with other form fields
Screen.Recording.2025-12-01.at.16.53.12.mov
Other information:
Jetpack product discussion
https://github.com/Automattic/big-sky-plugin/issues/4708
Does this pull request change what data or activity we track or use?
No
Testing instructions: