Missing fontconfig dependency in binding.gyp

[nea89o]

The binding.gyp file does not include references to fontconfig to provide the header files for fontconfig.h used by src/register_font.cc on linux. This becomes a problem on nixos where there isnt a global include folder. To remedy this, '<!@(pkg-config fontconfig --cflags-only-I | sed s/-I//g)', can be specified in the # 'OS!="win"' block.

[nea89o]

Here is a patch that made node-canvas compile in my nix project.

diff --git a/binding.gyp b/binding.gyp
index 19a33e816626268e3e787927ad4ae30056d6131c..0346662b6ce9615f8d9ecc6ef93d3da4c07edc84 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -129,12 +129,14 @@
             '<!@(pkg-config cairo --libs)',
             '<!@(pkg-config libpng --libs)',
             '<!@(pkg-config pangocairo --libs)',
+            '<!@(pkg-config fontconfig --libs)',
             '<!@(pkg-config freetype2 --libs)'
           ],
           'include_dirs': [
             '<!@(pkg-config cairo --cflags-only-I | sed s/-I//g)',
             '<!@(pkg-config libpng --cflags-only-I | sed s/-I//g)',
             '<!@(pkg-config pangocairo --cflags-only-I | sed s/-I//g)',
+            '<!@(pkg-config fontconfig --cflags-only-I | sed s/-I//g)',
             '<!@(pkg-config freetype2 --cflags-only-I | sed s/-I//g)'
           ],
           'cflags': ['-Wno-cast-function-type'],

[chearon]

Are you using a unique operating system or environment? I don't know how you could have pangocairo not depend on fontconfig.

[nea89o]

This was in nixos.