Skip to content

Commit bc7383c

Browse files
committed
Version bump to 1.0.3
1 parent 794aab1 commit bc7383c

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

NotificationHubs/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.windowsazure</groupId>
55
<artifactId>Notification-Hubs-java-sdk</artifactId>
6-
<version>1.0.2</version>
6+
<version>1.0.3</version>
77
<name>Windows Azure Notification Hubs Java SDK</name>
88
<url>https://github.com/Azure/azure-notificationhubs-java-backend</url>
99
<description>Azure Notification Hubs Java SDK for interacting with the data and management plane operations.</description>

NotificationHubs/src/com/windowsazure/messaging/NotificationHubJob.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ public NotificationHubJobStatus getJobStatus() {
135135
* @param value The Azure Notification Hubs job output container URI value to set.
136136
*/
137137
public void setOutputContainerUri(String value) {
138+
// Keep the raw URI and strip the CDATA
138139
if (value.matches(CDATA_PATTERN)) {
139140
value = value.replaceAll(CDATA_PATTERN, "");
140141
}
@@ -151,7 +152,13 @@ public void setOutputContainerUri(String value) {
151152
* Sets the Azure Notification Hubs job file import URI.
152153
* @param value The Azure Notification Hubs job file import URI value to set.
153154
*/
154-
public void setImportFileUri(String value) { importFileUri = value; }
155+
public void setImportFileUri(String value) {
156+
// Keep the raw URI and strip the CDATA
157+
if (value.matches(CDATA_PATTERN)) {
158+
value = value.replaceAll(CDATA_PATTERN, "");
159+
}
160+
importFileUri = value;
161+
}
155162

156163
/**
157164
* Gets the Azure Notification Hubs job failure message.
@@ -237,6 +244,8 @@ public String getXml() {
237244
if (this.jobType != null) {
238245
buf.append("<Type>").append(this.jobType.name()).append("</Type>");
239246
}
247+
248+
// Wrap URIs in CDATA sections due to illegal XML characters
240249
if (this.outputContainerUri != null) {
241250
String outputContainerUri = this.outputContainerUri;
242251
if (!outputContainerUri.matches(CDATA_PATTERN)) {
@@ -245,7 +254,12 @@ public String getXml() {
245254
buf.append("<OutputContainerUri>").append(outputContainerUri).append("</OutputContainerUri>");
246255
}
247256
if (this.importFileUri != null) {
248-
buf.append("<ImportFileUri>").append(this.importFileUri).append("</ImportFileUri>");
257+
String importFileUri = this.importFileUri;
258+
if (!importFileUri.matches(CDATA_PATTERN)) {
259+
importFileUri = "<![CDATA[" + importFileUri + "]]>";
260+
}
261+
262+
buf.append("<ImportFileUri>").append(importFileUri).append("</ImportFileUri>");
249263
}
250264
buf.append(XML_FOOTER);
251265
return buf.toString();

NotificationHubs/test/com/windowsazure/messaging/NotificationHubJobIncoming

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<Type>ImportCreateRegistrations</Type>
1212
<Status>Completed</Status>
1313
<OutputContainerUri><![CDATA[https://test.blob.core.windows.net/testjobs]]></OutputContainerUri>
14-
<ImportFileUri>https://test.blob.core.windows.net/testjobs/CreateFile.txt</ImportFileUri>
14+
<ImportFileUri><![CDATA[https://test.blob.core.windows.net/testjobs/CreateFile.txt]]></ImportFileUri>
1515
<OutputProperties xmlns:d3p1="http://schemas.microsoft.com/2003/10/Serialization/Arrays">
1616
<d3p1:KeyValueOfstringstring>
1717
<d3p1:Key>OutputFilePath</d3p1:Key>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<?xml version="1.0" encoding="utf-8"?><entry xmlns="http://www.w3.org/2005/Atom"><content type="application/atom+xml;type=entry;charset=utf-8"><NotificationHubJob xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.microsoft.com/netservices/2010/10/servicebus/connect"><Type>ImportCreateRegistrations</Type><OutputContainerUri><![CDATA[https://test.blob.core.windows.net/testjobs]]></OutputContainerUri><ImportFileUri>https://test.blob.core.windows.net/testjobs/CreateFile.txt</ImportFileUri></NotificationHubJob></content></entry>
1+
<?xml version="1.0" encoding="utf-8"?><entry xmlns="http://www.w3.org/2005/Atom"><content type="application/atom+xml;type=entry;charset=utf-8"><NotificationHubJob xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.microsoft.com/netservices/2010/10/servicebus/connect"><Type>ImportCreateRegistrations</Type><OutputContainerUri><![CDATA[https://test.blob.core.windows.net/testjobs]]></OutputContainerUri><ImportFileUri><![CDATA[https://test.blob.core.windows.net/testjobs/CreateFile.txt]]></ImportFileUri></NotificationHubJob></content></entry>

0 commit comments

Comments
 (0)