PR comments fix;

Author: vladimir-shcherbakov

src/TestFx/ITestRunnerFactory.cs

@@ -27,6 +27,6 @@ public interface ITestRunnerFactory
         ITestRunnerFactory WithExtraRmModules(Func<EnvironmentSetupHelper, string[]> buildModuleList);
         ITestRunnerFactory WithNewRmModules(Func<EnvironmentSetupHelper, string[]> buildModuleList);
         ITestRunnerFactory WithExtraUserAgentsToIgnore(Dictionary<string, string> userAgentsToIgnore);
-        ITestRunnerFactory WithBuildMatcher(BuildMatcherDelegate buildMatcher);
+        ITestRunnerFactory WithRecordMatcher(RecordMatcherDelegate recordMatcher);
     }
 }

src/TestFx/TestManager.cs

@@ -30,7 +30,7 @@
 
 namespace Microsoft.Azure.Commands.TestFx
 {
-    public delegate IRecordMatcher BuildMatcherDelegate (bool ignoreResourcesClient, Dictionary<string, string> resourceProviders, Dictionary<string, string> userAgentsToIgnore);
+    public delegate IRecordMatcher RecordMatcherDelegate (bool ignoreResourcesClient, Dictionary<string, string> resourceProviders, Dictionary<string, string> userAgentsToIgnore);
 
     public class TestManager : ITestRunnerFactory, ITestRunner
     {
@@ -42,7 +42,7 @@ public class TestManager : ITestRunnerFactory, ITestRunner
         protected readonly List<string> RmModules;
         protected readonly List<string> CommonPsScripts = new List<string>();
 
-        protected BuildMatcherDelegate BuildMatcher { get; set; }
+        protected RecordMatcherDelegate RecordMatcher { get; set; }
 
         protected XunitTracingInterceptor Logger { get; set; }
 
@@ -75,7 +75,7 @@ protected TestManager(string callingClassName)
                 Helper.RMResourceModule,
             };
 
-            BuildMatcher = (ignoreResourcesClient, resourceProviders, userAgentsToIgnore) =>
+            RecordMatcher = (ignoreResourcesClient, resourceProviders, userAgentsToIgnore) =>
                 new PermissiveRecordMatcherWithApiExclusion(ignoreResourcesClient, resourceProviders, userAgentsToIgnore);
         }
 
@@ -143,11 +143,11 @@ public ITestRunnerFactory WithNewRmModules(Func<EnvironmentSetupHelper, string[]
         /// <summary>
         /// Sets a new HttpMockServer.Matcher implementation. By defauls it's PermissiveRecordMatcherWithApiExclusion
         /// </summary>
-        /// <param name="buildMatcher">delegate</param>
+        /// <param name="recordMatcher">delegate</param>
         /// <returns>self</returns>
-        public ITestRunnerFactory WithBuildMatcher(BuildMatcherDelegate buildMatcher)
+        public ITestRunnerFactory WithRecordMatcher(RecordMatcherDelegate recordMatcher)
         {
-            BuildMatcher = buildMatcher;
+            RecordMatcher = recordMatcher;
             return this;
         }
 
@@ -288,7 +288,7 @@ protected void SetupMockServerMatcher()
 
             _userAgentsToIgnore?.Keys.ForEach(k=> userAgentsToIgnore.Add(k, _userAgentsToIgnore[k]));
 
-            HttpMockServer.Matcher = BuildMatcher(true, resourceProviders, userAgentsToIgnore);
+            HttpMockServer.Matcher = RecordMatcher(true, resourceProviders, userAgentsToIgnore);
         }
 
         #endregion