-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[AutoPR azure-mgmt-servicefabricmanagedclusters]-generated-from-SDK Generation - Python-5554959 #43918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[AutoPR azure-mgmt-servicefabricmanagedclusters]-generated-from-SDK Generation - Python-5554959 #43918
Conversation
…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '833aeb9992144f6e04d99de1316a7f37a001ee94' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5554959 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure Service Fabric Managed Clusters management SDK from API version 2025-06-01-preview to 2025-10-01-preview. It's an auto-generated change that introduces new runtime operations for applications and services, along with corresponding models and enums.
Key changes:
- Updates API version to 2025-10-01-preview
- Adds new runtime operations for application health monitoring, replica restart, and upgrade management
- Converts synchronous update operations to asynchronous LRO (Long Running Operations) patterns
- Modernizes type hints (List[str] → list[str], Dict → dict)
- Migrates from setup.py to pyproject.toml
Reviewed Changes
Copilot reviewed 110 out of 112 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updates TypeSpec source location and commit hash |
| setup.py | Deleted in favor of pyproject.toml |
| pyproject.toml | Adds complete project configuration including build system, dependencies, and metadata |
| _operations.py | Adds new API operations (fetch_health, restart_replica, update_upgrade, restart_deployed_code_package) and converts update methods to LRO pattern |
| _models/init.py | Exports new model classes and enums for runtime operations |
| _enums.py | Adds new enums for health filtering, restart kinds, and runtime upgrade modes |
| _version.py | Bumps version from 2.1.0b4 to 2.1.0b5 |
| _validation.py | New file adding API version validation decorator |
| _configuration.py | Adds cloud_setting parameter and updates default API version |
| _client.py | Adds cloud_setting parameter support |
| CHANGELOG.md | Documents breaking changes and new features |
| generated_tests/*.py | Adds test methods for new operations |
| generated_samples/*.py | Adds sample code for new operations |
| - Deleted or renamed method `ApplicationsOperations.update` | ||
| - Deleted or renamed method `ManagedClustersOperations.update` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rename breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msyyc, updated, please help review.
Configurations: 'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '833aeb9992144f6e04d99de1316a7f37a001ee94' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5554959 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=78ccef09-eb9f-f011-b41c-6045bd07ef68 Submitted by: iliu@microsoft.com
Release Plan Details
Spec pull request: [servicefabricmanagedclusters] 2025-10-01-preview azure-rest-api-specs#37886
Spec API version: 2025-10-01-preview