Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Nov 10, 2025

Configurations: 'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '833aeb9992144f6e04d99de1316a7f37a001ee94' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5554959 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=78ccef09-eb9f-f011-b41c-6045bd07ef68 Submitted by: iliu@microsoft.com

Release Plan Details

…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '833aeb9992144f6e04d99de1316a7f37a001ee94' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5554959 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@iliu816 iliu816 marked this pull request as ready for review November 11, 2025 00:34
Copilot AI review requested due to automatic review settings November 11, 2025 00:34
@iliu816 iliu816 requested a review from msyyc as a code owner November 11, 2025 00:34
Copilot finished reviewing on behalf of iliu816 November 11, 2025 00:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Service Fabric Managed Clusters management SDK from API version 2025-06-01-preview to 2025-10-01-preview. It's an auto-generated change that introduces new runtime operations for applications and services, along with corresponding models and enums.

Key changes:

  • Updates API version to 2025-10-01-preview
  • Adds new runtime operations for application health monitoring, replica restart, and upgrade management
  • Converts synchronous update operations to asynchronous LRO (Long Running Operations) patterns
  • Modernizes type hints (List[str] → list[str], Dict → dict)
  • Migrates from setup.py to pyproject.toml

Reviewed Changes

Copilot reviewed 110 out of 112 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Updates TypeSpec source location and commit hash
setup.py Deleted in favor of pyproject.toml
pyproject.toml Adds complete project configuration including build system, dependencies, and metadata
_operations.py Adds new API operations (fetch_health, restart_replica, update_upgrade, restart_deployed_code_package) and converts update methods to LRO pattern
_models/init.py Exports new model classes and enums for runtime operations
_enums.py Adds new enums for health filtering, restart kinds, and runtime upgrade modes
_version.py Bumps version from 2.1.0b4 to 2.1.0b5
_validation.py New file adding API version validation decorator
_configuration.py Adds cloud_setting parameter and updates default API version
_client.py Adds cloud_setting parameter support
CHANGELOG.md Documents breaking changes and new features
generated_tests/*.py Adds test methods for new operations
generated_samples/*.py Adds sample code for new operations

Comment on lines 29 to 30
- Deleted or renamed method `ApplicationsOperations.update`
- Deleted or renamed method `ManagedClustersOperations.update`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rename breaking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msyyc, updated, please help review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants