[AutoRelease] t2-loganalytics-2025-11-12-48375(can only be merged by SDK owner) #43951
Conversation
There was a problem hiding this comment.
Pull Request Overview
This is an auto-release PR for azure-mgmt-loganalytics that migrates the package from setup.py to pyproject.toml configuration, updates the API version from multiple older versions (2020-08-01, 2019-09-01, 2022-10-01) to a unified 2025-07-01 version, adds new operations (failover, failback, NSP configurations, summary logs), and updates all test files with improved naming conventions.
Key changes:
- Package configuration migration from setup.py to pyproject.toml
- API version consolidation to 2025-07-01
- Addition of new workspace operations (failover, failback, network security perimeter)
- New summary logs operations and tests
- Test method renaming for better clarity
- Code generation updates with improved type hints and imports
Reviewed Changes
Copilot reviewed 192 out of 193 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed - migrated to pyproject.toml |
| sdk_packaging.toml | Removed - merged into pyproject.toml |
| pyproject.toml | Added complete package configuration with build system, dependencies, and metadata |
| generated_tests/* | Updated test methods with prefixed naming and new API version |
| generated_samples/* | Added pylint suppressions and updated API version references |
| conftest.py | Fixed typo in comment |
| workspaces_operations.py | Added new operations and updated to 2025-07-01 API |
| _version.py | Version reset to 0.0.0 for development |
| "msrest>=0.7.1", | ||
| "azure-mgmt-core>=1.6.0", | ||
| "typing-extensions>=4.6.0", | ||
| ] |
There was a problem hiding this comment.
The dependencies list includes 'msrest>=0.7.1' which is a legacy package. Modern Azure SDK packages typically use 'azure-core' instead. This should be verified as intentional or updated to use the current SDK pattern with azure-core.
| ) | ||
|
|
||
| response = client.deleted_workspaces.list() | ||
| response = client.workspaces.list() |
There was a problem hiding this comment.
The sample file is named 'workspaces_subscription_list.py' and the comment on line 39 references 'WorkspacesSubscriptionList.json', but the code calls 'client.workspaces.list()' instead of what appears to be the intended subscription-level list operation. This mismatch could confuse users about which operation this sample demonstrates.
| "location": "eastus", | ||
| "sku": {"capacity": 100, "name": "CapacityReservation"}, |
There was a problem hiding this comment.
[nitpick] The location changed from "australiasoutheast" to "eastus" and capacity from 1000 to 100. While this may be intentional for the sample, it's worth verifying this change aligns with typical production values, as capacity reservation of 100 may be lower than expected for cluster configurations.
2 participants
https://github.com/Azure/sdk-release-request/issues/6735
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1004
BuildTargetingString
azure-mgmt-loganalytics
Skip.CreateApiReview