Resolved an memory leak issue.

katmsft · vinjiang · commit 81c6d456dbdc · 2019-02-01T01:12:14.000-08:00
diff --git a/Microsoft.WindowsAzure.Storage/src/xml_wrapper.cpp b/Microsoft.WindowsAzure.Storage/src/xml_wrapper.cpp
@@ -65,12 +65,24 @@ bool xml_text_reader_wrapper::is_empty_element()
 
 std::string xml_text_reader_wrapper::get_local_name()
 {
-    return xml_char_to_string(xmlTextReaderLocalName(m_reader));
+    auto xml_char = xmlTextReaderLocalName(m_reader);
+    auto result = xml_char_to_string(xml_char);
+    if (xml_char != nullptr)
+    {
+        xmlFree(xml_char);
+    }
+    return result;
 }
 
 std::string xml_text_reader_wrapper::get_value()
 {
-    return xml_char_to_string(xmlTextReaderValue(m_reader));
+    auto xml_char = xmlTextReaderValue(m_reader);
+    auto result = xml_char_to_string(xml_char);
+    if (xml_char != nullptr)
+    {
+        xmlFree(xml_char);
+    }
+    return result;
 }
 
 bool xml_text_reader_wrapper::move_to_first_attribute()

Original file line number	Diff line number	Diff line change
`@@ -65,12 +65,24 @@ bool xml_text_reader_wrapper::is_empty_element()`
`65`	`65`
`66`	`66`	`std::string xml_text_reader_wrapper::get_local_name()`
`67`	`67`	`{`
`68`		`- return xml_char_to_string(xmlTextReaderLocalName(m_reader));`
	`68`	`+ auto xml_char = xmlTextReaderLocalName(m_reader);`
	`69`	`+ auto result = xml_char_to_string(xml_char);`
	`70`	`+ if (xml_char != nullptr)`
	`71`	`+ {`
	`72`	`+ xmlFree(xml_char);`
	`73`	`+ }`
	`74`	`+ return result;`
`69`	`75`	`}`
`70`	`76`
`71`	`77`	`std::string xml_text_reader_wrapper::get_value()`
`72`	`78`	`{`
`73`		`- return xml_char_to_string(xmlTextReaderValue(m_reader));`
	`79`	`+ auto xml_char = xmlTextReaderValue(m_reader);`
	`80`	`+ auto result = xml_char_to_string(xml_char);`
	`81`	`+ if (xml_char != nullptr)`
	`82`	`+ {`
	`83`	`+ xmlFree(xml_char);`
	`84`	`+ }`
	`85`	`+ return result;`
`74`	`86`	`}`
`75`	`87`
`76`	`88`	`bool xml_text_reader_wrapper::move_to_first_attribute()`