Skip to content

Conversation

@antrix1989
Copy link
Contributor

@antrix1989 antrix1989 commented Nov 27, 2025

Proposed changes

Fix webview layout in sample app on mac and update common core. Core pr: AzureAD/microsoft-authentication-library-common-for-objc#1628

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@antrix1989 antrix1989 requested a review from a team as a code owner November 27, 2025 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the macOS test app's UI to use Auto Layout constraints for the web view instead of manual frame-based positioning. The changes improve layout flexibility and maintainability.

Key Changes

  • Replaced frame-based WKWebView positioning with Auto Layout constraints
  • Changed acquireTokenView from NSStackView to NSView to accommodate the new layout approach
  • Updated the storyboard to restructure the view hierarchy with proper Auto Layout constraints

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
MSALAcquireTokenViewController.m Changed webView initialization to use Auto Layout with zero frame and added pin-to-edges constraints
Base.lproj/Main.storyboard Restructured view hierarchy, replacing NSStackView with NSView and adding constraint-based layout
IdentityCore Updated subproject commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@antrix1989 antrix1989 merged commit 55fd93a into dev Dec 2, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants