added support for logistic regression #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulric
commented
Oct 30, 2025
There was a problem hiding this comment.
- Move all magic strings into variables
- Be consistent with the quotes (use styler)
- Move the
purrrcommit above since its being used by the function - Merge the
added test for converting logistic regression modelscommit into the earlier commit that adds support for it - Add test for the intercept functionality
- Merge the intercept commit to the main logistic regression commit
- Add reason why we switched to 4.1 in the commit that adds validation for the model parameter files
- Move the commit that adds magrittr on top
yulric
force-pushed
the
logistic-regression
branch
4 times, most recently
from
333426d to
600e226
Compare
yulric
force-pushed
the
logistic-regression
branch
13 times, most recently
from
fc509a6 to
9e13c72
Compare
yulric
force-pushed
the
logistic-regression
branch
4 times, most recently
from
9cd9927 to
6415c8a
Compare
The minimum R version has been updated to match what's in the new version of the model-parameters library. All the convert_model_export_to_pmml function tests had to be updated since there were errors in the model-parameter files.
yulric
force-pushed
the
logistic-regression
branch
from
6415c8a to
fdd372a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.