Increase 'cigar_buf' size to reduce risk of buffer overflow

hpages · hpages · commit 1f8a1c381a70 · 2023-03-08T15:26:20.000-08:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -10,7 +10,7 @@ biocViews: Infrastructure, DataImport, Genetics, Sequencing, RNASeq, SNP,
 URL: https://bioconductor.org/packages/GenomicAlignments
 Video: https://www.youtube.com/watch?v=2KqBSbkfhRo , https://www.youtube.com/watch?v=3PK_jx44QTs
 BugReports: https://github.com/Bioconductor/GenomicAlignments/issues
-Version: 1.35.0
+Version: 1.35.1
 License: Artistic-2.0
 Encoding: UTF-8
 Authors@R: c(
diff --git a/src/cigar_utils.c b/src/cigar_utils.c
@@ -845,7 +845,7 @@ static const char *Rnarrow_cigar_string(SEXP cigar_string,
 	return errmsg_buf;
 }
 
-#define	CIGAR_BUF_LENGTH 50000
+#define	CIGAR_BUF_LENGTH 250000
 
 /* FIXME: 'cigar_buf' is under the risk of a buffer overflow! */
 static const char *narrow_cigar_string(SEXP cigar_string,

Original file line number	Diff line number	Diff line change
`@@ -845,7 +845,7 @@ static const char *Rnarrow_cigar_string(SEXP cigar_string,`
`845`	`845`	`return errmsg_buf;`
`846`	`846`	`}`
`847`	`847`
`848`		`-#define CIGAR_BUF_LENGTH 50000`
	`848`	`+#define CIGAR_BUF_LENGTH 250000`
`849`	`849`
`850`	`850`	`/* FIXME: 'cigar_buf' is under the risk of a buffer overflow! */`
`851`	`851`	`static const char *narrow_cigar_string(SEXP cigar_string,`