Merge remote-tracking branch 'origin/master' into WP-5445-express-migrate-api-v2-coin-wallet-id-signer-macaroon-to-typed-routes

TICKET: WP-5445

Author: danielzhao122

.github/workflows/ci.yml

@@ -288,13 +288,52 @@ jobs:
           context: .
           file: ./Dockerfile
           push: false
+          load: true
           tags: |
             bitgo/express:${{ github.sha }}
           build-args: |
             VERSION=${{ steps.build-info.outputs.version }}
             BUILD_DATE=${{ steps.build-info.outputs.date }}
             GIT_HASH=${{ github.sha }}
 
+      - name: Test Express Docker image
+        id: docker-test
+        run: |
+          echo "Testing Docker image bitgo/express:${{ github.sha }}"
+          
+          CONTAINER_ID=$(docker run -d -p 3080:3080 bitgo/express:${{ github.sha }})
+          echo "Started container: $CONTAINER_ID"
+          
+          # Wait for the service to be ready with timeout
+          echo "Waiting for service to be ready..."
+          
+          for i in {1..30}; do
+            if curl -f -s --max-time 5 http://localhost:3080/api/v2/ping > /dev/null 2>&1; then
+              echo "✅ API health check passed"
+              break
+            fi
+            
+            if [ $i -eq 30 ]; then
+              echo "::error::API health check failed after 30 attempts"
+              docker logs "$CONTAINER_ID"
+              docker stop "$CONTAINER_ID"
+              docker rm "$CONTAINER_ID"
+              exit 1
+            fi
+            
+            echo "Waiting for API... (attempt $i/30)"
+            sleep 2
+          done
+          
+          # Check container logs for errors
+          docker logs "$CONTAINER_ID"
+          
+          # Stop the container
+          docker stop "$CONTAINER_ID"
+          docker rm "$CONTAINER_ID"
+          
+          echo "✅ Docker image tests passed"
+
   dockerfile-check:
     runs-on: ubuntu-latest
 

CODEOWNERS

@@ -60,6 +60,7 @@
 /modules/sdk-coin-baby/ @BitGo/ethalt-team
 /modules/sdk-coin-bera/ @BitGo/ethalt-team
 /modules/sdk-coin-bsc/ @BitGo/ethalt-team
+/module/sdk-coin-canton/ @BitGo/ethalt-team
 /modules/sdk-coin-coredao/ @BitGo/ethalt-team
 /modules/sdk-coin-cosmos/ @BitGo/ethalt-team
 /modules/sdk-coin-cronos/ @BitGo/ethalt-team

commitlint.config.js

@@ -65,6 +65,7 @@ module.exports = {
         'COIN-',
         'FIAT-',
         'ME-',
+        'ANT-',
         '#', // Prefix used by GitHub issues
       ],
     },

examples/ts/create-go-account.ts

@@ -0,0 +1,67 @@
+/**
+ * Create a Go Account wallet at BitGo.
+ * This makes use of the convenience function generateWallet with type: 'trading'
+ *
+ * IMPORTANT: You must backup the encrypted private key and encrypted wallet passphrase!
+ *
+ * Copyright 2025, BitGo, Inc.  All Rights Reserved.
+ */
+
+import { BitGoAPI } from '@bitgo/sdk-api';
+import { coins } from 'bitgo';
+require('dotenv').config({ path: '../../.env' });
+
+const bitgo = new BitGoAPI({
+  accessToken: process.env.TESTNET_ACCESS_TOKEN,
+  env: 'test', // Change this to env: 'production' when you are ready for production
+});
+
+// Go Accounts use the 'ofc' (Off-Chain) coin
+const coin = 'ofc';
+bitgo.register(coin, coins.Ofc.createInstance);
+
+// TODO: set a label for your new Go Account here
+const label = 'Example Go Account Wallet';
+
+// TODO: set your passphrase for your new wallet here (encrypts the private key)
+const passphrase = 'go_account_wallet_passphrase';
+
+// TODO: set your passcode encryption code here (encrypts the passphrase itself)
+const passcodeEncryptionCode = 'encryption_code_for_passphrase';
+
+// TODO: set your enterprise ID for your new wallet here
+const enterprise = 'your_enterprise_id';
+
+async function main() {
+  const response = await bitgo.coin(coin).wallets().generateWallet({
+    label,
+    passphrase,
+    passcodeEncryptionCode,
+    enterprise,
+    type: 'trading', // Required for Go Accounts
+  });
+
+  // Type guard to ensure we got a Go Account response
+  if (!('userKeychain' in response)) {
+    throw new Error('Go account missing required user keychain');
+  }
+
+  const { wallet, userKeychain, encryptedWalletPassphrase } = response;
+
+  console.log(`Wallet ID: ${wallet.id()}`);
+
+  console.log('BACKUP THE FOLLOWING INFORMATION: ');
+  console.log('User Keychain:');
+  console.log(`Keychain ID: ${userKeychain.id}`);
+  console.log(`Public Key: ${userKeychain.pub}`);
+  console.log(`Encrypted Private Key: ${userKeychain.encryptedPrv}`);
+
+  console.log(`Encrypted Wallet Passphrase: ${encryptedWalletPassphrase}`);
+
+  // Create receive address for Go Account
+  const receiveAddress = await wallet.createAddress();
+  console.log('Go Account Receive Address:', receiveAddress.address);
+}
+
+main().catch((e) => console.error('Error creating Go Account:', e));
+

examples/ts/share-wallet.ts

@@ -22,14 +22,14 @@ bitgo.register(coin, Tbtc.createInstance);
 const walletId = '';
 
 // TODO: set BitGo account email of wallet share recipient
-const recipient = null;
+const recipient = "recipient_email";
 
 // TODO: set share permissions as a comma-separated list
 // Valid permissions to choose from are: view, spend, manage, admin
 const perms = 'view';
 
 // TODO: provide the passphrase for the wallet being shared
-const passphrase = null;
+const passphrase = "passhrase";
 
 async function main() {
   const wallet = await bitgo.coin(coin).wallets().get({ id: walletId });

modules/abstract-cosmos/CHANGELOG.md

@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [11.15.7](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-cosmos@11.15.6...@bitgo/abstract-cosmos@11.15.7) (2025-10-21)
+
+**Note:** Version bump only for package @bitgo/abstract-cosmos
+
+
+
+
+
+## [11.15.6](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-cosmos@11.15.5...@bitgo/abstract-cosmos@11.15.6) (2025-10-16)
+
+**Note:** Version bump only for package @bitgo/abstract-cosmos
+
+
+
+
+
+## [11.15.5](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-cosmos@11.15.4...@bitgo/abstract-cosmos@11.15.5) (2025-10-13)
+
+**Note:** Version bump only for package @bitgo/abstract-cosmos
+
+
+
+
+
 ## [11.15.4](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-cosmos@11.15.3...@bitgo/abstract-cosmos@11.15.4) (2025-10-09)
 
 

modules/abstract-cosmos/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitgo/abstract-cosmos",
-  "version": "11.15.4",
+  "version": "11.15.7",
   "description": "BitGo SDK coin library for COSMOS base implementation",
   "main": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
@@ -38,10 +38,10 @@
     ]
   },
   "dependencies": {
-    "@bitgo/sdk-core": "^36.12.0",
+    "@bitgo/sdk-core": "^36.15.0",
     "@bitgo/sdk-lib-mpc": "^10.8.1",
-    "@bitgo/secp256k1": "^1.5.0",
-    "@bitgo/statics": "^58.4.0",
+    "@bitgo/secp256k1": "^1.6.0",
+    "@bitgo/statics": "^58.7.0",
     "@cosmjs/amino": "^0.29.5",
     "@cosmjs/crypto": "^0.30.1",
     "@cosmjs/encoding": "^0.29.5",

modules/abstract-eth/CHANGELOG.md

@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [24.13.7](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-eth@24.13.6...@bitgo/abstract-eth@24.13.7) (2025-10-21)
+
+**Note:** Version bump only for package @bitgo/abstract-eth
+
+
+
+
+
+## [24.13.6](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-eth@24.13.5...@bitgo/abstract-eth@24.13.6) (2025-10-16)
+
+**Note:** Version bump only for package @bitgo/abstract-eth
+
+
+
+
+
+## [24.13.5](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-eth@24.13.4...@bitgo/abstract-eth@24.13.5) (2025-10-13)
+
+**Note:** Version bump only for package @bitgo/abstract-eth
+
+
+
+
+
 ## [24.13.4](https://github.com/BitGo/BitGoJS/compare/@bitgo/abstract-eth@24.13.3...@bitgo/abstract-eth@24.13.4) (2025-10-09)
 
 

modules/abstract-eth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitgo/abstract-eth",
-  "version": "24.13.4",
+  "version": "24.13.7",
   "description": "BitGo SDK coin library for ETH base implementation",
   "main": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
@@ -40,10 +40,10 @@
     ]
   },
   "dependencies": {
-    "@bitgo/sdk-core": "^36.12.0",
+    "@bitgo/sdk-core": "^36.15.0",
     "@bitgo/sdk-lib-mpc": "^10.8.1",
-    "@bitgo/secp256k1": "^1.5.0",
-    "@bitgo/statics": "^58.4.0",
+    "@bitgo/secp256k1": "^1.6.0",
+    "@bitgo/statics": "^58.7.0",
     "@ethereumjs/common": "^2.6.5",
     "@ethereumjs/rlp": "^4.0.0",
     "@ethereumjs/tx": "^3.3.0",
@@ -60,8 +60,8 @@
     "superagent": "^9.0.1"
   },
   "devDependencies": {
-    "@bitgo/sdk-api": "^1.70.1",
-    "@bitgo/sdk-test": "^9.1.4",
+    "@bitgo/sdk-api": "^1.70.4",
+    "@bitgo/sdk-test": "^9.1.7",
     "@types/keccak": "^3.0.5"
   },
   "gitHead": "18e460ddf02de2dbf13c2aa243478188fb539f0c",

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -67,6 +67,7 @@ import { AbstractEthLikeCoin } from './abstractEthLikeCoin';
 import { EthLikeToken } from './ethLikeToken';
 import {
   calculateForwarderV1Address,
+  decodeTransferData,
   ERC1155TransferBuilder,
   ERC721TransferBuilder,
   getBufferedByteCode,
@@ -1570,6 +1571,30 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
     };
   }
 
+  /**
+   * Extract recipients from transaction hex
+   * @param txHex - The transaction hex string
+   * @returns Array of recipients with address and amount
+   */
+  private async extractRecipientsFromTxHex(txHex: string): Promise<Array<{ address: string; amount: string }>> {
+    const txBuffer = optionalDeps.ethUtil.toBuffer(txHex);
+    const decodedTx = optionalDeps.EthTx.TransactionFactory.fromSerializedData(txBuffer);
+    const recipients: Array<{ address: string; amount: string }> = [];
+
+    if (decodedTx.data && decodedTx.data.length > 0) {
+      const dataHex = optionalDeps.ethUtil.bufferToHex(decodedTx.data);
+      const transferData = decodeTransferData(dataHex);
+      if (transferData.to) {
+        recipients.push({
+          address: transferData.to,
+          amount: transferData.amount,
+        });
+      }
+    }
+
+    return recipients;
+  }
+
   async sendCrossChainRecoveryTransaction(
     params: SendCrossChainRecoveryOptions
   ): Promise<{ coin: string; txHex?: string; txid: string }> {
@@ -1617,15 +1642,22 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
     };
   }
 
-  async buildCrossChainRecoveryTransaction(
-    recoveryId: string
-  ): Promise<{ coin: string; txHex: string; txid: string; walletVersion?: number }> {
+  async buildCrossChainRecoveryTransaction(recoveryId: string): Promise<{
+    coin: string;
+    txHex: string;
+    txid: string;
+    walletVersion?: number;
+    recipients: Array<{ address: string; amount: string }>;
+  }> {
     const res = await this.bitgo.get(this.bitgo.microservicesUrl(`/api/recovery/v1/crosschain/${recoveryId}/buildtx`));
+    // Extract recipients from the transaction hex
+    const recipients = await this.extractRecipientsFromTxHex(res.body.txHex);
     return {
       coin: res.body.coin,
       txHex: res.body.txHex,
       txid: res.body.txid,
       walletVersion: res.body.walletVersion,
+      recipients,
     };
   }