Release 2.8.6 (#1060)

* Bump version to 2.8.6
* Update deps
* Update translations POT file
* Update `@since`
* Delete cached notices after flagging a new notice
* Purge Object Cache files if disabled or the engine changed

Author: cssjoe

Generic_AdminActions_Default.php

@@ -332,6 +332,18 @@ private function _w3tc_save_options_process() {
 				$data['response_errors'][] = 'fancy_permalinks_disabled_pgcache';
 			}
 
+			/**
+			 * Check for Object Cache using Disk being disabled or changed to another engine.
+			 *
+			 * @since 2.8.6
+			 */
+			if (
+				$this->_config->get_boolean( 'objectcache.enabled' ) && 'file' === $this->_config->get_string( 'objectcache.engine' ) &&
+				( ! $config->get_boolean( 'objectcache.enabled' ) || 'file' !== $config->get_string( 'objectcache.engine' ) )
+			) {
+				Util_File::rmdir( Util_Environment::cache_blog_dir( 'object' ) );
+			}
+
 			/**
 			 * Check for Image Service extension status changes.
 			 */

Generic_Plugin.php

@@ -835,18 +835,24 @@ public function post_update_tasks(): void {
 
 			// Check if W3TC was updated to 2.8.6 or higher.
 			if ( \version_compare( W3TC_VERSION, '2.8.6', '>=' ) && ! in_array( '2.8.6', $ran_versions, true ) ) {
-				// Disable Object Cache if using Disk and show a notice in wp-admin.
+				// Disable Object Cache if using Disk, purge the cache files, and show a notice in wp-admin.
 				if ( $this->_config->get_boolean( 'objectcache.enabled' ) && 'file' === $this->_config->get_string( 'objectcache.engine' ) ) {
 					$this->_config->set( 'objectcache.enabled', false );
 					$this->_config->save();
-				}
 
-				// Set the flag to show the notice.
-				$state->set( 'tasks.notices.disabled_objdisk', true );
+					// Purge the Object Cache files.
+					Util_File::rmdir( Util_Environment::cache_blog_dir( 'object' ) );
+
+					// Set the flag to show the notice.
+					$state->set( 'tasks.notices.disabled_objdisk', true );
+				}
 
 				// Mark the task as ran.
 				$ran_versions[] = '2.8.6';
 				update_option( 'w3tc_post_update_tasks_ran_versions', $ran_versions, false );
+
+				// Delete cached notices.
+				delete_option( 'w3tc_cached_notices' );
 			}
 
 			// Mark the task runner as ran for the current version.

ObjectCache_DiskPopup.js

@@ -1,15 +1,15 @@
 /**
  * File: ObjectCache_DiskPopup.js
  *
- * @since X.X.X
+ * @since 2.8.6
  *
  * @package W3TC
  */
 
 /**
  * Modal for object cache disk usage risk acceptance.
  *
- * @since X.X.X
+ * @since 2.8.6
  *
  * @return void
  */

ObjectCache_DiskPopup_View.php

@@ -2,7 +2,7 @@
 /**
  * File: ObjectCache_DiskPopup_View.php
  *
- * @since X.X.X
+ * @since 2.8.6
  *
  * @package W3TC
  */

ObjectCache_Plugin_Admin.php

@@ -131,7 +131,7 @@ public function w3tc_usage_statistics_summary_from_history( $summary, $history )
 	/**
 	 * Enqueue disk usage risk acceptance script.
 	 *
-	 * @since X.X.X
+	 * @since 2.8.6
 	 *
 	 * @return void
 	 */
@@ -151,7 +151,7 @@ public function admin_enqueue_scripts() {
 	/**
 	 * Popup modal for Object Cache disk usage risk acceptance.
 	 *
-	 * @since X.X.X
+	 * @since 2.8.6
 	 *
 	 * @return void
 	 */