Skip to content

Commit 4472486

Browse files
authored
Merge branch 'ChromeDevTools:main' into main
2 parents 543b097 + 0a42aeb commit 4472486

File tree

936 files changed

+24902
-15757
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

936 files changed

+24902
-15757
lines changed

.github/workflows/auto-close-prs.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
name: Auto-close PRs
2+
3+
permissions:
4+
pull-requests: write
5+
issues: write
6+
7+
on:
8+
schedule:
9+
# Run everyday at: https://crontab.guru/#0_6_*_*_*.
10+
- cron: '0 6 * * *'
11+
workflow_dispatch:
12+
13+
jobs:
14+
auto-close:
15+
runs-on: ubuntu-latest
16+
steps:
17+
- uses: actions/checkout@v4
18+
with:
19+
sparse-checkout: |
20+
.github
21+
- name: Close open pull requests
22+
shell: bash
23+
env:
24+
GH_TOKEN: ${{ github.token }}
25+
run: |
26+
PRS=$(gh pr list --state=open --repo=ChromeDevTools/devtools-frontend --json number --jq '.[].number')
27+
for PR in $PRS; do
28+
# See https://cli.github.com/manual/gh_pr_close
29+
gh pr close --comment "Auto-closing the pull request because we do not accept PRs via the GitHub mirror. See README.md on how to contribute to DevTools." $PR
30+
done

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ Muhammad Mahad <mahadtxt@gmail.com>
6666
Naoto Ono <onoto1998@gmail.com>
6767
Paras Awasthi <awasthiparas6@gmail.com>
6868
Paul Fisher <paul@pfish.zone>
69+
Peng Zhou <zhoupeng.1996@bytedance.com>
6970
Per-Olov Jernberg <possan@possan.se>
7071
PhistucK <phistuck@gmail.com>
7172
Pradhuman Singh Baid <pradhumansinghbaid@gmail.com>

DEPS

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,24 @@ vars = {
1515
'build_revision': 'e13953ced04ed05f45aa3c961bd6d802aced74ec',
1616

1717
'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
18-
'buildtools_revision': 'f7862e515c44313f6942517fef6d7718d92283d3',
18+
'buildtools_revision': 'b9050718cd8ee119996c515e8abe9ba65a4f4367',
1919

2020
'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
21-
'depot_tools_revision': '5cc29c7a217801cfa7b7b0aa23144300b49b750d',
21+
'depot_tools_revision': '5e6b39291412822ad5f14c1dccf9a4c6d062ad1f',
2222

2323
'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
24-
'inspector_protocol_revision': '6d1ae0f13aae6ad381ca31b17b88a0f5af29ca94',
24+
'inspector_protocol_revision': 'bdc11c1d3130b92e0986f38f2e58f93cc5a674a8',
2525

26-
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '9a6cdde91b579b777f10c566efb8b25d7552f21e',
26+
# Keeping track of the last time we rolled the browser protocol files.
27+
'chromium_browser_protocol_revision' : '1b4f8aac5b4658583e1deab8084ae14c0800f90e',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
3131

3232
'emscripten_tag': 'ade9d780ff17c88d81aa13860361743e3c1e1396',
3333

3434
# GN CIPD package version.
35-
'gn_version': 'git_revision:97b68a0bb62b7528bc3491c7949d6804223c2b82',
35+
'gn_version': 'git_revision:c4748415f12ac92d2781608b8b84fcc0e33e5ff9',
3636

3737
'cmake_version': 'version:2@3.21.3',
3838

@@ -49,7 +49,7 @@ vars = {
4949
# Chrome version used for tests. It should be regularly updated to
5050
# match the Canary version listed here:
5151
# https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
52-
'chrome': '139.0.7247.0',
52+
'chrome': '140.0.7296.0',
5353

5454
# 'magic' text to tell depot_tools that git submodules should be accepted but
5555
# but parity with DEPS file is expected.
@@ -59,7 +59,7 @@ vars = {
5959
'non_git_source': 'True',
6060

6161
# siso CIPD package version
62-
'siso_version': 'git_revision:4ac6aa83563aed91e78947b2b466eb6d49d51a21',
62+
'siso_version': 'git_revision:dcd000e47f19677c7a5e02550abafa9eadbd4923',
6363
}
6464

6565
# Only these hosts are allowed for dependencies in this DEPS file.

OWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ per-file package-lock.json=file://config/owner/INFRA_OWNERS
1313
per-file package.json=file://config/owner/INFRA_OWNERS
1414
per-file tsconfig.json=file://config/owner/INFRA_OWNERS
1515
per-file eslint.config.mjs=file://config/owner/COMMON_OWNERS
16+
per-file .github=file://config/owner/INFRA_OWNERS
1617

1718
# git submodules
1819
per-file build=devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

PRESUBMIT.py

Lines changed: 11 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,11 @@ def CheckNoUncheckedFiles(input_api, output_api):
489489

490490

491491
def _TextFilesOnlyFilter(file):
492-
"""Filters files based on prefixes and extensions that should not be treated as text files for the canned checks below."""
492+
"""Filter that yields only text files.
493+
494+
Filters files based on prefixes and extensions that should not be treated as
495+
text files for the canned checks below.
496+
"""
493497
excluded_prefixes = [
494498
'node_modules',
495499
'third_party',
@@ -508,42 +512,22 @@ def _TextFilesOnlyFilter(file):
508512
return True
509513

510514

511-
def CheckChangeHasNoStrayWhitespace(input_api, output_api):
512-
return input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
513-
input_api, output_api, source_file_filter=_TextFilesOnlyFilter)
514-
515-
516515
def CheckChangeHasNoCrAndHasOnlyOneEol(input_api, output_api):
517516
return input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(
518517
input_api, output_api, source_file_filter=_TextFilesOnlyFilter)
519518

520519

521-
def CheckForCommitObjects(input_api, output_api):
522-
return input_api.canned_checks.CheckForCommitObjects(input_api, output_api)
523-
524-
525-
def CheckOwnersFormat(input_api, output_api):
526-
return input_api.canned_checks.CheckOwnersFormat(input_api, output_api)
527-
528-
529-
def CheckOwners(input_api, output_api):
530-
return input_api.canned_checks.CheckOwners(input_api, output_api)
531-
532-
533520
def CheckGenderNeutral(input_api, output_api):
534521
return input_api.canned_checks.CheckGenderNeutral(input_api, output_api)
535522

536523

537-
def CheckDoNotSubmitInFiles(input_api, output_api):
538-
return input_api.canned_checks.CheckDoNotSubmitInFiles(
539-
input_api, output_api)
540-
541-
542-
def CheckChangeHasDescriptionCommit(input_api, output_api):
543-
return input_api.canned_checks.CheckChangeHasDescription(
544-
input_api, output_api)
545-
546524

547525
def CheckAuthorizedAuthor(input_api, output_api):
548526
return input_api.canned_checks.CheckAuthorizedAuthor(
549527
input_api, output_api, bot_allowlist=[AUTOROLL_ACCOUNT])
528+
529+
530+
def CheckPanProjectChecksOnCommit(input_api, output_api):
531+
return input_api.canned_checks.PanProjectChecks(input_api,
532+
output_api,
533+
maxlen=120)

buildtools

Submodule buildtools updated from f7862e5 to b905071

config/gni/devtools_grd_files.gni

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ grd_files_bundled_sources = [
263263
"front_end/Images/smart-assistant.svg",
264264
"front_end/Images/snippet.svg",
265265
"front_end/Images/spark-info.svg",
266+
"front_end/Images/speculative-loads.svg",
266267
"front_end/Images/star.svg",
267268
"front_end/Images/step-into.svg",
268269
"front_end/Images/step-out.svg",
@@ -383,6 +384,7 @@ grd_files_bundled_sources = [
383384
"front_end/models/breakpoints/breakpoints.js",
384385
"front_end/models/cpu_profile/cpu_profile.js",
385386
"front_end/models/crux-manager/crux-manager.js",
387+
"front_end/models/elements/elements.js",
386388
"front_end/models/emulation/emulation.js",
387389
"front_end/models/extensions/extensions.js",
388390
"front_end/models/formatter/formatter.js",
@@ -565,6 +567,7 @@ grd_files_bundled_sources = [
565567
"front_end/models/issues_manager/descriptions/sriValidationFailedSignatureMismatch.md",
566568
"front_end/models/issues_manager/descriptions/stylesheetLateImport.md",
567569
"front_end/models/issues_manager/descriptions/stylesheetRequestFailed.md",
570+
"front_end/models/issues_manager/descriptions/summaryElementAccessibilityInteractiveContentSummaryDescendant.md",
568571
"front_end/models/issues_manager/descriptions/userReidentificationBlocked.md",
569572
"front_end/models/issues_manager/issues_manager.js",
570573
"front_end/models/javascript_metadata/javascript_metadata.js",
@@ -816,6 +819,7 @@ grd_files_bundled_sources = [
816819
"front_end/third_party/marked/marked.js",
817820
"front_end/third_party/puppeteer-replay/puppeteer-replay.js",
818821
"front_end/third_party/puppeteer/puppeteer.js",
822+
"front_end/third_party/source-map-scopes-codec/source-map-scopes-codec.js",
819823
"front_end/third_party/third-party-web/third-party-web.js",
820824
"front_end/third_party/wasmparser/wasmparser.js",
821825
"front_end/third_party/web-vitals/web-vitals.js",
@@ -885,6 +889,7 @@ grd_files_unbundled_sources = [
885889
"front_end/core/common/Console.js",
886890
"front_end/core/common/Debouncer.js",
887891
"front_end/core/common/EventTarget.js",
892+
"front_end/core/common/Gzip.js",
888893
"front_end/core/common/JavaScriptMetaData.js",
889894
"front_end/core/common/Lazy.js",
890895
"front_end/core/common/Linkifier.js",
@@ -1100,6 +1105,7 @@ grd_files_unbundled_sources = [
11001105
"front_end/models/cpu_profile/CPUProfileDataModel.js",
11011106
"front_end/models/cpu_profile/ProfileTreeModel.js",
11021107
"front_end/models/crux-manager/CrUXManager.js",
1108+
"front_end/models/elements/ElementUpdateRecord.js",
11031109
"front_end/models/emulation/DeviceModeModel.js",
11041110
"front_end/models/emulation/EmulatedDevices.js",
11051111
"front_end/models/extensions/ExtensionAPI.js",
@@ -1129,6 +1135,7 @@ grd_files_unbundled_sources = [
11291135
"front_end/models/issues_manager/CorsIssue.js",
11301136
"front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.js",
11311137
"front_end/models/issues_manager/DeprecationIssue.js",
1138+
"front_end/models/issues_manager/ElementAccessibilityIssue.js",
11321139
"front_end/models/issues_manager/FederatedAuthRequestIssue.js",
11331140
"front_end/models/issues_manager/FederatedAuthUserInfoRequestIssue.js",
11341141
"front_end/models/issues_manager/GenericIssue.js",
@@ -1145,7 +1152,6 @@ grd_files_unbundled_sources = [
11451152
"front_end/models/issues_manager/QuirksModeIssue.js",
11461153
"front_end/models/issues_manager/RelatedIssue.js",
11471154
"front_end/models/issues_manager/SRIMessageSignatureIssue.js",
1148-
"front_end/models/issues_manager/SelectElementAccessibilityIssue.js",
11491155
"front_end/models/issues_manager/SharedArrayBufferIssue.js",
11501156
"front_end/models/issues_manager/SharedDictionaryIssue.js",
11511157
"front_end/models/issues_manager/SourceFrameIssuesManager.js",
@@ -1286,6 +1292,7 @@ grd_files_unbundled_sources = [
12861292
"front_end/models/trace/types/Configuration.js",
12871293
"front_end/models/trace/types/Extensions.js",
12881294
"front_end/models/trace/types/File.js",
1295+
"front_end/models/trace/types/Overlays.js",
12891296
"front_end/models/trace/types/Timing.js",
12901297
"front_end/models/trace/types/TraceEvents.js",
12911298
"front_end/models/workspace/FileManager.js",
@@ -1495,6 +1502,7 @@ grd_files_unbundled_sources = [
14951502
"front_end/panels/elements/ElementsTreeElement.js",
14961503
"front_end/panels/elements/ElementsTreeElementHighlighter.js",
14971504
"front_end/panels/elements/ElementsTreeOutline.js",
1505+
"front_end/panels/elements/ElementsTreeOutlineRenderer.js",
14981506
"front_end/panels/elements/EventListenersWidget.js",
14991507
"front_end/panels/elements/ImagePreviewPopover.js",
15001508
"front_end/panels/elements/InspectElementModeController.js",
@@ -1507,6 +1515,7 @@ grd_files_unbundled_sources = [
15071515
"front_end/panels/elements/PropertiesWidget.js",
15081516
"front_end/panels/elements/PropertyNameCategories.js",
15091517
"front_end/panels/elements/PropertyRenderer.js",
1518+
"front_end/panels/elements/ShortcutTreeElement.js",
15101519
"front_end/panels/elements/StyleEditorWidget.js",
15111520
"front_end/panels/elements/StylePropertiesSection.js",
15121521
"front_end/panels/elements/StylePropertyHighlighter.js",
@@ -1936,6 +1945,7 @@ grd_files_unbundled_sources = [
19361945
"front_end/panels/timeline/EventsSerializer.js",
19371946
"front_end/panels/timeline/EventsTimelineTreeView.js",
19381947
"front_end/panels/timeline/ExtensionTrackAppender.js",
1948+
"front_end/panels/timeline/ExternalRequests.js",
19391949
"front_end/panels/timeline/FreshRecording.js",
19401950
"front_end/panels/timeline/GPUTrackAppender.js",
19411951
"front_end/panels/timeline/Initiators.js",
@@ -2054,6 +2064,7 @@ grd_files_unbundled_sources = [
20542064
"front_end/panels/timeline/overlays/components/timeRangeOverlay.css.js",
20552065
"front_end/panels/timeline/overlays/components/timespanBreakdownOverlay.css.js",
20562066
"front_end/panels/timeline/thirdPartyTreeView.css.js",
2067+
"front_end/panels/timeline/timelineDetailsView.css.js",
20572068
"front_end/panels/timeline/timelineFlameChartView.css.js",
20582069
"front_end/panels/timeline/timelineFlamechartPopover.css.js",
20592070
"front_end/panels/timeline/timelineHistoryManager.css.js",
@@ -2302,6 +2313,15 @@ grd_files_unbundled_sources = [
23022313
"front_end/third_party/puppeteer/package/lib/esm/third_party/mitt/mitt.js",
23032314
"front_end/third_party/puppeteer/package/lib/esm/third_party/parsel-js/parsel-js.js",
23042315
"front_end/third_party/puppeteer/package/lib/esm/third_party/rxjs/rxjs.js",
2316+
"front_end/third_party/source-map-scopes-codec/package/src/builder/builder.js",
2317+
"front_end/third_party/source-map-scopes-codec/package/src/builder/safe_builder.js",
2318+
"front_end/third_party/source-map-scopes-codec/package/src/codec.js",
2319+
"front_end/third_party/source-map-scopes-codec/package/src/decode/decode.js",
2320+
"front_end/third_party/source-map-scopes-codec/package/src/encode/encode.js",
2321+
"front_end/third_party/source-map-scopes-codec/package/src/encode/encoder.js",
2322+
"front_end/third_party/source-map-scopes-codec/package/src/mod.js",
2323+
"front_end/third_party/source-map-scopes-codec/package/src/util.js",
2324+
"front_end/third_party/source-map-scopes-codec/package/src/vlq.js",
23052325
"front_end/third_party/third-party-web/lib/nostats-subset.js",
23062326
"front_end/third_party/wasmparser/package/dist/esm/WasmDis.js",
23072327
"front_end/third_party/wasmparser/package/dist/esm/WasmParser.js",
@@ -2454,6 +2474,7 @@ grd_files_unbundled_sources = [
24542474
"front_end/ui/components/text_editor/cursor_tooltip.js",
24552475
"front_end/ui/components/text_editor/javascript.js",
24562476
"front_end/ui/components/text_editor/position.js",
2477+
"front_end/ui/components/text_editor/textEditor.css.js",
24572478
"front_end/ui/components/text_editor/theme.js",
24582479
"front_end/ui/components/text_prompt/TextPrompt.js",
24592480
"front_end/ui/components/text_prompt/textPrompt.css.js",
@@ -2551,7 +2572,6 @@ grd_files_unbundled_sources = [
25512572
"front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.js",
25522573
"front_end/ui/legacy/components/inline_editor/Swatches.js",
25532574
"front_end/ui/legacy/components/inline_editor/bezierEditor.css.js",
2554-
"front_end/ui/legacy/components/inline_editor/bezierSwatch.css.js",
25552575
"front_end/ui/legacy/components/inline_editor/colorMixSwatch.css.js",
25562576
"front_end/ui/legacy/components/inline_editor/colorSwatch.css.js",
25572577
"front_end/ui/legacy/components/inline_editor/cssAngle.css.js",

config/gni/devtools_image_files.gni

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ devtools_svg_sources = [
261261
"smart-assistant.svg",
262262
"snippet.svg",
263263
"spark-info.svg",
264+
"speculative-loads.svg",
264265
"star.svg",
265266
"step-into.svg",
266267
"step-out.svg",

config/owner/COMMON_OWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@ leese@chromium.org
1717
mathias@chromium.org
1818
nancyly@chromium.org
1919
nechaev@chromium.org
20+
nharshunova@chromium.org
2021
nvitkov@chromium.org
2122
paulirish@chromium.org
2223
petermueller@chromium.org
2324
pfaffe@chromium.org
25+
piotrpaulski@chromium.org
2426
sadym@chromium.org
2527
samiyac@chromium.org
2628
szuend@chromium.org

docs/committers_policy.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ Once you get approval from the existing committers, you'll be added to [chrome-d
2929

3030
In the most unfavorable circumstances, the process could extend up to two weeks. Maintain your commitment to writing patches. Even in the uncommon instances where a nomination fails, the objection is frequently something specific to resolve, such as "more patches" or "not enough people are familiar with this person's work."
3131

32+
Two-factor authentication is a requirement for adding your account as a committer. If you haven't done so already, you'll need to set up a security key on your account.
33+
3234
# **Maintaining committer status**
3335

3436
Maintaining committer status in the DevTools project is straightforward. Continue to contribute and help the project in meaningful ways. If you remain inactive for 12 consecutive months (absence of comments, uploads, and reviews), you will be notified via email about removal in 7 days and then automatically removed from the list. You may reapply for committer status without going through the full nomination process.

0 commit comments

Comments
 (0)