From 628c4cfe2dfb6904abc4c8a9e2453bb189d951b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20G=C3=BCnther?= Date: Thu, 15 May 2025 13:45:28 +0200 Subject: [PATCH 1/2] Fix deprecated header includes --- .../imu_complementary_filter/complementary_filter_ros.h | 6 +++--- imu_complementary_filter/src/complementary_filter_ros.cpp | 4 ++-- .../include/imu_filter_madgwick/imu_filter_ros.h | 6 +++--- imu_filter_madgwick/src/imu_filter_ros.cpp | 2 +- rviz_imu_plugin/src/imu_display.h | 2 +- rviz_imu_plugin/src/mag_display.h | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h b/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h index 9c9a44f5..70a941be 100644 --- a/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h +++ b/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h @@ -36,9 +36,9 @@ #include #include -#include -#include -#include +#include +#include +#include #include #include #include diff --git a/imu_complementary_filter/src/complementary_filter_ros.cpp b/imu_complementary_filter/src/complementary_filter_ros.cpp index 89397c9d..de6016af 100644 --- a/imu_complementary_filter/src/complementary_filter_ros.cpp +++ b/imu_complementary_filter/src/complementary_filter_ros.cpp @@ -78,13 +78,13 @@ ComplementaryFilterROS::ComplementaryFilterROS() }}; imu_subscriber_.reset(new ImuSubscriber(this, "imu/data_raw", - rmw_qos_profile_default, sub_opts)); + rclcpp::QoS(queue_size), sub_opts)); // Register magnetic data subscriber. if (use_mag_) { mag_subscriber_.reset(new MagSubscriber( - this, "imu/mag", rmw_qos_profile_default, sub_opts)); + this, "imu/mag", rclcpp::QoS(queue_size), sub_opts)); sync_.reset(new Synchronizer(SyncPolicy(queue_size), *imu_subscriber_, *mag_subscriber_)); diff --git a/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h b/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h index 8edc0913..17dd30ab 100644 --- a/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h +++ b/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h @@ -28,9 +28,9 @@ #include "tf2_ros/transform_broadcaster.h" #include -#include -#include -#include +#include +#include +#include #include #include #include diff --git a/imu_filter_madgwick/src/imu_filter_ros.cpp b/imu_filter_madgwick/src/imu_filter_ros.cpp index 5828c162..b5a14f84 100644 --- a/imu_filter_madgwick/src/imu_filter_ros.cpp +++ b/imu_filter_madgwick/src/imu_filter_ros.cpp @@ -200,7 +200,7 @@ ImuFilterMadgwickRos::ImuFilterMadgwickRos(const rclcpp::NodeOptions &options) // Synchronize inputs. Topic subscriptions happen on demand in the // connection callback. const int queue_size = 5; - rmw_qos_profile_t qos = rmw_qos_profile_sensor_data; + auto qos = rclcpp::QoS(rclcpp::SensorDataQoS()); imu_subscriber_.reset(new ImuSubscriber(this, "imu/data_raw", qos)); if (use_mag_) diff --git a/rviz_imu_plugin/src/imu_display.h b/rviz_imu_plugin/src/imu_display.h index b4e05824..472f7f30 100644 --- a/rviz_imu_plugin/src/imu_display.h +++ b/rviz_imu_plugin/src/imu_display.h @@ -31,7 +31,7 @@ #ifndef RVIZ_IMU_PLUGIN_IMU_DISPLAY_H #define RVIZ_IMU_PLUGIN_IMU_DISPLAY_H -#include +#include #include #include #include diff --git a/rviz_imu_plugin/src/mag_display.h b/rviz_imu_plugin/src/mag_display.h index b9273e9c..2f45f7d2 100644 --- a/rviz_imu_plugin/src/mag_display.h +++ b/rviz_imu_plugin/src/mag_display.h @@ -31,7 +31,7 @@ #ifndef RVIZ_IMU_PLUGIN_MAG_DISPLAY_H #define RVIZ_IMU_PLUGIN_MAG_DISPLAY_H -#include +#include #include #include #include From 74befff2c071b741be4adce6f1762fc7cf2db8ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20G=C3=BCnther?= Date: Thu, 15 May 2025 15:41:27 +0200 Subject: [PATCH 2/2] Fix remaining deprecated headers --- .../complementary_filter_ros.h | 4 ++-- .../src/complementary_filter_ros.cpp | 10 +++++----- .../include/imu_filter_madgwick/imu_filter_ros.h | 2 +- imu_filter_madgwick/src/imu_filter_ros.cpp | 4 ++-- imu_filter_madgwick/src/stateless_orientation.cpp | 4 ++-- imu_filter_madgwick/test/test_helpers.h | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h b/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h index 70a941be..34b76f24 100644 --- a/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h +++ b/imu_complementary_filter/include/imu_complementary_filter/complementary_filter_ros.h @@ -42,8 +42,8 @@ #include #include #include -#include -#include +#include +#include #include #include diff --git a/imu_complementary_filter/src/complementary_filter_ros.cpp b/imu_complementary_filter/src/complementary_filter_ros.cpp index de6016af..f3afbcb9 100644 --- a/imu_complementary_filter/src/complementary_filter_ros.cpp +++ b/imu_complementary_filter/src/complementary_filter_ros.cpp @@ -33,11 +33,11 @@ #include "imu_complementary_filter/complementary_filter_ros.h" -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include namespace imu_tools { diff --git a/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h b/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h index 17dd30ab..cc5880e9 100644 --- a/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h +++ b/imu_filter_madgwick/include/imu_filter_madgwick/imu_filter_ros.h @@ -33,7 +33,7 @@ #include #include #include -#include +#include #include "imu_filter_madgwick/imu_filter.h" #include "imu_filter_madgwick/base_node.hpp" diff --git a/imu_filter_madgwick/src/imu_filter_ros.cpp b/imu_filter_madgwick/src/imu_filter_ros.cpp index b5a14f84..db389bdb 100644 --- a/imu_filter_madgwick/src/imu_filter_ros.cpp +++ b/imu_filter_madgwick/src/imu_filter_ros.cpp @@ -27,8 +27,8 @@ #include "imu_filter_madgwick/stateless_orientation.h" #include "rclcpp/rclcpp.hpp" #include "std_msgs/msg/string.hpp" -#include -#include +#include +#include using namespace std::chrono_literals; using namespace rclcpp; diff --git a/imu_filter_madgwick/src/stateless_orientation.cpp b/imu_filter_madgwick/src/stateless_orientation.cpp index ce7f6b32..d78e2bd2 100644 --- a/imu_filter_madgwick/src/stateless_orientation.cpp +++ b/imu_filter_madgwick/src/stateless_orientation.cpp @@ -23,8 +23,8 @@ */ #include "imu_filter_madgwick/stateless_orientation.h" -#include -#include +#include +#include #include template diff --git a/imu_filter_madgwick/test/test_helpers.h b/imu_filter_madgwick/test/test_helpers.h index adde3f56..500af507 100644 --- a/imu_filter_madgwick/test/test_helpers.h +++ b/imu_filter_madgwick/test/test_helpers.h @@ -3,7 +3,7 @@ #define TEST_TEST_HELPERS_H_ #include -#include +#include #define MAX_DIFF 0.05