-
Notifications
You must be signed in to change notification settings - Fork 10
Description
Hello HOAlibrary crew,
I am in the process of linking the HOA library to an offline audio processing library I am writing, and in doing so I noticed that you had no implementation for 3d rotations. I have set up in a couple of days a barebone implementation, based on yaw/pitch/roll; there's a little convention mismatch with the axis of my library, but I will handle it outside. One could certainly imagine a direct quaternion input (as a matter of fact, that's probably almost a one liner, given that my current implementation uses Eigen's quaternionToEuler conversions).
Not sure if the 3d rotation was already in your pipeline. Also, I'm no expert in this 3d rotational geometry, euler angles, quaternions, etc. So what I did is definitely error prone, and should be perhaps checked by someone more skilled than I am. Another limitation is that only orders up to 21 are supported (in practice this is not a limitation, of course, but in theory it is...), since I am relying on the Ry90 matrices Frank Zotter provided (and they exist up to the 21st order). That being said, for my application it seems to work nicely, although I'm sure that you would have implemented it ten times better than I did.
In any case, if that was not in your pipeline and you are interested to merge it, let me know and I can perhaps make a pull request at some point.
Thanks for your amazing work!
Daniele