condition reference can be part of the result

Author: emilefokkemanavara

test/engine-event.test.js

@@ -116,6 +116,26 @@ describe('Engine: event', () => {
     engine.addFact('age', 21)
   }
 
+  function setupWithUndefinedCondition () {
+    const conditionName = 'conditionThatIsNotDefined'
+    const conditions = {
+      any: [
+        { condition: conditionName, name: 'nameOfTheUndefinedConditionReference' },
+        {
+          name: 'over 21',
+          fact: 'age',
+          operator: 'greaterThanInclusive',
+          value: 21
+        }
+      ]
+    }
+    engine = engineFactory([], { allowUndefinedConditions: true })
+    const ruleOptions = { conditions, event: awesomeEvent, priority: 100 }
+    const rule = factories.rule(ruleOptions)
+    engine.addRule(rule)
+    engine.addFact('age', 21)
+  }
+
   context('engine events: simple', () => {
     beforeEach(() => simpleSetup())
 
@@ -635,4 +655,15 @@ describe('Engine: event', () => {
       expect(JSON.stringify(ruleResult)).to.equal(expected)
     })
   })
+
+  context('rule events: json serializing with condition reference that is undefined', () => {
+    beforeEach(() => setupWithUndefinedCondition())
+    it('serializes properties', async () => {
+      const { results: [ruleResult] } = await engine.run()
+      const { conditions: { any: [conditionReference] } } = ruleResult
+      expect(conditionReference.result).to.equal(false)
+      const expected = '{"conditions":{"priority":1,"any":[{"name":"nameOfTheUndefinedConditionReference","condition":"conditionThatIsNotDefined"},{"name":"over 21","operator":"greaterThanInclusive","value":21,"fact":"age","factResult":21,"result":true}]},"event":{"type":"awesome"},"priority":100,"result":true}'
+      expect(JSON.stringify(ruleResult)).to.equal(expected)
+    })
+  })
 })

types/index.d.ts

@@ -155,7 +155,9 @@ export type RuleSerializable = Pick<
 
 export type RuleResultSerializable = Pick<
   Required<RuleResult>,
-  "name" | "conditions" | "event" | "priority" | "result">
+  "name" | "event" | "priority" | "result"> & {
+    conditions: TopLevelConditionResultSerializable
+  }
 
 export interface RuleResult {
   name: string;
@@ -229,6 +231,7 @@ type ConditionReference = {
   name?: string;
   priority?: number;
 };
+type ConditionReferenceResult = ConditionReference & BooleanConditionResultProperties
 export type TopLevelCondition =
   | AllConditions
   | AnyConditions
@@ -238,3 +241,9 @@ export type TopLevelConditionResult =
   | AllConditionsResult
   | AnyConditionsResult
   | NotConditionsResult
+  | ConditionReferenceResult
+export type TopLevelConditionResultSerializable =
+  | AllConditionsResult
+  | AnyConditionsResult
+  | NotConditionsResult
+  | ConditionReference