Fix return type of AbstractObject\Dao::getPermissions - related to pimcore#15778

dvesh3 · dvesh3 · commit c521787efb59 · 2023-08-21T10:02:35.000+02:00
diff --git a/models/DataObject/AbstractObject/Dao.php b/models/DataObject/AbstractObject/Dao.php
@@ -634,7 +634,7 @@ public function getPermissions($type, $user, $quote = true)
             $orderByType = $type ? ', `' . $type . '` DESC' : '';
             $permissions = $this->db->fetchAssociative('SELECT ' . $queryType . ' FROM users_workspaces_object WHERE cid IN (' . implode(',', $parentIds) . ') AND userId IN (' . implode(',', $userIds) . ') ORDER BY LENGTH(cpath) DESC, FIELD(userId, ' . $user->getId() . ') DESC' . $orderByType . ' LIMIT 1');
 
-            return $permissions;
+            return $permissions ?: null;
         } catch (\Exception $e) {
             Logger::warn('Unable to get permission ' . $type . ' for object ' . $this->model->getId());
         }

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,7 @@ public function getPermissions($type, $user, $quote = true)`
`634`	`634`	$orderByType = $type ? ', `' . $type . '` DESC' : '';
`635`	`635`	`$permissions = $this->db->fetchAssociative('SELECT ' . $queryType . ' FROM users_workspaces_object WHERE cid IN (' . implode(',', $parentIds) . ') AND userId IN (' . implode(',', $userIds) . ') ORDER BY LENGTH(cpath) DESC, FIELD(userId, ' . $user->getId() . ') DESC' . $orderByType . ' LIMIT 1');`
`636`	`636`
`637`		`- return $permissions;`
	`637`	`+ return $permissions ?: null;`
`638`	`638`	`} catch (\Exception $e) {`
`639`	`639`	`Logger::warn('Unable to get permission ' . $type . ' for object ' . $this->model->getId());`
`640`	`640`	`}`