Changed types so it will work on 8 bit controllers.

Precision will be less on 8 bit CPUs like Arduino UNO.

Author: CelliesProjects

MoonPhase.cpp

@@ -1,6 +1,7 @@
 #include "MoonPhase.h"
+#include <inttypes.h>
 
-MoonPhase::moonData MoonPhase::getInfo( const int year, const int month, const int day, const double hour )
+MoonPhase::moonData MoonPhase::getInfo( const int32_t year, const int32_t month, const int32_t day, const double hour )
 {
     /*
       Calculates the phase of the moon at the given epoch.
@@ -17,17 +18,17 @@ MoonPhase::moonData MoonPhase::getInfo( const int year, const int month, const i
   return returnValue;
 }
 
-double MoonPhase::_Julian( int year, int month, double day )
+double MoonPhase::_Julian( int32_t year, int32_t month, double day )
 {
-  int b, c, e;
+  int32_t b, c, e;
   b = 0;
   if (month < 3) {
     year--;
     month += 12;
   }
   if (year > 1582 || (year == 1582 && month > 10) ||
       (year == 1582 && month == 10 && day > 15)) {
-    int a;
+    int32_t a;
     a = year / 100;
     b = 2 - a + a / 4;
   }
@@ -39,7 +40,7 @@ double MoonPhase::_Julian( int year, int month, double day )
 double MoonPhase::_sun_position( const double j )
 {
   double n, x, e, l, dl, v;
-  int i;
+  int32_t i;
   n = 360 / 365.2422 * j;
   i = n / 360;
   n = n - i * 360.0;
@@ -61,7 +62,7 @@ double MoonPhase::_sun_position( const double j )
 double MoonPhase::_moon_position( double j, double ls )
 {
   double ms, l, mm, ev, sms, ae, ec;
-  int i;
+  int32_t i;
   ms = 0.985647332099 * j - 3.762863;
   if (ms < 0) ms += 360.0;
   l = 13.176396 * j + 64.975464;

MoonPhase.h

@@ -3,7 +3,7 @@
   and percentage illuminated. (as seen from Earth)
   Created by Marcel Timmer, April 28, 2018.
   Code adapted from http://www.voidware.com/phase.c
-  A big thanks to Hugh at voidware from granting permission.
+  A big thanks to Hugh at voidware for granting permission.
   Released under MIT license.
 */
 #ifndef MoonPhase_h
@@ -17,15 +17,15 @@ class MoonPhase
 
     struct moonData
     {
-      int angle;
-      float percentLit;
+      int32_t angle;
+      double percentLit;
     };
 
-    moonData getInfo( const int year, const int month, const int day, const double hour );
+    moonData getInfo( const int32_t year, const int32_t month, const int32_t day, const double hour );
 
   private:
 
-    double _Julian( int year, int month, double day );
+    double _Julian( int32_t year, int32_t month, double day );
 
     double _sun_position( const double j );
 

README.md

@@ -7,10 +7,10 @@ An Arduino library to get the moon phase angle and percentage of the moon that i
 1. Download the latest release and unpack in the Arduino `libraries` folder.
 2. Restart the Arduino IDE.
 
-A simple example that should run on most 16 and 32 bits Arduino supported boards is included.
+A simple example that should run on most Arduino IDE supported boards is included.
 
 A more elaborate example only suitable for an ESP32 with an ILI9341 tft display can be found in the `esp32/ILI9341` folder.
 
 ## Issues:
 
-This library will not work on most 8 bit Arduino boards, as these have no real `double` data type available.
+Precision will be smaller on 8 bit Arduino boards, as these have no real `double` data type available.