Skip to content

[ENG-9618] avoid creator.affiliationsAbsoluteUrl.includes(currentInstitutionId) checking to allow project contributor rendering for institutions #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feature/pbs-25.04
Choose a base branch
from
Draft

[ENG-9618] avoid creator.affiliationsAbsoluteUrl.includes(currentInstitutionId) checking to allow project contributor rendering for institutions #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/app/features/admin-institutions/mappers/creators.mapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getSortedContributorsByPermissions } from '@osf/shared/helpers/sort-contributors-by-permissions';
import { ResourceModel } from '@shared/models/search/resource.model';

export function mapCreators(project: ResourceModel, currentInstitutionId: string) {

Check failure on line 4 in src/app/features/admin-institutions/mappers/creators.mapper.ts

View workflow job for this annotation

GitHub Actions / lint 

'currentInstitutionId' is defined but never used. Allowed unused args must match /^_/u
const creatorsRoles = project.qualifiedAttribution.map((qa) => {
let role;
if (qa.hadRole.includes('admin')) {
Expand All @@ -18,7 +18,6 @@
});

return getSortedContributorsByPermissions(project)
?.filter((creator) => creator.affiliationsAbsoluteUrl.includes(currentInstitutionId))
?.map((creator) => {
const name = creator.name.trim();
const role = creatorsRoles.find((cr) => cr.id === creator.absoluteUrl)!.role;
Expand Down
Loading