Merge branch 'main' into edge_line_unique_VAO

Author: ggetz

Apps/Sandcastle/gallery/Custom DataSource.html

@@ -64,7 +64,7 @@
           /**
            * Gets a human-readable name for this instance.
            * @memberof WebGLGlobeDataSource.prototype
-           * @type {String}
+           * @type {string}
            */
           name: {
             get: function () {
@@ -93,7 +93,7 @@
           /**
            * Gets a value indicating if the data source is currently loading data.
            * @memberof WebGLGlobeDataSource.prototype
-           * @type {Boolean}
+           * @type {boolean}
            */
           isLoading: {
             get: function () {
@@ -150,7 +150,7 @@
            * so that only one series is viewed at a time.  Valid values are defined
            * in the seriesNames property.
            * @memberof WebGLGlobeDataSource.prototype
-           * @type {String}
+           * @type {string}
            */
           seriesToDisplay: {
             get: function () {
@@ -174,7 +174,7 @@
           /**
            * Gets or sets the scale factor applied to the height of each line.
            * @memberof WebGLGlobeDataSource.prototype
-           * @type {Number}
+           * @type {number}
            */
           heightScale: {
             get: function () {
@@ -190,7 +190,7 @@
           /**
            * Gets whether or not this data source should be displayed.
            * @memberof WebGLGlobeDataSource.prototype
-           * @type {Boolean}
+           * @type {boolean}
            */
           show: {
             get: function () {

CHANGES.md

@@ -25,6 +25,7 @@
 - Improved performance of `scene.drillPick`. [#12916](https://github.com/CesiumGS/cesium/pull/12916)
 - Improved performance when removing primitives. [#3018](https://github.com/CesiumGS/cesium/pull/3018)
 - Improved performance of terrain Quadtree handling of custom data [#12907](https://github.com/CesiumGS/cesium/pull/12907)
+- Fixed picking of `GroundPrimitive` with multiple `PolygonGeometry` instances selecting the wrong instance. [#12978](https://github.com/CesiumGS/cesium/pull/12978)
 
 ## 1.134.1 - 2025-10-10
 

packages/engine/Source/Core/ArcGISTiledElevationTerrainProvider.js

@@ -22,7 +22,7 @@ import WebMercatorTilingScheme from "./WebMercatorTilingScheme.js";
 const ALL_CHILDREN = 15;
 
 /**
- * @typedef {Object} ArcGISTiledElevationTerrainProvider.ConstructorOptions
+ * @typedef {object} ArcGISTiledElevationTerrainProvider.ConstructorOptions
  *
  * Initialization options for the ArcGISTiledElevationTerrainProvider constructor
  *
@@ -339,7 +339,7 @@ Object.defineProperties(ArcGISTiledElevationTerrainProvider.prototype, {
  * Creates a {@link TerrainProvider} that produces terrain geometry by tessellating height maps
  * retrieved from Elevation Tiles of an an ArcGIS ImageService.
  *
- * @param {Resource|String|Promise<Resource>|Promise<String>} url The URL of the ArcGIS ImageServer service.
+ * @param {Resource|string|Promise<Resource>|Promise<string>} url The URL of the ArcGIS ImageServer service.
  * @param {ArcGISTiledElevationTerrainProvider.ConstructorOptions} [options] A url or an object describing initialization options.
  * @returns {Promise<ArcGISTiledElevationTerrainProvider>}
  *

packages/engine/Source/Core/CesiumTerrainProvider.js

@@ -39,7 +39,7 @@ function LayerInformation(layer) {
 }
 
 /**
- * @typedef {Object} CesiumTerrainProvider.ConstructorOptions
+ * @typedef {object} CesiumTerrainProvider.ConstructorOptions
  *
  * Initialization options for the CesiumTerrainProvider constructor
  *
@@ -1198,7 +1198,7 @@ CesiumTerrainProvider.fromIonAssetId = async function (assetId, options) {
  * <li> {@link https://github.com/AnalyticalGraphicsInc/cesium/wiki/heightmap-1.0 Height Map} </li>
  * </ul>
  *
- * @param {Resource|String|Promise<Resource>|Promise<String>} url The URL of the Cesium terrain server.
+ * @param {Resource|string|Promise<Resource>|Promise<string>} url The URL of the Cesium terrain server.
  * @param {CesiumTerrainProvider.ConstructorOptions} [options] An object describing initialization options.
  * @returns {Promise<CesiumTerrainProvider>}
  *

packages/engine/Source/Core/EllipsoidalOccluder.js

@@ -247,7 +247,7 @@ EllipsoidalOccluder.prototype.computeHorizonCullingPointPossiblyUnderEllipsoid =
  *                     A reasonable direction to use is the direction from the center of the ellipsoid to
  *                     the center of the bounding sphere computed from the positions.  The direction need not
  *                     be normalized.
- * @param {number[]} vertices  The vertices from which to compute the horizon culling point.  The positions
+ * @param {number[]|Float32Array|Float64Array} vertices  The vertices from which to compute the horizon culling point. The positions
  *                   must be expressed in a reference frame centered at the ellipsoid and aligned with the
  *                   ellipsoid's axes.
  * @param {number} [stride=3]
@@ -277,7 +277,7 @@ EllipsoidalOccluder.prototype.computeHorizonCullingPointFromVertices =
  *                     A reasonable direction to use is the direction from the center of the ellipsoid to
  *                     the center of the bounding sphere computed from the positions.  The direction need not
  *                     be normalized.
- * @param {number[]} vertices  The vertices from which to compute the horizon culling point.  The positions
+ * @param {number[]|Float32Array|Float64Array} vertices  The vertices from which to compute the horizon culling point.  The positions
  *                   must be expressed in a reference frame centered at the ellipsoid and aligned with the
  *                   ellipsoid's axes.
  * @param {number} [stride=3]

packages/engine/Source/Core/GoogleEarthEnterpriseMetadata.js

@@ -140,7 +140,7 @@ Object.defineProperties(GoogleEarthEnterpriseMetadata.prototype, {
  * Creates a metadata object using the Google Earth Enterprise REST API. This is used by the GoogleEarthEnterpriseImageryProvider
  * and GoogleEarthEnterpriseTerrainProvider to share metadata requests.
  *
- * @param {Resource|String} resourceOrUrl The url of the Google Earth Enterprise server hosting the imagery.
+ * @param {Resource|string} resourceOrUrl The url of the Google Earth Enterprise server hosting the imagery.
  *
  * @returns {Promise<GoogleEarthEnterpriseMetadata>} A promise which resolves to the created GoogleEarthEnterpriseMetadata instance/
  */

packages/engine/Source/Core/GoogleEarthEnterpriseTerrainData.js

@@ -380,7 +380,7 @@ GoogleEarthEnterpriseTerrainData.prototype.upsample = function (
 
 /**
  * Determines if a given child tile is available, based on the
- * {@link HeightmapTerrainData.childTileMask}.  The given child tile coordinates are assumed
+ * {@link GoogleEarthEnterpriseTerrainData.childTileMask}.  The given child tile coordinates are assumed
  * to be one of the four children of this tile.  If non-child tile coordinates are
  * given, the availability of the southeast child tile is returned.
  *

packages/engine/Source/Core/GoogleEarthEnterpriseTerrainProvider.js

@@ -65,7 +65,7 @@ TerrainCache.prototype.tidy = function () {
 };
 
 /**
- * @typedef {Object} GoogleEarthEnterpriseTerrainProvider.ConstructorOptions
+ * @typedef {object} GoogleEarthEnterpriseTerrainProvider.ConstructorOptions
  *
  * Initialization options for GoogleEarthEnterpriseTerrainProvider constructor
  *

packages/engine/Source/Core/ITwinPlatform.js

@@ -114,21 +114,21 @@ ITwinPlatform.apiEndpoint = new Resource({
 });
 
 /**
- * @typedef {Object} ExportRequest
+ * @typedef {object} ExportRequest
  * @private
  * @property {string} iModelId
  * @property {string} changesetId
  * @property {ITwinPlatform.ExportType} exportType Type of the export. CesiumJS only supports the 3DTILES type
  */
 
 /**
- * @typedef {Object} Link
+ * @typedef {object} Link
  * @private
  * @property {string} href
  */
 
 /**
- * @typedef {Object} ExportRepresentation
+ * @typedef {object} ExportRepresentation
  * The export objects from get-exports when using return=representation
  * @private
  * @property {string} id Export id
@@ -140,7 +140,7 @@ ITwinPlatform.apiEndpoint = new Resource({
  */
 
 /**
- * @typedef {Object} GetExportsResponse
+ * @typedef {object} GetExportsResponse
  * @private
  * @property {ExportRepresentation[]} exports The list of exports for the current page
  * @property {{self: Link, next: Link | undefined, prev: Link | undefined}} _links Pagination links
@@ -224,14 +224,14 @@ ITwinPlatform.getExports = async function (iModelId, changesetId) {
 };
 
 /**
- * @typedef {Object} RealityDataExtent
+ * @typedef {object} RealityDataExtent
  * @private
  * @property {{latitude: number, longitude: number}} southWest
  * @property {{latitude: number, longitude: number}} northEast
  */
 
 /**
- * @typedef {Object} RealityDataRepresentation
+ * @typedef {object} RealityDataRepresentation
  * @private
  * @property {string} id "95d8dccd-d89e-4287-bb5f-3219acbc71ae",
  * @property {string} displayName "Name of reality data",

packages/engine/Source/Core/PixelFormat.js

@@ -464,8 +464,8 @@ PixelFormat.alignmentInBytes = function (pixelFormat, pixelDatatype, width) {
  * @private
  * @param {PixelFormat} pixelFormat The pixel format.
  * @param {PixelDatatype} pixelDatatype The pixel datatype.
- * @param {Number} width The width of the texture.
- * @param {Number} height The height of the texture.
+ * @param {number} width The width of the texture.
+ * @param {number} height The height of the texture.
  * @returns {TypedArray} The typed array.
  */
 PixelFormat.createTypedArray = function (