Merge rust-bitcoin/rust-bitcoin#1146: Remove needless allocation from BIP-158 encoding

1003ca0 Remove needless allocation from BIP-158 encoding (Martin Habovstiak)

Pull request description:

  The BIP-158 finalize code was serializing value to `Vec` only to
  serialize it to writer right away. Thus the intermediary `Vec` was not
  needed.

  Even more, the code used `write` which, while correct in case of `Vec`,
  could trigger code analysis tools or reviewers.

ACKs for top commit:
  tcharding:
    ACK 1003ca0
  sanket1729:
    ACK 1003ca0
  apoelstra:
    ACK 1003ca0

Tree-SHA512: 01e198726f45ef1b0e4bbe80154674d9db12350281e682531259d1d6467881bc7503cfed30d3837813437c3081a35ba7893c3ae4490d07daf20f1b75dbc62d52

Author: apoelstra

src/util/bip158.rs

@@ -364,9 +364,7 @@ impl<'a> GCSFilterWriter<'a> {
         mapped.sort_unstable();
 
         // write number of elements as varint
-        let mut encoder = Vec::new();
-        VarInt(mapped.len() as u64).consensus_encode(&mut encoder).expect("in-memory writers don't error");
-        let mut wrote = self.writer.write(encoder.as_slice())?;
+        let mut wrote = VarInt(mapped.len() as u64).consensus_encode(&mut self.writer)?;
 
         // write out deltas of sorted values into a Golonb-Rice coded bit stream
         let mut writer = BitStreamWriter::new(self.writer);