Skip to content

Commit 2df673c

Browse files
committed
[update] support stopload as required in Chimeejs/chimee#70
1 parent 81d7d8a commit 2df673c

File tree

6 files changed

+48
-28
lines changed

6 files changed

+48
-28
lines changed

build/rollup.config.base.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,17 +127,21 @@ export default function(mode) {
127127
plugins: [
128128
babel(babelConfig[mode]),
129129
flow(),
130-
resolve({
131-
customResolveOptions: {
132-
moduleDirectory: [ 'src', 'node_modules' ],
133-
},
134-
preferBuiltins: true,
135-
}),
136130
commonjs(),
137131
replace({
138132
'process.env.VERSION': `'${version}'`,
139133
}),
140134
builtins(),
141-
],
135+
].concat(/min|umd|iife/.test(mode)
136+
? [
137+
resolve({
138+
customResolveOptions: {
139+
moduleDirectory: [ 'src', 'node_modules' ],
140+
},
141+
preferBuiltins: true,
142+
}),
143+
]
144+
: []
145+
),
142146
};
143147
}

demo/base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ window.start = function() {
3232

3333
document.body.appendChild(srcController);
3434

35-
const keys = [ 'play', 'pause', 'load', 'attachMedia', 'seek', 'refresh', 'destroy' ];
35+
const keys = [ 'play', 'pause', 'load', 'stopLoad', 'startLoad', 'attachMedia', 'seek', 'refresh', 'destroy' ];
3636
const controller = document.createElement('div');
3737
keys.forEach(function(key) {
3838
const button = document.createElement('button');

karma.conf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ module.exports = function(config) {
2828
// test results reporter to use
2929
// possible values: 'dots', 'progress'
3030
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
31-
reporters: [ 'mocha', 'coverage-istanbul', 'progress', 'coverage' ],
31+
reporters: [ 'mocha', 'coverage-istanbul', 'progress', 'coverage', 'coveralls' ],
3232

3333
coverageIstanbulReporter: {
3434
reports: [ 'lcov', 'text-summary' ],
3535
},
3636

3737
coverageReporter: {
38-
type: 'html',
38+
type: 'lcov',
3939
dir: 'coverage/',
4040
},
4141

package.json

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@
3030
"dependencies": {
3131
"babel-runtime": "^6.26.0",
3232
"chimee-helper": "^0.2.10",
33-
"flv.js": "^1.4.0"
33+
"flv.js": "^1.4.0",
34+
"toxic-decorators": "^0.3.8"
3435
},
3536
"devDependencies": {
3637
"babel-core": "^6.26.0",
37-
"babel-eslint": "^8.1.2",
38+
"babel-eslint": "^8.2.1",
3839
"babel-plugin-istanbul": "^4.1.5",
3940
"babel-plugin-transform-decorators-legacy": "^1.3.4",
4041
"babel-plugin-transform-runtime": "^6.23.0",
@@ -44,36 +45,36 @@
4445
"babel-preset-latest": "^6.24.1",
4546
"babel-preset-stage-0": "^6.24.1",
4647
"chai": "^4.1.2",
47-
"chimee-kernel": "^1.3.2",
48-
"eslint": "^4.0.0",
48+
"chimee-kernel": "^1.4.0",
49+
"eslint": "^4.15.0",
4950
"eslint-config-egg": "^6.0.0",
50-
"eslint-plugin-flowtype": "^2.34.0",
51-
"flow-bin": "^0.62.0",
51+
"eslint-plugin-flowtype": "^2.41.0",
52+
"flow-bin": "^0.63.1",
5253
"flowgen": "^1.2.0",
5354
"husky": "^0.14.3",
5455
"karma": "^2.0.0",
5556
"karma-coverage": "^1.1.1",
5657
"karma-coverage-istanbul-reporter": "^1.3.3",
58+
"karma-coveralls": "^1.1.2",
5759
"karma-firefox-launcher": "^1.1.0",
5860
"karma-mocha": "^1.3.0",
5961
"karma-mocha-reporter": "^2.2.5",
60-
"karma-rollup-preprocessor": "^5.0.3",
62+
"karma-rollup-preprocessor": "^5.1.1",
6163
"karma-sourcemap-loader": "^0.3.7",
62-
"mocha": "^4.1.0",
64+
"mocha": "^5.0.0",
6365
"pkg-ok": "^1.1.0",
64-
"rollup": "^0.53.3",
66+
"rollup": "^0.54.1",
6567
"rollup-plugin-babel": "^3.0.2",
6668
"rollup-plugin-commonjs": "^8.0.2",
6769
"rollup-plugin-flow-no-whitespace": "^1.0.0",
6870
"rollup-plugin-includepaths": "^0.2.2",
6971
"rollup-plugin-livereload": "^0.6.0",
7072
"rollup-plugin-node-builtins": "^2.1.2",
71-
"rollup-plugin-node-resolve": "^3.0.0",
73+
"rollup-plugin-node-resolve": "^3.0.2",
7274
"rollup-plugin-replace": "^2.0.0",
7375
"rollup-plugin-serve": "^0.4.0",
7476
"rollup-plugin-uglify": "^2.0.1",
7577
"rollup-watch": "^4.3.1",
76-
"toxic-decorators": "^0.3.8",
77-
"uglify-es": "^3.3.4"
78+
"uglify-es": "^3.3.7"
7879
}
7980
}

src/index.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,16 @@ export default class Flv extends CustEvent {
6464
return this.flvKernel.load();
6565
}
6666

67+
stopLoad() {
68+
return this.flvKernel.unload();
69+
}
70+
6771
attachMedia() {
6872
return this.flvKernel.attachMediaElement(this.video);
6973
}
7074

7175
play() {
72-
return this.video.play();
76+
return this.flvKernel.play();
7377
}
7478

7579
destroy() {
@@ -79,11 +83,11 @@ export default class Flv extends CustEvent {
7983
}
8084

8185
seek(seconds: number) {
82-
this.video.currentTime = seconds;
86+
this.flvKernel.currentTime = seconds;
8387
}
8488

8589
pause() {
86-
return this.video.pause();
90+
return this.flvKernel.pause();
8791
}
8892

8993
refresh() {

tests/index.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,14 @@ describe('method it', () => {
7171
expect(kernel.config.src).to.equal(config.src);
7272
expect(kernel.video.src).to.equal(videoSrc);
7373
});
74-
it('seek', () => {
74+
it('seek', async () => {
7575
expect(kernel.video.currentTime).to.equal(0);
7676
kernel.load();
7777
expect(kernel.video.currentTime).to.equal(0);
78-
kernel.seek(10);
79-
expect(kernel.video.currentTime).to.equal(10);
78+
await new Promise(resolve => setTimeout(resolve, 500));
79+
expect(() => {
80+
kernel.seek(10);
81+
}).not.to.throw();
8082
});
8183
it('play & pause', () => {
8284
expect(() => {
@@ -86,6 +88,15 @@ describe('method it', () => {
8688
kernel.pause();
8789
}).not.to.throw();
8890
});
91+
it('load & stopLoad', () => {
92+
expect(() => {
93+
kernel.attachMedia();
94+
kernel.load();
95+
kernel.play();
96+
kernel.pause();
97+
kernel.stopLoad();
98+
}).not.to.throw();
99+
});
89100
});
90101

91102
describe('error branch', () => {

0 commit comments

Comments
 (0)