Bad generation for oneof

[gurgl]

Describe the bug
Seems all "oneof" leads to code generation containing invokations of unimplemented method "validateJsonElement"

To Reproduce
Generate an api from a spec containing oneof

Expected behavior
just works

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context & Versions used
Add any other context about the problem here.

[Chrimle]

Hi @gurgl ! Thank you for the bug report!

I assume that generateSupportingFiles is set to true? Technically it is out-of-scope based on the currently supported features:

• https://github.com/Chrimle/openapi-to-java-records-mustache-templates/wiki/Supported-%27openapi‐generator‐maven‐plugin%27-Configuration-options
• https://github.com/Chrimle/openapi-to-java-records-mustache-templates/wiki/Supported-OpenAPI-Specification-properties

With #372 it MAY be in scope, but generateSupportingFiles would likely be a blocker to resolve and verify...

[gurgl]

Hello. Thanks for looking into this. No, actually I'm using this configuation (also tried with 7.12.0).. and 2.7.0 for your templates

            <plugin>
                <groupId>org.openapitools</groupId>
                <artifactId>openapi-generator-maven-plugin</artifactId>
                <version>7.8.0</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>generate</goal>
                        </goals>
                        <configuration>
                            <inputSpec>path/to/openapi.json</inputSpec>
                            <generatorName>java</generatorName>
                            <templateDirectory>${project.build.directory}/openapi-codegen-templates/templates</templateDirectory>
                            <skipValidateSpec>true</skipValidateSpec>
                            <configOptions>
                                <sourceFolder>src/gen/java/main</sourceFolder>
                            </configOptions>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

[Chrimle]

Thank you for the added context!

The config generateSupportingFiles is enabled by default, by openapi-generator-maven-plugin.

The test suite for openapi-to-java-records-mustache-templates always has this config set to false. (To not give the false impression that it is tested and supported).

[gurgl]

Seems generateSupportingFiles true/false makes no differfence regarding if that "validateJsonElement` invokation is made or not.

[Chrimle]

Thanks for checking, then it's "only" a matter of overriding oneof_model.mustache.

[Chrimle]

Correction: The changes needed will hopefully only require changes to the pojo.mustache file. Since the provided pom.xml does not set <library>, it will be assumed that this issue is related to okhttp-gson and will only be fixed for okhttp-gson (for now).

[Chrimle]

So, good news and bad news.

The issue that you encountered will be resolved by #375 . It will be a hassle to verify, but it will be tested on a template-level. Once that PR is no longer a draft, you can try it out locally.

However, that PR will only address the GSON-related issues and will only add the validateJsonElement method. This does not cover the oneOf at all. I've had a quick look at it, and it seems that oneOf requires the generateSupportingFiles to be true. Considering that the initial issue was related to gson, there is now a library-context in the test suite - which complicates this further. It seems that gson/webclient will use the same dependencies, but with different versions... So, the test and verification of oneOf is blocked by #348