fix build

Author: OrKoN

.github/workflows/run-tests.yml

@@ -42,6 +42,8 @@ jobs:
 
       - name: Build
         run: npm run bundle
+        env:
+          NODE_OPTIONS: '--max_old_space_size=4096'
 
       - name: Set up Node.js
         uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
@@ -62,7 +64,7 @@ jobs:
       - name: Run tests
         shell: bash
         if: ${{ matrix.node != '20' }}
-        run: npm run test
+        run: npm run test:no-build
 
   # Gating job for branch protection.
   test-success:

package.json

@@ -7,7 +7,7 @@
   "main": "index.js",
   "scripts": {
     "clean": "node -e \"require('fs').rmSync('build', {recursive: true, force: true})\"",
-    "bundle": "npm run clean && npm run build && rollup -c rollup.config.mjs",
+    "bundle": "npm run clean && npm run build && rollup -c rollup.config.mjs && node -e \"require('fs').rmSync('build/node_modules', {recursive: true, force: true})\"",
     "build": "tsc && node --experimental-strip-types --no-warnings=ExperimentalWarning scripts/post-build.ts",
     "typecheck": "tsc --noEmit",
     "format": "eslint --cache --fix . && prettier --write --cache .",
@@ -16,11 +16,12 @@
     "docs:generate": "node --experimental-strip-types scripts/generate-docs.ts",
     "start": "npm run build && node build/src/index.js",
     "start-debug": "DEBUG=mcp:* DEBUG_COLORS=false npm run build && node build/src/index.js",
-    "test:node20": "node --require ./build/tests/setup.js --test-reporter spec --test-force-exit --test build/tests",
-    "test": "npm run build && node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --experimental-print-required-tla --test-reporter spec --test-force-exit --test \"build/tests/**/*.test.js\"",
-    "test:only": "npm run build && node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-reporter spec --test-force-exit --test --test-only \"build/tests/**/*.test.js\"",
-    "test:only:no-build": "node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-reporter spec --test-force-exit --test --test-only \"build/tests/**/*.test.js\"",
-    "test:update-snapshots": "npm run build && node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-force-exit --test --test-update-snapshots \"build/tests/**/*.test.js\"",
+    "test:node20": "node --import ./build/tests/setup.js --test-reporter spec --test-force-exit --test build/tests",
+    "test:no-build": "node --import ./build/tests/setup.js --no-warnings=ExperimentalWarning --experimental-print-required-tla --test-reporter spec --test-force-exit --test \"build/tests/**/*.test.js\"",
+    "test": "npm run build && npm run test:no-build",
+    "test:only": "npm run build && node --import ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-reporter spec --test-force-exit --test --test-only \"build/tests/**/*.test.js\"",
+    "test:only:no-build": "node --import ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-reporter spec --test-force-exit --test --test-only \"build/tests/**/*.test.js\"",
+    "test:update-snapshots": "npm run build && node --import ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-force-exit --test --test-update-snapshots \"build/tests/**/*.test.js\"",
     "prepare": "node --experimental-strip-types scripts/prepare.ts",
     "verify-server-json-version": "node --experimental-strip-types scripts/verify-server-json-version.ts"
   },

rollup.config.mjs

@@ -19,8 +19,8 @@
  * and modified to specific requirement.
  */
 
-import path from 'node:path';
 import fs from 'node:fs';
+import path from 'node:path';
 
 import commonjs from '@rollup/plugin-commonjs';
 import json from '@rollup/plugin-json';
@@ -80,7 +80,7 @@ const bundleDependency = (
             'THIRD_PARTY_NOTICES',
           ),
           template(dependencies) {
-            const stringified_dependencies = dependencies.map(dependency => {
+            const stringifiedDependencies = dependencies.map(dependency => {
               let arr = [];
               arr.push(`Name: ${dependency.name ?? 'N/A'}`);
               let url = dependency.homepage ?? dependency.repository;
@@ -98,36 +98,58 @@ const bundleDependency = (
             });
 
             // Manual license handling for chrome-devtools-frontend third_party
-            const tsConfig = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'tsconfig.json'), 'utf-8'));
-             const thirdPartyDirectories = tsConfig.include.filter(location => {
-              return location.includes(
+            const tsConfig = JSON.parse(
+              fs.readFileSync(
+                path.join(process.cwd(), 'tsconfig.json'),
+                'utf-8',
+              ),
+            );
+            const thirdPartyDirectories = tsConfig.include.filter(location =>
+              location.includes(
                 'node_modules/chrome-devtools-frontend/front_end/third_party',
-              );
-            });
+              ),
+            );
 
             const manualLicenses = [];
             // Add chrome-devtools-frontend main license
-            const cdtfLicensePath = path.join(process.cwd(), 'node_modules/chrome-devtools-frontend/LICENSE');
+            const cdtfLicensePath = path.join(
+              process.cwd(),
+              'node_modules/chrome-devtools-frontend/LICENSE',
+            );
             if (fs.existsSync(cdtfLicensePath)) {
-              manualLicenses.push(['Name: chrome-devtools-frontend', 'License: Apache-2.0', '', fs.readFileSync(cdtfLicensePath, 'utf-8')].join('\n'));
+              manualLicenses.push(
+                [
+                  'Name: chrome-devtools-frontend',
+                  'License: Apache-2.0',
+                  '',
+                  fs.readFileSync(cdtfLicensePath, 'utf-8'),
+                ].join('\n'),
+              );
             }
 
             for (const thirdPartyDir of thirdPartyDirectories) {
               const fullPath = path.join(process.cwd(), thirdPartyDir);
               const licenseFile = path.join(fullPath, 'LICENSE');
               if (fs.existsSync(licenseFile)) {
-                 const name = path.basename(thirdPartyDir);
-                 manualLicenses.push([`Name: ${name}`, `License: Custom`, '', fs.readFileSync(licenseFile, 'utf-8').replaceAll('\r', '')].join('\n'));
+                const name = path.basename(thirdPartyDir);
+                manualLicenses.push(
+                  [
+                    `Name: ${name}`,
+                    `License:`,
+                    '',
+                    fs.readFileSync(licenseFile, 'utf-8').replaceAll('\r', ''),
+                  ].join('\n'),
+                );
               }
             }
-            
+
             if (manualLicenses.length > 0) {
-              stringified_dependencies.push(...manualLicenses);
+              stringifiedDependencies.push(...manualLicenses);
             }
 
             const divider =
               '\n\n-------------------- DEPENDENCY DIVIDER --------------------\n\n';
-            return stringified_dependencies.join(divider);
+            return stringifiedDependencies.join(divider);
           },
         },
       },

scripts/post-build.ts

@@ -20,7 +20,6 @@ function writeFile(filePath: string, content: string): void {
   fs.writeFileSync(filePath, content, 'utf-8');
 }
 
-
 function main(): void {
   const devtoolsThirdPartyPath =
     'node_modules/chrome-devtools-frontend/front_end/third_party';
@@ -96,7 +95,12 @@ function copyDevToolsDescriptionFiles() {
   const devtoolsIssuesDescriptionPath =
     'node_modules/chrome-devtools-frontend/front_end/models/issues_manager/descriptions';
   const sourceDir = path.join(process.cwd(), devtoolsIssuesDescriptionPath);
-  const destDir = path.join(BUILD_DIR, devtoolsIssuesDescriptionPath);
+  const destDir = path.join(
+    BUILD_DIR,
+    'src',
+    'third_party',
+    'issue-descriptions',
+  );
   fs.cpSync(sourceDir, destDir, {recursive: true});
 }
 

src/issue-descriptions.ts

@@ -9,7 +9,7 @@ import * as path from 'node:path';
 
 const DESCRIPTIONS_PATH = path.join(
   import.meta.dirname,
-  '../node_modules/chrome-devtools-frontend/front_end/models/issues_manager/descriptions',
+  'third_party/issue-descriptions',
 );
 
 let issueDescriptions: Record<string, string> = {};

src/third_party/index.ts

@@ -41,10 +41,6 @@ export {
   TraceEngine,
   PerformanceTraceFormatter,
   PerformanceInsightFormatter,
-  // Issue is a type in some contexts, but let's export it as is if it's a class or if we can use export type?
-  // Use export type for pure types if possible, or just export { ... }
-  // The users act as if they are values (classes) mostly, except explicit type imports.
-  // Re-exporting everything as value allows both (if they are values).
   AggregatedIssue,
   type Issue,
   type IssuesManagerEventTypes,

tests/DevtoolsUtils.test.ts

@@ -9,17 +9,14 @@ import {afterEach, describe, it} from 'node:test';
 
 import sinon from 'sinon';
 
-import {
-  AggregatedIssue,
-  DebuggerModel,
-} from '../node_modules/chrome-devtools-frontend/mcp/mcp.js';
 import {
   extractUrlLikeFromDevToolsTitle,
   urlsEqual,
   mapIssueToMessageObject,
   UniverseManager,
 } from '../src/DevtoolsUtils.js';
 import {ISSUE_UTILS} from '../src/issue-descriptions.js';
+import {AggregatedIssue, DebuggerModel} from '../src/third_party/index.js';
 import type {Browser, Target} from '../src/third_party/index.js';
 
 import {

tests/PageCollector.test.ts

@@ -10,13 +10,13 @@ import {beforeEach, describe, it} from 'node:test';
 import type {Frame, HTTPRequest, Target, Protocol} from 'puppeteer-core';
 import sinon from 'sinon';
 
-import {AggregatedIssue} from '../node_modules/chrome-devtools-frontend/mcp/mcp.js';
 import type {ListenerMap} from '../src/PageCollector.js';
 import {
   ConsoleCollector,
   NetworkCollector,
   PageCollector,
 } from '../src/PageCollector.js';
+import {AggregatedIssue} from '../src/third_party/index.js';
 
 import {getMockRequest, getMockBrowser} from './utils.js';
 

tests/setup.ts

@@ -20,7 +20,7 @@ if (!it.snapshot) {
   };
 }
 
-// This is run by Node when we execute the tests via the --require flag.
+// This is run by Node when we execute the tests via the --import flag.
 it.snapshot.setResolveSnapshotPath(testPath => {
   // By default the snapshots go into the build directory, but we want them
   // in the tests/ directory.

tests/tools/console.test.ts

@@ -7,9 +7,9 @@
 import assert from 'node:assert';
 import {before, describe, it} from 'node:test';
 
-import {AggregatedIssue} from '../../node_modules/chrome-devtools-frontend/mcp/mcp.js';
 import {loadIssueDescriptions} from '../../src/issue-descriptions.js';
 import {McpResponse} from '../../src/McpResponse.js';
+import {AggregatedIssue} from '../../src/third_party/index.js';
 import {
   getConsoleMessage,
   listConsoleMessages,