Merge pull request #147 from CiscoTestAutomation/ise_rest

updated better logging for ise rest connector

Author: lsheikal

.github/workflows/run_tests.yml

@@ -14,7 +14,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12']
 
     steps:
     - uses: actions/checkout@v2

docs/changelog/undistributed/changelogs_lsheikal_rest_logging_20250327190128.rst

@@ -0,0 +1,6 @@
+--------------------------------------------------------------------------------
+                                New
+--------------------------------------------------------------------------------
+* ise
+    * Modified connect
+        * added better logging for ise.

docs/changelog/undistributed/template.rst

@@ -0,0 +1,30 @@
+Only one changelog file per pull request. Combine these two templates where applicable.
+
+Templates
+=========
+
+--------------------------------------------------------------------------------
+                                New
+--------------------------------------------------------------------------------
+* <Module>
+    * <Added|Modified> <Class>:
+        * <Explanation>
+
+--------------------------------------------------------------------------------
+                                Fix
+--------------------------------------------------------------------------------
+* <Module>
+    * <Added|Modified|Removed> <Class>:
+        * <Explanation>
+
+Examples
+========
+
+--------------------------------------------------------------------------------
+                            New
+--------------------------------------------------------------------------------
+* feature
+    * Modified Connect:
+        * Change var to variable
+        * Updated regex pattern <p1> to accommodate various outputs.
+        * Added keys <key3>, <key4> into the schema.

src/rest/connector/libs/ise/implementation.py

@@ -119,7 +119,13 @@ def connect(self,
             version_info = version_request.response
             # {'OperationResult': {'resultValue': [
             # {'value': '3.3.0.430', 'name': 'version'}, {'value': '0', 'name': 'patch information'}]}}
-            version_info_list = version_info.get('OperationResult', {}).get('resultValue', [])
+            # Check if version_info is a dictionary
+            if isinstance(version_info, dict):
+                # Proceed with accessing the version information
+                version_info_list = version_info.get('OperationResult', {}).get('resultValue', [])
+            else:
+                # Raise an appropriate error if version_info is not a dictionary
+                raise TypeError(f"Expected version_info to be a dictionary, but received {version_info}")
             version_message_list = []
             for version_nv in version_info_list:
                 name = version_nv.get('name')