actually start / stop the service

Author: Jan Wilmans

application/DebugViewpp/MainFrame.cpp

@@ -1517,7 +1517,7 @@ void CMainFrame::OnLogGlobal(UINT /*uNotifyCode*/, int /*nID*/, CWindow /*wndCtl
     UpdateTitle();
 }
 
-static const auto driver_name = "dbgv.sys";
+static const auto driver_name = "C:\\Windows\\System32\\drivers\\dbgvpp.sys";
 
 void WriteDriverFromResource()
 {
@@ -1535,6 +1535,7 @@ void WriteDriverFromResource()
             void* pLockedRes = LockResource(hLoadedRes);
             if (pLockedRes)
             {
+                std::cout << "write to " << driver_name << "\n";
                 std::ofstream outFile(driver_name, std::ios::binary);
                 outFile.write(static_cast<const char*>(pLockedRes), dwSize);
                 outFile.close();

application/DebugViewppLib/Debugview_kernel_client.cpp

@@ -7,13 +7,76 @@
 
 constexpr const char* DRIVER_SERVICE_NAME = "debugviewdriver";
 constexpr const char* DRIVER_DISPLAY_NAME = "DbgView Kernel Message Driver";
-const std::string driverPath = "dbgv.sys";
+const std::string driverPath = "C:\\Windows\\System32\\drivers\\dbgvpp.sys";
+
+bool FileExists(const std::string& path) {
+    DWORD fileAttributes = GetFileAttributesA(path.c_str());
+    return (fileAttributes != INVALID_FILE_ATTRIBUTES &&
+        !(fileAttributes & FILE_ATTRIBUTE_DIRECTORY));
+}
+
+bool StartDriverSvc()
+{
+    SC_HANDLE hSCManager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
+    if (!hSCManager) return false;
+
+    SC_HANDLE hService = OpenServiceA(hSCManager, DRIVER_SERVICE_NAME, SERVICE_START);
+    if (!hService) {
+        CloseServiceHandle(hSCManager);
+        return false;
+    }
+
+    if (!StartService(hService, 0, NULL)) {
+        if (GetLastError() == ERROR_SERVICE_ALREADY_RUNNING) {
+            std::cout << "Service is already running.\n";
+            CloseServiceHandle(hService);
+            CloseServiceHandle(hSCManager);
+            return true;
+        }
+        std::cout << "Failed to start service. Error: " << GetLastError() << std::endl;
+        CloseServiceHandle(hService);
+        CloseServiceHandle(hSCManager);
+        return false;
+    }
+
+    CloseServiceHandle(hService);
+    CloseServiceHandle(hSCManager);
+    return true;
+}
+
+bool StopDriverSvc()
+{
+    SC_HANDLE hSCManager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
+    if (!hSCManager) return false;
+
+    SC_HANDLE hService = OpenServiceA(hSCManager, DRIVER_SERVICE_NAME, SERVICE_STOP);
+    if (!hService) {
+        CloseServiceHandle(hSCManager);
+        return false;
+    }
+
+    SERVICE_STATUS status;
+    if (!ControlService(hService, SERVICE_CONTROL_STOP, &status)) {
+        DWORD err = GetLastError();
+        if (err != ERROR_SERVICE_NOT_ACTIVE) {
+            std::cout << "Failed to stop service. Error: " << err << std::endl;
+        }
+    }
+
+    CloseServiceHandle(hService);
+    CloseServiceHandle(hSCManager);
+    return true;
+}
 
 void InstallKernelMessagesDriver()
 {
     // try to uninstall first, in case the driver is somehow still loaded.
     UninstallKernelMessagesDriver();
 
+    if (!FileExists(driverPath)) {
+        std::cout << "Driver file not found at: " << driverPath << std::endl;
+    }
+
     SC_HANDLE hSCManager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
     if (!hSCManager) {
         std::cout << "Failed to open Service Control Manager. Error: " << GetLastError() << std::endl;
@@ -41,10 +104,14 @@ void InstallKernelMessagesDriver()
     }
     CloseServiceHandle(hService);
     CloseServiceHandle(hSCManager);
+
+    StartDriverSvc();
 }
 
 void UninstallKernelMessagesDriver()
 {
+    StopDriverSvc();
+
     SC_HANDLE hSCManager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
     if (!hSCManager)
     {

application/DebugViewppLib/KernelReader.cpp

@@ -23,8 +23,8 @@ void KernelReader::StartListening()
         NULL));
     if (handle.get() == INVALID_HANDLE_VALUE)
     {
-        printf("Could not connect to kernel messages driver");
-        throw std::runtime_error("Could not connect to kernel messages driver");
+        printf("Could not find the kernel messages driver device name");
+        throw std::runtime_error("Could not find the kernel messages driver device name");
     }
 
     // enable capture
@@ -34,7 +34,7 @@ void KernelReader::StartListening()
     if (!bRet)
     {
         printf("DBGV_CAPTURE_KERNEL failed, err=%d\n", ::GetLastError());
-        throw std::runtime_error("Could not connect to kernel messages driver");
+        throw std::runtime_error("Could not enable capturing kernel messages");
     }
 
     m_handle = std::move(handle);