Deprecate objectHasAttribute expectations/verifiers

Author: particleflux

docs/supported_expectations.md

@@ -21,8 +21,6 @@ toHaveSameSizeAs
 
 ### BaseObject
 ```
-notToHaveAttribute
-toHaveAttribute
 notToHaveProperty
 toHaveProperty
 ```

docs/supported_verifiers.md

@@ -21,8 +21,6 @@ sameSize
 
 ### BaseObject
 ```
-hasAttribute
-notHasAttribute
 hasProperty
 notHasProperty
 ```

src/Codeception/Verify/Expectations/ExpectBaseObject.php

@@ -24,26 +24,30 @@ public function __construct(object $object)
     /**
      * Expect that an object does not have a specified attribute.
      *
+     * @deprecated Deprecated in favour of notToHaveProperty
+     *
      * @param string $attributeName
      * @param string $message
      * @return self
      */
     public function notToHaveAttribute(string $attributeName, string $message = ''): self
     {
-        Assert::assertObjectNotHasAttribute($attributeName, $this->actual, $message);
+        Assert::assertObjectNotHasProperty($attributeName, $this->actual, $message);
         return $this;
     }
 
     /**
      * Expect that an object has a specified attribute.
      *
+     * @deprecated Deprecated in favour of toHaveProperty
+     *
      * @param string $attributeName
      * @param string $message
      * @return self
      */
     public function toHaveAttribute(string $attributeName, string $message = ''): self
     {
-        Assert::assertObjectHasAttribute($attributeName, $this->actual, $message);
+        Assert::assertObjectHasProperty($attributeName, $this->actual, $message);
         return $this;
     }
 

src/Codeception/Verify/Verifiers/VerifyBaseObject.php

@@ -24,26 +24,30 @@ public function __construct(object $object)
     /**
      * Verifies that an object has a specified attribute.
      *
+     * @deprecated Deprecated in favour of hasProperty
+     *
      * @param string $attributeName
      * @param string $message
      * @return self
      */
     public function hasAttribute(string $attributeName, string $message = ''): self
     {
-        Assert::assertObjectHasAttribute($attributeName, $this->actual, $message);
+        Assert::assertObjectHasProperty($attributeName, $this->actual, $message);
         return $this;
     }
 
     /**
      * Verifies that an object does not have a specified attribute.
      *
+     * @deprecated Deprecated in favour of notHasProperty
+     *
      * @param string $attributeName
      * @param string $message
      * @return self
      */
     public function notHasAttribute(string $attributeName, string $message = ''): self
     {
-        Assert::assertObjectNotHasAttribute($attributeName, $this->actual, $message);
+        Assert::assertObjectNotHasProperty($attributeName, $this->actual, $message);
         return $this;
     }