Merge pull request #20 from Codeception/issue-6022

Naktibalda · web-flow · commit 956101b060a0 · 2021-01-02T20:59:34.000+02:00
Add form elements with form attribute to cloned Form
diff --git a/src/Codeception/Lib/InnerBrowser.php b/src/Codeception/Lib/InnerBrowser.php
@@ -1003,6 +1003,18 @@ private function getFormFromCrawler(Crawler $form)
     {
         $fakeDom = new \DOMDocument();
         $fakeDom->appendChild($fakeDom->importNode($form->getNode(0), true));
+
+        //add fields having form attribute with id of this form
+        $formId = $form->attr('id');
+        if ($formId !== null) {
+            $fakeForm = $fakeDom->firstChild;
+            $topParent = $form->parents()->last();
+            $fieldsByFormAttribute = $topParent->filter("input[form=$formId],select[form=$formId],textarea[form=$formId]");
+            foreach ($fieldsByFormAttribute as $field) {
+                $fakeForm->appendChild($fakeDom->importNode($field, true));
+            }
+        }
+
         $node = $fakeDom->documentElement;
         $action = (string)$this->getFormUrl($form);
         $cloned = new Crawler($node, $action, $this->getBaseUrl());
diff --git a/tests/data/app/view/form/input-not-in-form.php b/tests/data/app/view/form/input-not-in-form.php
@@ -0,0 +1,16 @@
+<html>
+<body>
+    <div class="login-container2">
+        <form action="/form/button" id="form1" accept-charset="utf-8" method="post"></form>
+        <div class="form-element-row">
+            <button form="form1" name="btn[login]" class="primary small">Login</button>
+        </div>
+        <div class="form-element-row">
+            <input type="text" id="form1-username" name="username" placeholder="User code" form="form1"/>
+        </div>
+        <div class="form-element-row">
+            <input type="password" id="form1-password" name="password" placeholder="Password" form="form1"/>
+        </div>
+    </div>
+</body>
+</html>
diff --git a/tests/unit/Codeception/Module/TestsForWeb.php b/tests/unit/Codeception/Module/TestsForWeb.php
@@ -1684,6 +1684,17 @@ public function testClickButtonWithFormInvalidIdOutside()
         $this->module->click('Invalid form');
     }
 
+    /**
+     * https://github.com/Codeception/Codeception/issues/6022
+     */
+    public function testFillFieldNotInForm()
+    {
+        $this->module->amOnPage('/form/input-not-in-form');
+        $this->module->seeElement("form",["id" => "form1"]);
+        $this->module->seeElement("input",["name" => "username"]);
+        $this->module->fillField("username","usr-code");
+    }
+
     public function testSubmitHashForm()
     {
         $this->module->amOnPage('/form/anchor');
