release: fixes

vytisbulkevicius · web-flow · commit 5fabb00e4604 · 2023-12-20T00:52:35.000+02:00
### Improvements
- **Added chart responsive support**
- **SDK Updates**

### Bug Fixes
- **Fixed chart data filter issue**
- **Fixed animation issue fusion builder**
- **Fixed live import issue with Gutenberg block**
- **Fixed tooltip text rendering issue in ChartJS**
- **Fixed onboarding chart import issue**
- **Removed PHP deprecated function**
- **Fixed compatibility issue with WP VIP**
- **Fixed PHP 8.1 deprecated error**
diff --git a/classes/Visualizer/Gutenberg/Block.php b/classes/Visualizer/Gutenberg/Block.php
@@ -90,7 +90,7 @@ public function enqueue_gutenberg_scripts() {
 
 		// Enqueue the bundled block JS file
 		wp_enqueue_script( 'handsontable', $handsontableJS );
-		wp_enqueue_script( 'visualizer-gutenberg-block', $blockPath, array( 'wp-api', 'handsontable', 'visualizer-datatables', 'moment' ), $version, true );
+		wp_enqueue_script( 'visualizer-gutenberg-block', $blockPath, array( 'wp-api', 'handsontable', 'visualizer-datatables', 'moment', 'lodash' ), $version, true );
 
 		$type = 'community';
 
@@ -442,8 +442,8 @@ public function get_visualizer_data( $post ) {
 
 		$json_paging = get_post_meta( $post_id, Visualizer_Plugin::CF_JSON_PAGING, true );
 
-		if ( ! empty( $import ) && ! empty( $schedule ) ) {
-			$data['visualizer-chart-url'] = $import;
+		if ( ! empty( $import ) && $schedule >= 0 ) {
+			$data['visualizer-chart-url']      = $import;
 			$data['visualizer-chart-schedule'] = $schedule;
 		}
 
@@ -598,7 +598,7 @@ public function update_chart_data( $data ) {
 			update_post_meta( $data['id'], Visualizer_Plugin::CF_SERIES, $data['visualizer-series'] );
 			update_post_meta( $data['id'], Visualizer_Plugin::CF_SETTINGS, $data['visualizer-settings'] );
 
-			if ( $data['visualizer-chart-url'] && $data['visualizer-chart-schedule'] ) {
+			if ( $data['visualizer-chart-url'] && $data['visualizer-chart-schedule'] >= 0 ) {
 				$chart_url = esc_url_raw( $data['visualizer-chart-url'] );
 				$chart_schedule = intval( $data['visualizer-chart-schedule'] );
 				update_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_URL, $chart_url );
@@ -621,6 +621,16 @@ public function update_chart_data( $data ) {
 					delete_post_meta( $data['id'], Visualizer_Plugin::CF_DB_SCHEDULE );
 					delete_post_meta( $data['id'], Visualizer_Plugin::CF_DB_QUERY );
 				}
+
+				if ( 'Visualizer_Source_Csv_Remote' === $source_type ) {
+					$schedule_url = $data['visualizer-chart-url'];
+					$schedule_id  = $data['visualizer-chart-schedule'];
+					update_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_URL, $schedule_url );
+					update_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_SCHEDULE, $schedule_id );
+				} else {
+					delete_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_URL );
+					delete_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_SCHEDULE );
+				}
 			}
 
 			if ( $source_type === 'Visualizer_Source_Json' ) {
diff --git a/classes/Visualizer/Gutenberg/build/block.js b/classes/Visualizer/Gutenberg/build/block.js
diff --git a/classes/Visualizer/Gutenberg/src/Components/ChartEditor.js b/classes/Visualizer/Gutenberg/src/Components/ChartEditor.js
@@ -80,7 +80,7 @@ class ChartEditor extends Component {
 
 				<ButtonGroup>
 					<Button
-						isDefault
+						variant="secondary"
 						isLarge
 						onClick={ this.props.toggleModal }
 					>
diff --git a/classes/Visualizer/Gutenberg/src/Components/ChartSelect.js b/classes/Visualizer/Gutenberg/src/Components/ChartSelect.js
@@ -56,8 +56,7 @@ class ChartSelect extends Component {
 	}
 
 	render() {
-
-		let chartVersion = 'undefined' !== typeof google ? google.visualization.Version : 'current';
+		let chartVersion = 'undefined' !== typeof google.visualization ? google.visualization.Version : 'current';
 
 		let chart, footer;
 
diff --git a/classes/Visualizer/Gutenberg/src/Components/Import/RemoteImport.js b/classes/Visualizer/Gutenberg/src/Components/Import/RemoteImport.js
@@ -86,6 +86,7 @@ class RemoteImport extends Component {
 							value={ this.props.chart['visualizer-chart-schedule'] ? this.props.chart['visualizer-chart-schedule'] : 1 }
 							options={ [
 								{ label: __( 'Each hour' ), value: '1' },
+								{ label: __( 'Live' ), value: '0' },
 								{ label: __( 'Each 12 hours' ), value: '12' },
 								{ label: __( 'Each day' ), value: '24' },
 								{ label: __( 'Each 3 days' ), value: '72' }
diff --git a/classes/Visualizer/Gutenberg/src/Components/Import/SQLEditor.js b/classes/Visualizer/Gutenberg/src/Components/Import/SQLEditor.js
@@ -97,7 +97,7 @@ class SQLEditor extends Component {
 				<div className="visualizer-db-query-actions">
 					<Button
 						isLarge
-						isDefault
+						variant="secondary"
 						isBusy={ this.state.isLoading }
 						onClick={ this.onSave }
 					>
diff --git a/classes/Visualizer/Gutenberg/src/Components/Sidebar/SeriesSettings.js b/classes/Visualizer/Gutenberg/src/Components/Sidebar/SeriesSettings.js
@@ -62,8 +62,8 @@ class SeriesSettings extends Component {
 					.map( ( i, index ) => {
 						i = parseInt( i ) + 1;
                         let indexToFormat = parseInt( i );
-                        let label = series[i].label || '';
-                        let type = series[i].type || '';
+                        let label = 'object' === typeof series[i] ? series[i].label : '';
+                        let type = 'object' == typeof series[i] ? series[i].type : '';
                         let timer = 0;
                         if ( 'tabular' !== type ) {
                             indexToFormat = index;
diff --git a/classes/Visualizer/Gutenberg/src/Editor.js b/classes/Visualizer/Gutenberg/src/Editor.js
@@ -587,7 +587,7 @@ class Editor extends Component {
 						<ButtonGroup>
 
 							<Button
-								isDefault
+								variant="secondary"
 								isLarge
 								onClick={ () => {
 									let route;
@@ -608,7 +608,7 @@ class Editor extends Component {
 
 									{ false === this.state.isModified ?
 										<Button
-											isDefault
+											variant="secondary"
 											isLarge
                                             className="visualizer-bttn-done"
 											onClick={ () => {
diff --git a/classes/Visualizer/Gutenberg/webpack.config.js b/classes/Visualizer/Gutenberg/webpack.config.js
@@ -3,6 +3,9 @@ const NODE_ENV = process.env.NODE_ENV || 'development';
 const MiniCssExtractPlugin = require( 'mini-css-extract-plugin' );
 
 module.exports = {
+	externals: {
+        'lodash': 'lodash'
+    },
 	mode: NODE_ENV,
 	entry: './src/index.js',
 	output: {
diff --git a/classes/Visualizer/Module.php b/classes/Visualizer/Module.php
@@ -523,6 +523,10 @@ protected function get_user_customization_js() {
 		require_once( ABSPATH . 'wp-admin/includes/file.php' );
 		WP_Filesystem();
 		global $wp_filesystem;
+		if ( ! is_a( $wp_filesystem, 'WP_Filesystem_Base' ) ) {
+			$creds = request_filesystem_credentials( site_url() );
+			wp_filesystem( $creds );
+		}
 
 		$multisite_arg = '/';
 		if ( is_multisite() && ! is_main_site() ) {
diff --git a/classes/Visualizer/Module/Chart.php b/classes/Visualizer/Module/Chart.php
@@ -1587,6 +1587,10 @@ public function save_chart_image( $base64_img, $chart_id, $save_attachment = tru
 		require_once ABSPATH . '/wp-admin/includes/file.php';
 		\WP_Filesystem();
 		global $wp_filesystem;
+		if ( ! is_a( $wp_filesystem, 'WP_Filesystem_Base' ) ) {
+			$creds = request_filesystem_credentials( site_url() );
+			wp_filesystem( $creds );
+		}
 		$upload_file = $wp_filesystem->put_contents( $upload_path . $hashed_filename, $decoded );
 
 		// Insert new chart image.
diff --git a/classes/Visualizer/Module/Wizard.php b/classes/Visualizer/Module/Wizard.php
@@ -212,12 +212,13 @@ private function setup_wizard_import_chart() {
 			'message' => __( 'Something went wrong while importing the chart', 'visualizer' ),
 		);
 
+		$data     = $source->getData();
 		$args     = array(
 			'post_type'    => Visualizer_Plugin::CPT_VISUALIZER,
 			'post_title'   => 'Visualization',
 			'post_author'  => get_current_user_id(),
 			'post_status'  => 'publish',
-			'post_content' => $source->getData(),
+			'post_content' => $data,
 		);
 		$chart_id = wp_insert_post( $args );
 
@@ -232,8 +233,10 @@ private function setup_wizard_import_chart() {
 			update_post_meta( $chart_id, Visualizer_Plugin::CF_SERIES, $series );
 			update_post_meta( $chart_id, Visualizer_Plugin::CF_CHART_LIBRARY, '' );
 
+			$data           = maybe_unserialize( $data );
 			$setting_series = array();
-			foreach ( $series as $s ) {
+			$setting_slices = array();
+			foreach ( $data as $s ) {
 				$setting_series[] = array(
 					'visibleInLegend' => '',
 					'lineWidth'       => '',
@@ -243,6 +246,10 @@ private function setup_wizard_import_chart() {
 					'color'           => '',
 					'role'            => '',
 				);
+				$setting_slices[] = array(
+					'offset' => 0,
+					'color'  => '',
+				);
 			}
 			update_post_meta(
 				$chart_id,
@@ -289,7 +296,7 @@ private function setup_wizard_import_chart() {
 					),
 					'focusTarget'     => 'datum',
 					'series'          => $setting_series,
-					'slices'          => array(),
+					'slices'          => $setting_slices,
 					'vAxis'           => array(
 						'title'          => '',
 						'textPosition'   => '',
diff --git a/classes/Visualizer/Source/Csv.php b/classes/Visualizer/Source/Csv.php
@@ -115,8 +115,6 @@ private function _fetchSeries( &$handle ) {
 	 * @return resource File handle resource on success, otherwise FALSE.
 	 */
 	protected function _get_file_handle( $filename = false ) {
-		// set line endings auto detect mode
-		ini_set( 'auto_detect_line_endings', true );
 		// open file and return handle
 		return fopen( $filename ? $filename : $this->_filename, 'rb' );
 	}
diff --git a/classes/Visualizer/Source/Query/Params.php b/classes/Visualizer/Source/Query/Params.php
@@ -318,7 +318,7 @@ public static function get_db_tables() {
 		if ( $tables ) {
 			return $tables;
 		}
-
+		$tables = array();
 		$prefix = apply_filters( 'visualizer_db_prefix', $wpdb->prefix );
 		$sql    = $wpdb->get_col( 'SHOW TABLES', 0 );
 		foreach ( $sql as $table ) {
diff --git a/composer.lock b/composer.lock
diff --git a/index.php b/index.php
@@ -73,7 +73,9 @@ function visualizer_launch() {
 	define( 'VISUALIZER_REST_VERSION', 1 );
 	// if the below is true, then the js/customization.js in the plugin folder will be used instead of the one in the uploads folder (if it exists).
 	// this is also used in Block.php
-	define( 'VISUALIZER_TEST_JS_CUSTOMIZATION', false );
+	if ( ! defined( 'VISUALIZER_TEST_JS_CUSTOMIZATION' ) ) {
+		define( 'VISUALIZER_TEST_JS_CUSTOMIZATION', false );
+	}
 
 	if ( ! defined( 'VISUALIZER_CSV_DELIMITER' ) ) {
 		define( 'VISUALIZER_CSV_DELIMITER', ',' );
diff --git a/js/render-chartjs.js b/js/render-chartjs.js
@@ -133,7 +133,8 @@
                     }
                     var format = context.dataset.format || '';
                     if ( format ) {
-                        label += format_datum( context.formattedValue, format );
+                        var lastSuffix = numeral(context.formattedValue).format(format).replace(/[0-9]/g, '');
+                        label += context.formattedValue + lastSuffix;
                     } else {
                         format = 'undefined' !== typeof context.chart.config._config.options.format ? context.chart.config._config.options.format : '';
                         if ( format ) {
@@ -467,7 +468,7 @@
         switch(type) {
             case 'number':
                 // numeral.js works on 0 instead of # so we just replace that in the ICU pattern set.
-                format = format.replace(/#/g, '0');
+                format = format.replace(/#/g, '0').replace(/%/g, '');
                 // we also replace all instance of '$' as that is more relevant for ticks.
                 if(removeDollar){
                     format = format.replace(/\$/g, '');
diff --git a/js/render-facade.js b/js/render-facade.js
@@ -3,7 +3,7 @@
 /* global jQuery */
 var vizClipboard1=null;
 (function($, visualizer){
-
+    
     function initActionsButtons(v) {
         if($('a.visualizer-chart-shortcode').length > 0 && vizClipboard1 === null) {
             vizClipboard1 = new ClipboardJS('a.visualizer-chart-shortcode'); // jshint ignore:line
@@ -107,17 +107,10 @@ var vizClipboard1=null;
         registerDefaultActions();
     });
 
-    // Refresh charts if chart not generated.
-    function refreshEachCharts() {
-        setTimeout( function() {
-            displayChartsOnFrontEnd();
-        }, 100 );
-    }
-
     function initChartDisplay() {
         if(visualizer.is_front == true){ // jshint ignore:line
             displayChartsOnFrontEnd();
-        }else{
+        } else {
             showChart();
         }
     }
@@ -135,14 +128,15 @@ var vizClipboard1=null;
     }
 
     function displayChartsOnFrontEnd() {
-        // display all charts that are NOT to be lazy-loaded.
-        $( 'div.viz-facade-loaded:not(.visualizer-lazy):not(.visualizer-cw-error):empty' ).removeClass( 'viz-facade-loaded' );
-        $('div.visualizer-front:not(.visualizer-lazy):not(.viz-facade-loaded)').each(function(index, element){
+
+        $('div.visualizer-front:not(.viz-facade-loaded):not(.visualizer-lazy):not(.visualizer-cw-error):empty').each(function(index, element){
             if ( $(element).is(':visible') ) {
                 var id = $(element).addClass('viz-facade-loaded').attr('id');
-                showChart(id);
+                setTimeout(function(){
+                    // Add a short delay between each chart to avoid overloading the browser event loop.
+                    showChart(id);
+                }, ( index + 1 ) * 100);
             }
-            refreshEachCharts();
         });
 
         // interate through all charts that are to be lazy-loaded and observe each one.
diff --git a/js/render-google.js b/js/render-google.js

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ class ChartEditor extends Component {`
`80`	`80`
`81`	`81`	`<ButtonGroup>`
`82`	`82`	`<Button`
`83`		`- isDefault`
	`83`	`+ variant="secondary"`
`84`	`84`	`isLarge`
`85`	`85`	`onClick={ this.props.toggleModal }`
`86`	`86`	`>`
Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,7 @@ class ChartSelect extends Component {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`render() {`
`59`		`-`
`60`		`- let chartVersion = 'undefined' !== typeof google ? google.visualization.Version : 'current';`
	`59`	`+ let chartVersion = 'undefined' !== typeof google.visualization ? google.visualization.Version : 'current';`
`61`	`60`
`62`	`61`	`let chart, footer;`
`63`	`62`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ class SQLEditor extends Component {`
`97`	`97`	`<div className="visualizer-db-query-actions">`
`98`	`98`	`<Button`
`99`	`99`	`isLarge`
`100`		`- isDefault`
	`100`	`+ variant="secondary"`
`101`	`101`	`isBusy={ this.state.isLoading }`
`102`	`102`	`onClick={ this.onSave }`
`103`	`103`	`>`