fix(test-runner): Improve async test result handling in TestRunnerService

CoderGamester · CoderGamester · commit f0d0bcf07942 · 2025-06-23T16:19:36.000+03:00
feat(git-commits): New windsurf workflow to commit changes to git Closes #55
diff --git a/.gitignore b/.gitignore
@@ -114,7 +114,6 @@ GvhProjectSettings.xml
 **/package-lock.json
 **/package-lock.json.meta
 .codeiumignore
-.windsurf
 Server~/log.txt
 Server~/log.txt.meta
 log.txt
diff --git a/.windsurf/workflows/git-commits.md b/.windsurf/workflows/git-commits.md
@@ -0,0 +1,101 @@
+---
+description: Git Commit Workflow
+---
+
+## Git Conventional Commit Workflow
+
+Cascade **MUST** follow this workflow to ensure all git changes are reviewed, structured, and committed correctly using the Conventional Commits specification.
+
+### Step 1: Assess the State of the Repository
+
+1.  **Check for Uncommitted Changes**: Run `git status` to get an overview of modified, staged, and untracked files.
+
+### Step 2: Stage and Review Changes
+
+1.  **Stage All Changes**: Run `git add .` to stage all modifications.
+2.  **Collect Staged Changes**: Run `git diff --staged --word-diff` to get a complete overview of all the changes that will be included in the commit. This is crucial for accurately summarizing the changes.
+
+### Step 3: Propose the Commit Message
+
+- Based on the collected diff, formulate a commit message. The message **MUST** be presented to the USER in a markdown block for review before committing.
+- When referencing file changes in a commit body, **MUST** use the filename only (e.g., `McpUtils.cs`), not the full path (e.g. `cci:7://file:///c:/mcp-unity/Editor/Utils/conventional-commits.md:0:0-0:0`).
+
+#### Structuring the Commit
+
+**For commits containing a single, focused change:**
+- Use a standard, single-line header.
+- The body is optional and should only be used for significant explanations.
+
+**For commits containing multiple, logically distinct changes:**
+- The header **MUST** list each distinct change on a separate line. Each line must follow the `<type>(scope): <description>` format.
+- The body should provide a high-level summary of the overall changes.
+
+**Format:**
+# For a single change:
+```
+<type>(scope): <description>
+
+[optional footer(s)]
+```
+
+# For multiple changes:
+```
+<type>(scope1): <description1>
+<type>(scope2): <description2>
+
+<body summarizing the overall changes>
+
+[optional footer(s)]
+```
+
+-   **Types**: `feat`, `fix`, `build`, `chore`, `ci`, `docs`, `perf`, `refactor`, `revert`, `style`, `test`.
+-   **Scope**: For providing context (e.g., `feat(api): ...`).
+-   **Description**: A concise, imperative summary of a single, distinct change.
+-   **Body**: Explain the 'what' and 'impact' of the changes. For commits with multiple headers, the body should summarize the combined effort.
+-   **Footer** (Optional): Use for `BREAKING CHANGE:` notifications or for referencing issue numbers (e.g., `Closes #55`).
+
+### Example Commit Message Proposals
+
+Here is how you should present commit messages for review.
+
+#### Example 1: Single Change (No Body Needed)
+For simple, self-explanatory changes where the header is sufficient.
+
+```markdown
+fix(login): Correct typo in user login prompt
+
+Closes #100
+```
+
+#### Example 2: Single Change (Body Included)
+For a significant change that requires more context to explain the 'what' and 'why'.
+
+```markdown
+refactor(auth): Overhaul authentication flow to use JWTs
+
+This commit replaces session-based authentication with JWTs to improve statelessness and scalability.
+
+Impacts:
+- API endpoints now expect a JWT in the Authorization header.
+- User login returns a JWT.
+- Session management code has been removed.
+
+Closes #111
+```
+
+#### Example 3: Multiple Changes
+For commits that bundle several distinct changes, use a multi-line header and a summary body.
+
+```markdown
+feat(auth): Add password reset functionality
+refactor(login): Revamp login page style
+
+This commit introduces a new login flow and modernizes the UI. It adds a password reset endpoint and decouples the email service for better maintainability.
+
+Impacts:
+- A new API endpoint `/api/auth/reset-password` is now available.
+- The email template system is now in a separate service module.
+- The login page CSS in `login.css` has been updated.
+
+Closes #123
+```
diff --git a/Editor/Services/TestRunnerService.cs b/Editor/Services/TestRunnerService.cs
@@ -30,20 +30,10 @@ public class TestRunnerService : ITestRunnerService, ICallbacks
         public TestRunnerService()
         {
             _testRunnerApi = ScriptableObject.CreateInstance<TestRunnerApi>();
-            
+            _results = new List<ITestResultAdaptor>();
             _testRunnerApi.RegisterCallbacks(this);
         }
 
-        [MenuItem("Tools/MCP Unity/Debug call path")]
-        public static async void DebugCallGetAllTests()
-        {
-            var service = new TestRunnerService();
-            var tests = await service.GetAllTestsAsync();
-            Debug.Log($"Retrieved {tests.Count} tests:");
-            foreach (var t in tests)
-                Debug.Log($"Test: {t.FullName} ({t.TestMode}) - State: {t.RunState}");
-        }
-
         /// <summary>
         /// Async retrieval of all tests using TestRunnerApi callbacks
         /// </summary>
@@ -83,11 +73,11 @@ public async Task<List<ITestAdaptor>> GetAllTestsAsync(string testModeFilter = "
         /// <returns>Task that resolves with test results when tests are complete</returns>
         public async Task<JObject> ExecuteTestsAsync(TestMode testMode, bool returnOnlyFailures, bool returnWithLogs, string testFilter = "")
         {
+            var filter = new Filter { testMode = testMode };
+
             _tcs = new TaskCompletionSource<JObject>();
-            _results = new List<ITestResultAdaptor>();
             _returnOnlyFailures = returnOnlyFailures;
             _returnWithLogs = returnWithLogs;
-            var filter = new Filter { testMode = testMode };
 
             if (!string.IsNullOrEmpty(testFilter))
             {
@@ -148,6 +138,7 @@ public void RunStarted(ITestAdaptor testsToRun)
             if (_tcs == null)
                 return;
             
+            _results.Clear();
             McpLogger.LogInfo($"Test run started: {testsToRun?.Name}");
         }
 
